chore(NA): upgrade typescript into v5.4.5

.eslintrc.js

@@ -1174,13 +1174,13 @@ module.exports = {
     },
     {
       files: [
-        'x-pack/solutions/observability/plugins/apm/**/*.{js,mjs,ts,tsx}',
-        'x-pack/solutions/observability/plugins/apm_data_access/**/*.{js,mjs,ts,tsx}',
-        'x-pack/solutions/observability/plugins/infra/**/*.{js,mjs,ts,tsx}',
-        'x-pack/solutions/observability/plugins/inventory/**/*.{js,mjs,ts,tsx}',
-        'x-pack/solutions/observability/plugins/metrics_data_access/**/*.{js,mjs,ts,tsx}',
-        'x-pack/solutions/observability/plugins/profiling/**/*.{js,mjs,ts,tsx}',
-        'x-pack/solutions/observability/plugins/profiling_data_access/**/*.{js,mjs,ts,tsx}',
+        'x-pack/solutions/observability/plugins/apm/**/*.{ts,tsx}',
+        'x-pack/solutions/observability/plugins/apm_data_access/**/*.{ts,tsx}',
+        'x-pack/solutions/observability/plugins/infra/**/*.{ts,tsx}',
+        'x-pack/solutions/observability/plugins/inventory/**/*.{ts,tsx}',
+        'x-pack/solutions/observability/plugins/metrics_data_access/**/*.{ts,tsx}',
+        'x-pack/solutions/observability/plugins/profiling/**/*.{ts,tsx}',
+        'x-pack/solutions/observability/plugins/profiling_data_access/**/*.{ts,tsx}',
       ],
       rules: {
         '@typescript-eslint/consistent-type-imports': 'error',
@@ -1195,7 +1195,6 @@ module.exports = {
       plugins: ['testing-library'],
       rules: {
         'testing-library/await-async-utils': 'error',
-        '@typescript-eslint/consistent-type-imports': 'error',
         'import/order': [
           'warn',
           {
@@ -1218,8 +1217,7 @@ module.exports = {
       rules: {
         'import/no-nodejs-modules': 'error',
         'no-duplicate-imports': 'off',
-        '@typescript-eslint/no-duplicate-imports': 'error',
-        '@typescript-eslint/consistent-type-imports': 'error',
+        'import/no-duplicates': 'error',
         'no-restricted-imports': [
           'error',
           {
@@ -1230,19 +1228,28 @@ module.exports = {
         ],
       },
     },
+    {
+      files: [
+        'x-pack/platform/plugins/shared/automatic_import/public/**/*.{ts,tsx}',
+        'x-pack/platform/plugins/shared/automatic_import/common/**/*.{ts,tsx}',
+      ],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
+      },
+    },
 
     /**
      * ML overrides
      */
     {
       files: [
-        'x-pack/platform/plugins/shared/aiops/**/*.{js,mjs,ts,tsx}',
-        'x-pack/platform/plugins/private/data_visualizer/**/*.{js,mjs,ts,tsx}',
-        'x-pack/platform/plugins/shared/ml/**/*.{js,mjs,ts,tsx}',
-        'x-pack/platform/plugins/private/transform/**/*.{js,mjs,ts,tsx}',
-        'x-pack/platform/packages/shared/ml/**/*.{js,mjs,ts,tsx}',
-        'x-pack/platform/packages/private/ml/**/*.{js,mjs,ts,tsx}',
-        'x-pack/platform/plugins/private/file_upload/**/*.{js,mjs,ts,tsx}',
+        'x-pack/platform/plugins/shared/aiops/**/*.{ts,tsx}',
+        'x-pack/platform/plugins/private/data_visualizer/**/*.{ts,tsx}',
+        'x-pack/platform/plugins/shared/ml/**/*.{ts,tsx}',
+        'x-pack/platform/plugins/private/transform/**/*.{ts,tsx}',
+        'x-pack/platform/packages/shared/ml/**/*.{ts,tsx}',
+        'x-pack/platform/packages/private/ml/**/*.{ts,tsx}',
+        'x-pack/platform/plugins/private/file_upload/**/*.{ts,tsx}',
       ],
       rules: {
         '@typescript-eslint/consistent-type-imports': 'error',
@@ -1280,7 +1287,7 @@ module.exports = {
       rules: {
         'import/no-nodejs-modules': 'error',
         'no-duplicate-imports': 'off',
-        '@typescript-eslint/no-duplicate-imports': ['error'],
+        'import/no-duplicates': ['error'],
         'no-restricted-imports': [
           'error',
           {
@@ -1466,20 +1473,20 @@ module.exports = {
         'require-atomic-updates': 'error',
         'symbol-description': 'error',
         'vars-on-top': 'error',
-        '@typescript-eslint/no-duplicate-imports': ['error'],
+        'import/no-duplicates': ['error'],
       },
       overrides: [
         {
           files: [
-            'x-pack/platform/plugins/shared/cases/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/plugins/ecs_data_quality_dashboard/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/plugins/security_solution/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/plugins/security_solution_ess/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/plugins/security_solution_serverless/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/packages/data-stream-adapter/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/packages/features/**/*.{js,mjs,ts,tsx}',
-            'x-pack/solutions/security/packages/navigation/**/*.{js,mjs,ts,tsx}',
-            'src/platform/packages/shared/kbn-cell-actions/**/*.{js,mjs,ts,tsx}',
+            'x-pack/platform/plugins/shared/cases/**/*.{ts,tsx}',
+            'x-pack/solutions/security/plugins/ecs_data_quality_dashboard/**/*.{ts,tsx}',
+            'x-pack/solutions/security/plugins/security_solution/**/*.{ts,tsx}',
+            'x-pack/solutions/security/plugins/security_solution_ess/**/*.{ts,tsx}',
+            'x-pack/solutions/security/plugins/security_solution_serverless/**/*.{ts,tsx}',
+            'x-pack/solutions/security/packages/data-stream-adapter/**/*.{ts,tsx}',
+            'x-pack/solutions/security/packages/features/**/*.{ts,tsx}',
+            'x-pack/solutions/security/packages/navigation/**/*.{ts,tsx}',
+            'src/platform/packages/shared/kbn-cell-actions/**/*.{ts,tsx}',
           ],
           rules: {
             '@typescript-eslint/consistent-type-imports': 'error',
@@ -1842,7 +1849,6 @@ module.exports = {
         'src/platform/plugins/shared/saved_search/**/*.{js,mjs,ts,tsx}',
       ],
       rules: {
-        '@typescript-eslint/consistent-type-imports': 'error',
         '@typescript-eslint/no-explicit-any': 'error',
         '@typescript-eslint/ban-ts-comment': [
           'error',
@@ -1852,6 +1858,15 @@ module.exports = {
         ],
       },
     },
+    {
+      files: [
+        'src/platform/plugins/shared/discover/**/*.{ts,tsx}',
+        'src/platform/plugins/shared/saved_search/**/*.{ts,tsx}',
+      ],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
+      },
+    },
 
     /**
      * Enterprise Search overrides
@@ -2080,8 +2095,18 @@ module.exports = {
         'prefer-arrow-callback': 'error',
         'no-unused-vars': 'off',
         'react/prop-types': 'off',
-        '@typescript-eslint/consistent-type-imports': 'error',
         '@typescript-eslint/explicit-module-boundary-types': 'off',
+        '@typescript-eslint/no-empty-object-type': 'off',
+        '@typescript-eslint/no-unsafe-function-type': 'off',
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+        '@typescript-eslint/no-require-imports': 'off',
+      },
+    },
+    {
+      files: ['x-pack/platform/plugins/shared/osquery/**/*.{ts,tsx}'],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
       },
     },
     {
@@ -2123,7 +2148,6 @@ module.exports = {
         'x-pack/platform/test/spaces_api_integration/**/*.{js,mjs,ts,tsx}',
       ],
       rules: {
-        '@typescript-eslint/consistent-type-imports': 1,
         'import/order': [
           // This rule sorts import declarations
           'error',
@@ -2163,6 +2187,33 @@ module.exports = {
         ],
       },
     },
+    {
+      files: [
+        'src/platform/plugins/private/interactive_setup/**/*.{ts,tsx}',
+        'src/platform/test/interactive_setup_api_integration/**/*.{ts,tsx}',
+        'src/platform/test/interactive_setup_functional/**/*.{ts,tsx}',
+
+        'packages/kbn-mock-idp-plugin/**/*.{ts,tsx}',
+        'src/platform/packages/private/kbn-mock-idp-utils/**/*.{ts,tsx}',
+        'src/platform/packages/shared/kbn-security-hardening/**/*.{ts,tsx}',
+        'src/platform/packages/shared/kbn-user-profile-components/**/*.{ts,tsx}',
+
+        'x-pack/platform/plugins/shared/encrypted_saved_objects/**/*.{ts,tsx}',
+        'x-pack/platform/test/encrypted_saved_objects_api_integration/**/*.{ts,tsx}',
+
+        'x-pack/platform/plugins/shared/security/**/*.{ts,tsx}',
+        'x-pack/platform/packages/private/security/**/*.{ts,tsx}',
+        'x-pack/platform/packages/shared/security/**/*.{ts,tsx}',
+        'x-pack/test/security_api_integration/**/*.{ts,tsx}',
+        'x-pack/test/security_functional/**/*.{ts,tsx}',
+
+        'x-pack/platform/plugins/shared/spaces/**/*.{ts,tsx}',
+        'x-pack/platform/test/spaces_api_integration/**/*.{ts,tsx}',
+      ],
+      rules: {
+        '@typescript-eslint/consistent-type-imports': 1,
+      },
+    },
 
     /**
      * Do not allow `any`

package.json

@@ -83,7 +83,7 @@
     "**/@langchain/core": "^0.3.57",
     "**/@langchain/google-common": "^0.1.8",
     "**/@types/node": "22.15.3",
-    "**/@typescript-eslint/utils": "5.62.0",
+    "**/@typescript-eslint/utils": "8.16.0",
     "**/chokidar": "^3.5.3",
     "**/d3-scale/**/d3-color": "npm:@elastic/kibana-d3-color@2.0.1",
     "**/globule/minimatch": "^3.1.2",
@@ -92,7 +92,7 @@
     "**/langchain": "^0.3.15",
     "**/remark-parse/trim": "1.0.1",
     "**/sharp": "0.32.6",
-    "**/typescript": "5.1.6",
+    "**/typescript": "5.4.5",
     "**/util": "^0.12.5",
     "**/yauzl": "^3.2.0",
     "@aws-sdk/client-bedrock-agent-runtime": "^3.744.0",
@@ -1802,9 +1802,9 @@
     "@types/yargs": "^15.0.0",
     "@types/yauzl": "^2.10.3",
     "@types/yazl": "^2.4.2",
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.62.0",
-    "@typescript-eslint/typescript-estree": "^5.62.0",
+    "@typescript-eslint/eslint-plugin": "^8.16.0",
+    "@typescript-eslint/parser": "^8.16.0",
+    "@typescript-eslint/typescript-estree": "^8.16.0",
     "@wojtekmaj/enzyme-adapter-react-17": "^0.6.7",
     "@yarnpkg/lockfile": "^1.1.0",
     "aggregate-error": "^3.1.0",
@@ -1980,7 +1980,7 @@
     "tree-kill": "^1.2.2",
     "ts-morph": "^15.1.0",
     "tsd": "^0.32.0",
-    "typescript": "5.1.6",
+    "typescript": "5.4.5",
     "val-loader": "^6.0.0",
     "vinyl-fs": "^4.0.0",
     "watchpack": "^1.6.0",

packages/kbn-docs-utils/src/count_eslint_disable.test.ts

@@ -34,7 +34,7 @@ describe('countEslintDisableLines', () => {
     expect(counts).toMatchInlineSnapshot(`
       Object {
         "eslintDisableFileCount": 3,
-        "eslintDisableLineCount": 8,
+        "eslintDisableLineCount": 9,
       }
     `);
   });

packages/kbn-docs-utils/src/types.ts

@@ -47,6 +47,7 @@ export enum TypeKind {
    * Maps to the typescript syntax kind `TypeReferences`. For example,
    * export type FooFn = () => string will be a TypeKind, not a FunctionKind.
    */
+  // eslint-disable-next-line @typescript-eslint/no-shadow
   TypeKind = 'Type',
   /**
    * Uncategorized is used if a type is encountered that isn't handled.

packages/kbn-eslint-config/typescript.js

@@ -55,43 +55,30 @@ module.exports = {
           //
           // Old recommended tslint rules
           '@typescript-eslint/adjacent-overload-signatures': 'error',
-          '@typescript-eslint/array-type': [
-            'error',
-            { default: 'array-simple', readonly: 'array-simple' },
-          ],
-          '@typescript-eslint/ban-types': [
+          '@typescript-eslint/array-type': 'off',
+          // ##
+          // Replacing old @typescript-eslint/ban-types
+          '@typescript-eslint/no-restricted-types': [
             'error',
             {
               types: {
-                SFC: {
-                  message: 'Use FC or FunctionComponent instead.',
-                  fixWith: 'FC',
-                },
-                'React.SFC': {
-                  message: 'Use FC or FunctionComponent instead.',
-                  fixWith: 'React.FC',
-                },
-                StatelessComponent: {
-                  message: 'Use FunctionComponent instead.',
-                  fixWith: 'FunctionComponent',
-                },
-                'React.StatelessComponent': {
-                  message: 'Use FunctionComponent instead.',
-                  fixWith: 'React.FunctionComponent',
-                },
-                // used in the codebase in the wild
-                '{}': false,
-                object: false,
-                Function: false,
+                SFC: 'Use FC or FunctionComponent instead.',
+                'React.SFC': 'Use React.FC instead.',
+                StatelessComponent: 'Use FunctionComponent instead.',
+                'React.StatelessComponent': 'Use React.FunctionComponent instead.',
               },
             },
           ],
+          '@typescript-eslint/no-unsafe-function-type': 'off',
+          '@typescript-eslint/no-wrapper-object-types': 'off',
+          '@typescript-eslint/no-empty-object-type': 'off',
+          // ##
           camelcase: 'off',
           '@typescript-eslint/naming-convention': [
             'error',
             {
               selector: 'default',
-              format: ['camelCase'],
+              format: ['camelCase', 'PascalCase', 'UPPER_CASE', 'snake_case'],
               filter: {
                 regex: allowedNameRegexp,
                 match: false,

packages/kbn-eslint-plugin-eslint/rules/no_export_all.js

@@ -7,10 +7,9 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-const Fs = require('fs');
+const fs = require('fs');
 const ts = require('typescript');
 const { getExportCode, getExportNamedNamespaceCode } = require('../helpers/codegen');
-const tsEstree = require('@typescript-eslint/typescript-estree');
 
 const { getExportNamesDeep } = require('../helpers/exports');
 
@@ -25,6 +24,8 @@ const { getExportNamesDeep } = require('../helpers/exports');
 const ERROR_MSG =
   '`export *` is not allowed in the index files of plugins to prevent accidentally exporting too many APIs';
 
+const sourceFileCache = new Map();
+
 /** @type {Rule} */
 module.exports = {
   meta: {
@@ -40,13 +41,15 @@ module.exports = {
 
         /** @type Parser */
         const parser = (path) => {
-          const code = Fs.readFileSync(path, 'utf-8');
-          const result = tsEstree.parseAndGenerateServices(code, {
-            ...context.parserOptions,
-            comment: false,
-            filePath: path,
-          });
-          return result.services.program.getSourceFile(path);
+          if (sourceFileCache.has(path)) {
+            return sourceFileCache.get(path);
+          }
+
+          const code = fs.readFileSync(path, 'utf-8');
+          const sourceFile = ts.createSourceFile(path, code, ts.ScriptTarget.ESNext, true);
+
+          sourceFileCache.set(path, sourceFile);
+          return sourceFile;
         };
 
         const exportSet = getExportNamesDeep(parser, context.getFilename(), tsnode);

packages/kbn-eslint-plugin-eui-a11y/helpers/get_intent_from_node.ts

@@ -12,11 +12,11 @@ import { TSESTree } from '@typescript-eslint/typescript-estree';
 /*
     Attempts to get a string representation of the intent
     out of an array of nodes.
-    
+
     Currently supported node types in the array:
     * String literal text (JSXText)
     * Translated text via <FormattedMessage> component -> uses prop `defaultMessage`
-    * Translated text via {i18n.translate} call -> uses passed options object key `defaultMessage` 
+    * Translated text via {i18n.translate} call -> uses passed options object key `defaultMessage`
 */
 export function getIntentFromNode(originalNode: TSESTree.JSXOpeningElement): string {
   if (!originalNode.parent) return '';
@@ -79,7 +79,8 @@ export function getIntentFromNode(originalNode: TSESTree.JSXOpeningElement): str
         }
 
         const args: TSESTree.CallExpressionArgument[] = expression.arguments;
-        const callee: TSESTree.LeftHandSideExpression = expression.callee;
+        const callee: TSESTree.LeftHandSideExpression =
+          expression.callee as TSESTree.LeftHandSideExpression;
 
         if (!('object' in callee)) {
           return '';

packages/kbn-eslint-plugin-eui-a11y/helpers/get_prop_values.test.ts

@@ -34,7 +34,7 @@ describe('getPropValues', () => {
             } as any),
         } as any,
       })
-    ).toEqual({
+    ).toMatchObject({
       prop1: { type: 'Literal', value: 'bar', raw: '"bar"' },
       prop2: element.openingElement.attributes[1].value,
     });