Skip to content

[9.1] (Accessibility) Dashboard controls should be grouped as a labelled list (#227633) #227745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 9 commits into from
Jul 16, 2025
Merged

[9.1] (Accessibility) Dashboard controls should be grouped as a labelled list (#227633) #227745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e111ba
(Accessibility) Dashboard controls should be grouped as a labelled li…
mbondyra Jul 12, 2025
13322c8
Merge branch '9.1' into backport/9.1/pr-227633
mbondyra Jul 15, 2025
80378e5
[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'
kibanamachine Jul 15, 2025
2c9d611
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 15, 2025
818ceeb
Update CODEOWNERS
mbondyra Jul 16, 2025
e4447e9
Update CODEOWNERS
mbondyra Jul 16, 2025
803acf4
Update CODEOWNERS
mbondyra Jul 16, 2025
82855a2
Update CODEOWNERS
mbondyra Jul 16, 2025
51743d0
Merge branch '9.1' into backport/9.1/pr-227633
mbondyra Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/platform/plugins/shared/controls/public/control_group/components/control_group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,13 @@ export function ControlGroup({
}}
>
<SortableContext items={controlsInOrder} strategy={rectSortingStrategy}>
<EuiFlexGroup className="controlGroup" alignItems="center" gutterSize="s" wrap={true}>
<EuiFlexGroup
component="ul"
className="controlGroup"
alignItems="center"
gutterSize="s"
wrap={true}
>
{controlsInOrder.map(({ id, type }) => (
<ControlRenderer
key={id}
Expand Down
1 change: 1 addition & 0 deletions src/platform/plugins/shared/controls/public/control_group/components/control_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export const ControlPanel = <ApiType extends DefaultControlApi = DefaultControlA

return (
<EuiFlexItem
component="li"
ref={setNodeRef}
style={{
transition,
Expand Down
2 changes: 1 addition & 1 deletion src/platform/test/functional/page_objects/dashboard_page_controls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ export class DashboardPageControls extends FtrService {

public async rangeSliderEnsurePopoverIsClosed(controlId: string) {
this.log.debug(`Closing popover for Range Slider: ${controlId}`);
const controlLabel = await this.find.byXPath(`//div[@data-control-id='${controlId}']//label`);
const controlLabel = await this.find.byXPath(`//li[@data-control-id='${controlId}']//label`);
await controlLabel.click();
await this.testSubjects.waitForDeleted(`rangeSlider__slider`);
}
Expand Down