Skip to content

Comments

Fixes FIPS test skips in ML Disabled suite#227677

Merged
jeramysoucy merged 5 commits intoelastic:mainfrom
jeramysoucy:fix-fips-skips-ml-disabled
Jul 15, 2025
Merged

Fixes FIPS test skips in ML Disabled suite#227677
jeramysoucy merged 5 commits intoelastic:mainfrom
jeramysoucy:fix-fips-skips-ml-disabled

Conversation

@jeramysoucy
Copy link
Contributor

@jeramysoucy jeramysoucy commented Jul 11, 2025 •
edited by kibanamachine
Loading

Summary

Removes basic check condition because FIPS always overrides to trial.

Follow-up

We should audit for anywhere the license level is being checked for a FIPS skip.
cc @kc13greiner @SiddharthMantri

@jeramysoucy jeramysoucy requested a review from a team as a code owner July 11, 2025 15:04
@jeramysoucy jeramysoucy requested a review from jkelas July 11, 2025 15:04
@jeramysoucy jeramysoucy added the Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// label Jul 11, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 11, 2025

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy added test Feature:FIPS FIPS mode for Kibana labels Jul 11, 2025
@jeramysoucy jeramysoucy self-assigned this Jul 11, 2025
@jeramysoucy jeramysoucy requested a review from nikitaindik July 11, 2025 15:07
@jeramysoucy jeramysoucy added the release_note:skip Skip the PR/issue when compiling release notes label Jul 11, 2025
@nikitaindik nikitaindik added ci:enable-fips-agent backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Jul 14, 2025
@nikitaindik
Copy link
Contributor

nikitaindik commented Jul 14, 2025

Thanks, @jeramysoucy! Changes look good to me, but I've added a ci:enable-fips-agent to make sure it can pass the FIPS pipeline.

@nikitaindik nikitaindik mentioned this pull request Jul 14, 2025
Closed
nikitaindik
nikitaindik approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@nikitaindik nikitaindik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the FIPS-enabled CI run passed, so I approve. Thanks again for preparing this, @jeramysoucy 👍

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 14, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @jeramysoucy

jkelas
jkelas approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@jkelas jkelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Build is green. I am approving.

@jeramysoucy jeramysoucy merged commit 17baca3 into elastic:main Jul 15, 2025
11 of 12 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 15, 2025

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16292041234

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2025
@jeramysoucy @kibanamachine @nikitaindik
Fixes FIPS test skips in ML Disabled suite (elastic#227677)
5048052 
## Summary

Removes basic check condition because FIPS always overrides to trial.

### Follow-up

We should audit for anywhere the license level is being checked for a
FIPS skip.
cc @kc13greiner @SiddharthMantri

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
(cherry picked from commit 17baca3)
@kibanamachine kibanamachine mentioned this pull request Jul 15, 2025
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2025
@jeramysoucy @kibanamachine @nikitaindik
Fixes FIPS test skips in ML Disabled suite (elastic#227677)
4ed0eca 
## Summary

Removes basic check condition because FIPS always overrides to trial.

### Follow-up

We should audit for anywhere the license level is being checked for a
FIPS skip.
cc @kc13greiner @SiddharthMantri

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
(cherry picked from commit 17baca3)
@kibanamachine kibanamachine mentioned this pull request Jul 15, 2025
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2025
@jeramysoucy @kibanamachine @nikitaindik
Fixes FIPS test skips in ML Disabled suite (elastic#227677)
7fd089a 
## Summary

Removes basic check condition because FIPS always overrides to trial.

### Follow-up

We should audit for anywhere the license level is being checked for a
FIPS skip.
cc @kc13greiner @SiddharthMantri

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
(cherry picked from commit 17baca3)
@kibanamachine kibanamachine mentioned this pull request Jul 15, 2025
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2025
@jeramysoucy @kibanamachine @nikitaindik
Fixes FIPS test skips in ML Disabled suite (elastic#227677)
8ecf76f 
## Summary

Removes basic check condition because FIPS always overrides to trial.

### Follow-up

We should audit for anywhere the license level is being checked for a
FIPS skip.
cc @kc13greiner @SiddharthMantri

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
(cherry picked from commit 17baca3)
@kibanamachine kibanamachine mentioned this pull request Jul 15, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 15, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.18
✅ 8.19
✅ 9.0
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jul 15, 2025
Merged
@kc13greiner
Copy link
Contributor

kc13greiner commented Jul 15, 2025 •
edited
Loading

We should audit for anywhere the license level is being checked for a FIPS skip.

@jeramysoucy I think checks like this would already be failing/no-op since the license is always trial, have you seen any functionality like this?

@kibanamachine kibanamachine mentioned this pull request Jul 15, 2025
Merged
kibanamachine added a commit that referenced this pull request Jul 15, 2025
@kibanamachine @jeramysoucy @nikitaindik
[9.0] Fixes FIPS test skips in ML Disabled suite (#227677) (#227987)
17a4d2e 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Fixes FIPS test skips in ML Disabled suite
(#227677)](#227677)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T11:30:05Z","message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","release_note:skip","Feature:FIPS","ci:enable-fips-agent","backport:version","v9.1.0","v8.19.0","v9.2.0","v8.18.4","v9.0.4"],"title":"Fixes
FIPS test skips in ML Disabled
suite","number":227677,"url":"https://github.com/elastic/kibana/pull/227677","mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227677","number":227677,"mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 15, 2025
@kibanamachine @jeramysoucy @nikitaindik
[9.1] Fixes FIPS test skips in ML Disabled suite (#227677) (#227988)
725a05a 
# Backport

This will backport the following commits from `main` to `9.1`:
- [Fixes FIPS test skips in ML Disabled suite
(#227677)](#227677)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T11:30:05Z","message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","release_note:skip","Feature:FIPS","ci:enable-fips-agent","backport:version","v9.1.0","v8.19.0","v9.2.0","v8.18.4","v9.0.4"],"title":"Fixes
FIPS test skips in ML Disabled
suite","number":227677,"url":"https://github.com/elastic/kibana/pull/227677","mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227677","number":227677,"mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 15, 2025
@kibanamachine @jeramysoucy @nikitaindik
[8.18] Fixes FIPS test skips in ML Disabled suite (#227677) (#227985)
8729678 
# Backport

This will backport the following commits from `main` to `8.18`:
- [Fixes FIPS test skips in ML Disabled suite
(#227677)](#227677)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T11:30:05Z","message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","release_note:skip","Feature:FIPS","ci:enable-fips-agent","backport:version","v9.1.0","v8.19.0","v9.2.0","v8.18.4","v9.0.4"],"title":"Fixes
FIPS test skips in ML Disabled
suite","number":227677,"url":"https://github.com/elastic/kibana/pull/227677","mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227677","number":227677,"mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 16, 2025
@kibanamachine @jeramysoucy @nikitaindik
[8.19] Fixes FIPS test skips in ML Disabled suite (#227677) (#227986)
697262a 
# Backport

This will backport the following commits from `main` to `8.19`:
- [Fixes FIPS test skips in ML Disabled suite
(#227677)](#227677)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T11:30:05Z","message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Security","release_note:skip","Feature:FIPS","ci:enable-fips-agent","backport:version","v9.1.0","v8.19.0","v9.2.0","v8.18.4","v9.0.4"],"title":"Fixes
FIPS test skips in ML Disabled
suite","number":227677,"url":"https://github.com/elastic/kibana/pull/227677","mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227677","number":227677,"mergeCommit":{"message":"Fixes
FIPS test skips in ML Disabled suite (#227677)\n\n## Summary\n\nRemoves
basic check condition because FIPS always overrides to trial.\n\n\n###
Follow-up\n\nWe should audit for anywhere the license level is being
checked for a\nFIPS skip.\ncc @kc13greiner
@SiddharthMantri\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by:
Nikita Indik
<nikita.indik@elastic.co>","sha":"17baca37558094aef9c7409ee29d2c1e00f6edd8"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
@jeramysoucy @kibanamachine
@nikitaindik @Bluefinger
Fixes FIPS test skips in ML Disabled suite (elastic#227677)
3031d98 
## Summary

Removes basic check condition because FIPS always overrides to trial.


### Follow-up

We should audit for anywhere the license level is being checked for a
FIPS skip.
cc @kc13greiner @SiddharthMantri

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@jeramysoucy @kibanamachine
@nikitaindik @kertal
Fixes FIPS test skips in ML Disabled suite (elastic#227677)
22bfdfe 
## Summary

Removes basic check condition because FIPS always overrides to trial.


### Follow-up

We should audit for anywhere the license level is being checked for a
FIPS skip.
cc @kc13greiner @SiddharthMantri

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitaindik nikitaindik nikitaindik approved these changes

+1 more reviewer

@jkelas jkelas jkelas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeramysoucy jeramysoucy

Labels

backport:version Backport to applied version labels Feature:FIPS FIPS mode for Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// test v8.18.4 v8.19.0 v9.0.4 v9.1.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeramysoucy @elasticmachine @nikitaindik @kibanamachine @kc13greiner @jkelas