Polish MultiSelectFilter appearance in Rules page#227676
Merged
albertoblaz merged 1 commit intoelastic:mainfrom Jul 14, 2025
Merged
Polish MultiSelectFilter appearance in Rules page#227676albertoblaz merged 1 commit intoelastic:mainfrom
albertoblaz merged 1 commit intoelastic:mainfrom
Conversation
albertoblaz
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
maxcold
approved these changes
Jul 11, 2025
albertoblaz
force-pushed
the
polish-multi-select-filter
branch
from
d8b3d4e to
371b002
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @albertoblaz |
Contributor
|
Starting backport for target branches: 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16267028594 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2025
## Summary Polish inner border in `<MultiSelectFilter>` component, rendered upon clicking on `<RulesTableHeader>` in the Rule page. [Link to EuiSelectable docs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics). ### Screenshots <details><summary>Before</summary> <img width="525" height="375" alt="Screenshot 2025-07-11 at 16 44 06" src="https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50" /> <img width="502" height="363" alt="Screenshot 2025-07-11 at 16 44 17" src="https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109" /> </details> <details><summary>After</summary> <img width="515" height="338" alt="Screenshot 2025-07-11 at 16 43 25" src="https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e" /> <img width="491" height="345" alt="Screenshot 2025-07-11 at 16 43 34" src="https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01" /> </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Only risk is we're keeping style overrides in EUI components, which should happen as little as possible. But the override enhances the appearance when putting these components together, which is an edge case. (cherry picked from commit f9424c7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2025
## Summary Polish inner border in `<MultiSelectFilter>` component, rendered upon clicking on `<RulesTableHeader>` in the Rule page. [Link to EuiSelectable docs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics). ### Screenshots <details><summary>Before</summary> <img width="525" height="375" alt="Screenshot 2025-07-11 at 16 44 06" src="https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50" /> <img width="502" height="363" alt="Screenshot 2025-07-11 at 16 44 17" src="https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109" /> </details> <details><summary>After</summary> <img width="515" height="338" alt="Screenshot 2025-07-11 at 16 43 25" src="https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e" /> <img width="491" height="345" alt="Screenshot 2025-07-11 at 16 43 34" src="https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01" /> </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Only risk is we're keeping style overrides in EUI components, which should happen as little as possible. But the override enhances the appearance when putting these components together, which is an edge case. (cherry picked from commit f9424c7)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2025
…27815) # Backport This will backport the following commits from `main` to `9.0`: - [Polish MultiSelectFilter appearance in Rules page (#227676)](#227676) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-14T12:36:34Z","message":"Polish MultiSelectFilter appearance in Rules page (#227676)\n\n## Summary\n\nPolish inner border in `<MultiSelectFilter>` component, rendered upon\nclicking on `<RulesTableHeader>` in the Rule page.\n\n[Link to EuiSelectable\ndocs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics).\n\n### Screenshots\n\n<details><summary>Before</summary>\n<img width=\"525\" height=\"375\" alt=\"Screenshot 2025-07-11 at 16 44 06\"\nsrc=\"https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50\"\n/>\n<img width=\"502\" height=\"363\" alt=\"Screenshot 2025-07-11 at 16 44 17\"\nsrc=\"https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109\"\n/>\n</details> \n\n<details><summary>After</summary>\n<img width=\"515\" height=\"338\" alt=\"Screenshot 2025-07-11 at 16 43 25\"\nsrc=\"https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e\"\n/>\n<img width=\"491\" height=\"345\" alt=\"Screenshot 2025-07-11 at 16 43 34\"\nsrc=\"https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01\"\n/>\n</details> \n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nOnly risk is we're keeping style overrides in EUI components, which\nshould happen as little as possible. But the override enhances the\nappearance when putting these components together, which is an edge\ncase.","sha":"f9424c700cbc34c2b6d7885cc6863841c0af3c86","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","ci:cloud-deploy","backport:version","v9.1.0","v9.2.0"],"title":"Polish MultiSelectFilter appearance in Rules page","number":227676,"url":"https://github.com/elastic/kibana/pull/227676","mergeCommit":{"message":"Polish MultiSelectFilter appearance in Rules page (#227676)\n\n## Summary\n\nPolish inner border in `<MultiSelectFilter>` component, rendered upon\nclicking on `<RulesTableHeader>` in the Rule page.\n\n[Link to EuiSelectable\ndocs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics).\n\n### Screenshots\n\n<details><summary>Before</summary>\n<img width=\"525\" height=\"375\" alt=\"Screenshot 2025-07-11 at 16 44 06\"\nsrc=\"https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50\"\n/>\n<img width=\"502\" height=\"363\" alt=\"Screenshot 2025-07-11 at 16 44 17\"\nsrc=\"https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109\"\n/>\n</details> \n\n<details><summary>After</summary>\n<img width=\"515\" height=\"338\" alt=\"Screenshot 2025-07-11 at 16 43 25\"\nsrc=\"https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e\"\n/>\n<img width=\"491\" height=\"345\" alt=\"Screenshot 2025-07-11 at 16 43 34\"\nsrc=\"https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01\"\n/>\n</details> \n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nOnly risk is we're keeping style overrides in EUI components, which\nshould happen as little as possible. But the override enhances the\nappearance when putting these components together, which is an edge\ncase.","sha":"f9424c700cbc34c2b6d7885cc6863841c0af3c86"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227676","number":227676,"mergeCommit":{"message":"Polish MultiSelectFilter appearance in Rules page (#227676)\n\n## Summary\n\nPolish inner border in `<MultiSelectFilter>` component, rendered upon\nclicking on `<RulesTableHeader>` in the Rule page.\n\n[Link to EuiSelectable\ndocs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics).\n\n### Screenshots\n\n<details><summary>Before</summary>\n<img width=\"525\" height=\"375\" alt=\"Screenshot 2025-07-11 at 16 44 06\"\nsrc=\"https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50\"\n/>\n<img width=\"502\" height=\"363\" alt=\"Screenshot 2025-07-11 at 16 44 17\"\nsrc=\"https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109\"\n/>\n</details> \n\n<details><summary>After</summary>\n<img width=\"515\" height=\"338\" alt=\"Screenshot 2025-07-11 at 16 43 25\"\nsrc=\"https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e\"\n/>\n<img width=\"491\" height=\"345\" alt=\"Screenshot 2025-07-11 at 16 43 34\"\nsrc=\"https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01\"\n/>\n</details> \n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nOnly risk is we're keeping style overrides in EUI components, which\nshould happen as little as possible. But the override enhances the\nappearance when putting these components together, which is an edge\ncase.","sha":"f9424c700cbc34c2b6d7885cc6863841c0af3c86"}}]}] BACKPORT--> Co-authored-by: Alberto Blázquez <albertoblaz@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2025
…27816) # Backport This will backport the following commits from `main` to `9.1`: - [Polish MultiSelectFilter appearance in Rules page (#227676)](#227676) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"albertoblaz@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-14T12:36:34Z","message":"Polish MultiSelectFilter appearance in Rules page (#227676)\n\n## Summary\n\nPolish inner border in `<MultiSelectFilter>` component, rendered upon\nclicking on `<RulesTableHeader>` in the Rule page.\n\n[Link to EuiSelectable\ndocs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics).\n\n### Screenshots\n\n<details><summary>Before</summary>\n<img width=\"525\" height=\"375\" alt=\"Screenshot 2025-07-11 at 16 44 06\"\nsrc=\"https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50\"\n/>\n<img width=\"502\" height=\"363\" alt=\"Screenshot 2025-07-11 at 16 44 17\"\nsrc=\"https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109\"\n/>\n</details> \n\n<details><summary>After</summary>\n<img width=\"515\" height=\"338\" alt=\"Screenshot 2025-07-11 at 16 43 25\"\nsrc=\"https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e\"\n/>\n<img width=\"491\" height=\"345\" alt=\"Screenshot 2025-07-11 at 16 43 34\"\nsrc=\"https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01\"\n/>\n</details> \n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nOnly risk is we're keeping style overrides in EUI components, which\nshould happen as little as possible. But the override enhances the\nappearance when putting these components together, which is an edge\ncase.","sha":"f9424c700cbc34c2b6d7885cc6863841c0af3c86","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","ci:cloud-deploy","backport:version","v9.1.0","v9.2.0"],"title":"Polish MultiSelectFilter appearance in Rules page","number":227676,"url":"https://github.com/elastic/kibana/pull/227676","mergeCommit":{"message":"Polish MultiSelectFilter appearance in Rules page (#227676)\n\n## Summary\n\nPolish inner border in `<MultiSelectFilter>` component, rendered upon\nclicking on `<RulesTableHeader>` in the Rule page.\n\n[Link to EuiSelectable\ndocs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics).\n\n### Screenshots\n\n<details><summary>Before</summary>\n<img width=\"525\" height=\"375\" alt=\"Screenshot 2025-07-11 at 16 44 06\"\nsrc=\"https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50\"\n/>\n<img width=\"502\" height=\"363\" alt=\"Screenshot 2025-07-11 at 16 44 17\"\nsrc=\"https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109\"\n/>\n</details> \n\n<details><summary>After</summary>\n<img width=\"515\" height=\"338\" alt=\"Screenshot 2025-07-11 at 16 43 25\"\nsrc=\"https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e\"\n/>\n<img width=\"491\" height=\"345\" alt=\"Screenshot 2025-07-11 at 16 43 34\"\nsrc=\"https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01\"\n/>\n</details> \n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nOnly risk is we're keeping style overrides in EUI components, which\nshould happen as little as possible. But the override enhances the\nappearance when putting these components together, which is an edge\ncase.","sha":"f9424c700cbc34c2b6d7885cc6863841c0af3c86"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227676","number":227676,"mergeCommit":{"message":"Polish MultiSelectFilter appearance in Rules page (#227676)\n\n## Summary\n\nPolish inner border in `<MultiSelectFilter>` component, rendered upon\nclicking on `<RulesTableHeader>` in the Rule page.\n\n[Link to EuiSelectable\ndocs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics).\n\n### Screenshots\n\n<details><summary>Before</summary>\n<img width=\"525\" height=\"375\" alt=\"Screenshot 2025-07-11 at 16 44 06\"\nsrc=\"https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50\"\n/>\n<img width=\"502\" height=\"363\" alt=\"Screenshot 2025-07-11 at 16 44 17\"\nsrc=\"https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109\"\n/>\n</details> \n\n<details><summary>After</summary>\n<img width=\"515\" height=\"338\" alt=\"Screenshot 2025-07-11 at 16 43 25\"\nsrc=\"https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e\"\n/>\n<img width=\"491\" height=\"345\" alt=\"Screenshot 2025-07-11 at 16 43 34\"\nsrc=\"https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01\"\n/>\n</details> \n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nOnly risk is we're keeping style overrides in EUI components, which\nshould happen as little as possible. But the override enhances the\nappearance when putting these components together, which is an edge\ncase.","sha":"f9424c700cbc34c2b6d7885cc6863841c0af3c86"}}]}] BACKPORT--> Co-authored-by: Alberto Blázquez <albertoblaz@users.noreply.github.com>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary Polish inner border in `<MultiSelectFilter>` component, rendered upon clicking on `<RulesTableHeader>` in the Rule page. [Link to EuiSelectable docs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics). ### Screenshots <details><summary>Before</summary> <img width="525" height="375" alt="Screenshot 2025-07-11 at 16 44 06" src="https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50" /> <img width="502" height="363" alt="Screenshot 2025-07-11 at 16 44 17" src="https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109" /> </details> <details><summary>After</summary> <img width="515" height="338" alt="Screenshot 2025-07-11 at 16 43 25" src="https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e" /> <img width="491" height="345" alt="Screenshot 2025-07-11 at 16 43 34" src="https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01" /> </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Only risk is we're keeping style overrides in EUI components, which should happen as little as possible. But the override enhances the appearance when putting these components together, which is an edge case.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Polish inner border in `<MultiSelectFilter>` component, rendered upon clicking on `<RulesTableHeader>` in the Rule page. [Link to EuiSelectable docs](https://eui.elastic.co/docs/components/forms/selection/selectable/#the-basics). ### Screenshots <details><summary>Before</summary> <img width="525" height="375" alt="Screenshot 2025-07-11 at 16 44 06" src="https://github.com/user-attachments/assets/f100ce36-0450-476c-ba40-d7b4c34f5b50" /> <img width="502" height="363" alt="Screenshot 2025-07-11 at 16 44 17" src="https://github.com/user-attachments/assets/7760c929-bf9c-4986-81ec-06f9604de109" /> </details> <details><summary>After</summary> <img width="515" height="338" alt="Screenshot 2025-07-11 at 16 43 25" src="https://github.com/user-attachments/assets/b8a2e524-57cf-4bb6-a0f5-a47bfd17fd8e" /> <img width="491" height="345" alt="Screenshot 2025-07-11 at 16 43 34" src="https://github.com/user-attachments/assets/26fc1bbf-f1a7-440c-a050-2f7f6ee59d01" /> </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Only risk is we're keeping style overrides in EUI components, which should happen as little as possible. But the override enhances the appearance when putting these components together, which is an edge case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polish inner border in
<MultiSelectFilter>component, rendered upon clicking on<RulesTableHeader>in the Rule page.Link to EuiSelectable docs.
Screenshots
Before
After
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Only risk is we're keeping style overrides in EUI components, which should happen as little as possible. But the override enhances the appearance when putting these components together, which is an edge case.