Fix a bunch of dashboard flaky test issues when network speed is slow#22766
Closed
stacey-gammon wants to merge 2 commits intoelastic:masterfrom
Closed
Fix a bunch of dashboard flaky test issues when network speed is slow#22766stacey-gammon wants to merge 2 commits intoelastic:masterfrom
stacey-gammon wants to merge 2 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
Author
|
retest |
Contributor
💔 Build Failed |
Author
|
Gradle error jenkins, test this |
Contributor
💚 Build Succeeded |
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-09-06-save-confirm
branch
from
fa2dca7 to
bb30258
Compare
Contributor
💚 Build Succeeded |
stacey-gammon
changed the title
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Author
|
The slightly added delay on clicking seems to have triggered one of the other flaky bugs, but turns out that is a legit issue: #22233 |
Contributor
💔 Build Failed |
Author
Contributor
💔 Build Failed |
stacey-gammon
force-pushed
the
2018-09-06-save-confirm
branch
from
4e4e675 to
b3465cc
Compare
Contributor
💔 Build Failed |
Generalize the fix and include some other flakiness encountered with slow network connection dont wrap in a retry or stale element checks will get caught dont click disabled go button Skip test hitting legit input control bug
stacey-gammon
force-pushed
the
2018-09-06-save-confirm
branch
from
b3465cc to
28a2a5e
Compare
Contributor
💔 Build Failed |
liza-mae
added
failed-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discover the "slow 3g" option in Chrome, I was able to reproduce many flaky dashboard issues.
clickNewDashboardchecked for anadd dashboardbutton, if it didn't exist, it tried until failure to find the button on the prompt. Problem is sometimes it was slow to render the page, so dashboards existed, and theadd dashboardbutton just didn't render yet. But once it failed to find it, it assumed there were no dashboards and only waited to find the "add your first dashboard" prompt button.similarly,
gotoDashboardLandingPagefirst checked for the existence of an item to determine where it was, but if that came back incorrectly (because the page was slow to load), it would fail. Wrapping both checks in a retry should fix this.The second
click savebutton happened too quickly, this waits for the button to be enabled before clicking. Clicking the button when disabled doesn't throw an error. Rather than fix for this specific test, I pushed the check for a disabled button into the find service so any other clicks on an element will wait for the button to be enabled, or will throw an error as unsuccessful.Added in a check to wait for the EuiTableLoading indicator to be removed after searching for a dashboard on the listing page. If it's in the process of loading, some clicks can miss their elements.
Fixes #22409 ... probably many more! 🎉