Skip to content

x-pack tests should use servers from other config files already loaded#22739

Merged
LeeDr merged 2 commits intoelastic:masterfrom
LeeDr:fixXpackCloud
Sep 6, 2018
Merged

x-pack tests should use servers from other config files already loaded#22739
LeeDr merged 2 commits intoelastic:masterfrom
LeeDr:fixXpackCloud

Conversation

@LeeDr
Copy link
Copy Markdown

@LeeDr LeeDr commented Sep 5, 2018

This PR fixes the ability to use the combined environment variables TEST_ES_URL and TEST_KIBANA_URL for x-pack tests.

For example (from x-pack directory);

TEST_ES_URL=https://superuser:changeme@78cfe1f850064a5d9556fdfde8033078.us-central1.gcp.foundit.no:9243 TEST_KIBANA_URL=https://superuser:changeme@494f3c4adfc541d99dac1488df3271f5.us-central1.gcp.foundit.no:9243 node ../scripts/functional_test_runner.js --debug

You can also still use the individual environment variables as described in https://www.elastic.co/guide/en/kibana/current/development-functional-tests.html#_running_functional_tests

@LeeDr LeeDr added the test label Sep 5, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeDr LeeDr merged commit eeee0d8 into elastic:master Sep 6, 2018
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Sep 6, 2018
elastic#22739)

* x-pack tests should use servers from other config files already loaded

* Fix es_test_config that was using TEST_KIBANA_USERNAME/PASSWORD
LeeDr pushed a commit that referenced this pull request Sep 6, 2018
#22739) (#22762)

* x-pack tests should use servers from other config files already loaded

* Fix es_test_config that was using TEST_KIBANA_USERNAME/PASSWORD
LeeDr pushed a commit that referenced this pull request Sep 12, 2018
… loaded (#22739) (#22764)

* merge to 6.4

* resolve merge issue

I'm not 100% sure on `--server.uuid`.  This is different from master and 6.x where we have 
'--server.uuid=5b2de169-2785-441b-ae8c-186a1936b17d',

* Add env object back in.

* Move env from es_test_config to x-pack/test/functional/config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants