Skip to content

Comments

[9.1] [Discover] Return namespaces from update (#212574) (#226569)#227369

Merged
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-226569
Jul 10, 2025
Merged

[9.1] [Discover] Return namespaces from update (#212574) (#226569)#227369
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-226569

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…6569)

## Summary

Closes elastic#212574

Right now the update response doesn't return namespaces. The typing of
the query assumes it's always going to be there so we have to return it
when we update the query.

Server response
--
| Before | After |
|--------|------|
|
![image](https://github.com/user-attachments/assets/c089c7fb-acc9-412f-9553-aff759e81df2)
|
![image](https://github.com/user-attachments/assets/73a231ba-1390-4527-9dbe-5c117d4e6e84)
|

---

Before

https://github.com/user-attachments/assets/8fd760c1-733d-42ac-9bf8-2bb9259aa23d

After

https://github.com/user-attachments/assets/e38586c8-78db-4093-ae8b-0f7310665308

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

(cherry picked from commit c71d562)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jul 10, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) July 10, 2025 08:27
@kibanamachine kibanamachine merged commit e4b22b7 into elastic:9.1 Jul 10, 2025
16 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #79 / Journey[infra_hosts_view] "before all" hook for "Navigate to Hosts view and load 500 hosts"
  • [job] [logs] FTR Configs #7 / Spaces app Spaces app Spaces Management: Create and Edit edit space allows changing space avatar

Metrics [docs]

✅ unchanged

cc @AlexGPlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants