[Appearance Menu] Add new contrast setting#227339
Merged
Dosant merged 12 commits intoelastic:mainfrom Jul 11, 2025
Merged
Conversation
tsullivan
added
release_note:feature
Bamieh
approved these changes
Jul 9, 2025
Contributor
Bamieh
left a comment
Bamieh
left a comment
There was a problem hiding this comment.
Changes and code refactor LGTM
tsullivan
added
ci:project-deploy-elasticsearch
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
SiddharthMantri
approved these changes
Jul 10, 2025
tsullivan
removed
ci:project-deploy-elasticsearch
Contributor
⏳ Build in-progress
History
|
Dosant
approved these changes
Jul 11, 2025
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
tested by deploying custom image 👍
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16217689255 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2025
Closes elastic#227309 ## Summary  This adds support for contrast mode alongside in the "Appearance Modal" alongside the existing color mode setting. * Added support for contrast mode in the `AppearanceModal` component, including a new `ContrastModeGroup` and updated logic to handle both color mode and contrast mode changes. * Resolved a TODO and updated the `useAppearance` hook to manage contrast mode alongside color mode ## How to test ### Cloud * Add the following to your `kibana.dev.yml` ```yml xpack.cloud.id: "ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM=" ``` * Make the following change on L29 of the `maybe_add_cloud_links.ts` file ```diff --- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts +++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts @@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud }: MaybeAddCloudLinks const userObservable = defer(() => security.authc.getCurrentUser()).pipe( // Check if user is a cloud user. map((user) => user.elastic_cloud_user), + map(() => true), // If user is not defined due to an unexpected error, then fail *open*. catchError(() => of(true)), filter((isElasticCloudUser) => isElasticCloudUser === true), ``` * You should now see the "Appearance" link in the user menu ## Release Note Added support for high-contrast mode through the "Appearance modal" accessible from the User Profile icon at the top of the screen. ## Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) ~~- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ~~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ ~~- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ ~~- [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit f368fad)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2025
Closes elastic#227309 ## Summary  This adds support for contrast mode alongside in the "Appearance Modal" alongside the existing color mode setting. * Added support for contrast mode in the `AppearanceModal` component, including a new `ContrastModeGroup` and updated logic to handle both color mode and contrast mode changes. * Resolved a TODO and updated the `useAppearance` hook to manage contrast mode alongside color mode ## How to test ### Cloud * Add the following to your `kibana.dev.yml` ```yml xpack.cloud.id: "ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM=" ``` * Make the following change on L29 of the `maybe_add_cloud_links.ts` file ```diff --- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts +++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts @@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud }: MaybeAddCloudLinks const userObservable = defer(() => security.authc.getCurrentUser()).pipe( // Check if user is a cloud user. map((user) => user.elastic_cloud_user), + map(() => true), // If user is not defined due to an unexpected error, then fail *open*. catchError(() => of(true)), filter((isElasticCloudUser) => isElasticCloudUser === true), ``` * You should now see the "Appearance" link in the user menu ## Release Note Added support for high-contrast mode through the "Appearance modal" accessible from the User Profile icon at the top of the screen. ## Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) ~~- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ~~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ ~~- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ ~~- [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit f368fad)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 11, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Appearance Menu] Add new contrast setting (#227339)](#227339) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-11T10:19:45Z","message":"[Appearance Menu] Add new contrast setting (#227339)\n\nCloses https://github.com/elastic/kibana/issues/227309\n\n## Summary\n\n\n\n\nThis adds support for contrast mode alongside in the \"Appearance Modal\"\nalongside the existing color mode setting.\n\n* Added support for contrast mode in the `AppearanceModal` component,\nincluding a new `ContrastModeGroup` and updated logic to handle both\ncolor mode and contrast mode changes.\n* Resolved a TODO and updated the `useAppearance` hook to manage\ncontrast mode alongside color mode\n\n\n## How to test\n\n### Cloud\n* Add the following to your `kibana.dev.yml`\n\n```yml\nxpack.cloud.id: \"ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM=\"\n```\n\n* Make the following change on L29 of the `maybe_add_cloud_links.ts`\nfile\n\n```diff\n--- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts\n+++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts\n@@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud }: MaybeAddCloudLinks\n const userObservable = defer(() => security.authc.getCurrentUser()).pipe(\n // Check if user is a cloud user.\n map((user) => user.elastic_cloud_user),\n+ map(() => true),\n // If user is not defined due to an unexpected error, then fail *open*.\n catchError(() => of(true)),\n filter((isElasticCloudUser) => isElasticCloudUser === true),\n```\n\n* You should now see the \"Appearance\" link in the user menu\n\n## Release Note\n\nAdded support for high-contrast mode through the \"Appearance modal\"\naccessible from the User Profile icon at the top of the screen.\n\n## Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n~~- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n~~- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n~~- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n~~- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [X] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"f368fadd075788d34619f5daea3215034f7c0352","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","ci:cloud-deploy","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Appearance Menu] Add new contrast setting","number":227339,"url":"https://github.com/elastic/kibana/pull/227339","mergeCommit":{"message":"[Appearance Menu] Add new contrast setting (#227339)\n\nCloses https://github.com/elastic/kibana/issues/227309\n\n## Summary\n\n\n\n\nThis adds support for contrast mode alongside in the \"Appearance Modal\"\nalongside the existing color mode setting.\n\n* Added support for contrast mode in the `AppearanceModal` component,\nincluding a new `ContrastModeGroup` and updated logic to handle both\ncolor mode and contrast mode changes.\n* Resolved a TODO and updated the `useAppearance` hook to manage\ncontrast mode alongside color mode\n\n\n## How to test\n\n### Cloud\n* Add the following to your `kibana.dev.yml`\n\n```yml\nxpack.cloud.id: \"ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM=\"\n```\n\n* Make the following change on L29 of the `maybe_add_cloud_links.ts`\nfile\n\n```diff\n--- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts\n+++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts\n@@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud }: MaybeAddCloudLinks\n const userObservable = defer(() => security.authc.getCurrentUser()).pipe(\n // Check if user is a cloud user.\n map((user) => user.elastic_cloud_user),\n+ map(() => true),\n // If user is not defined due to an unexpected error, then fail *open*.\n catchError(() => of(true)),\n filter((isElasticCloudUser) => isElasticCloudUser === true),\n```\n\n* You should now see the \"Appearance\" link in the user menu\n\n## Release Note\n\nAdded support for high-contrast mode through the \"Appearance modal\"\naccessible from the User Profile icon at the top of the screen.\n\n## Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n~~- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n~~- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n~~- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n~~- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [X] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"f368fadd075788d34619f5daea3215034f7c0352"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227339","number":227339,"mergeCommit":{"message":"[Appearance Menu] Add new contrast setting (#227339)\n\nCloses https://github.com/elastic/kibana/issues/227309\n\n## Summary\n\n\n\n\nThis adds support for contrast mode alongside in the \"Appearance Modal\"\nalongside the existing color mode setting.\n\n* Added support for contrast mode in the `AppearanceModal` component,\nincluding a new `ContrastModeGroup` and updated logic to handle both\ncolor mode and contrast mode changes.\n* Resolved a TODO and updated the `useAppearance` hook to manage\ncontrast mode alongside color mode\n\n\n## How to test\n\n### Cloud\n* Add the following to your `kibana.dev.yml`\n\n```yml\nxpack.cloud.id: \"ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM=\"\n```\n\n* Make the following change on L29 of the `maybe_add_cloud_links.ts`\nfile\n\n```diff\n--- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts\n+++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts\n@@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud }: MaybeAddCloudLinks\n const userObservable = defer(() => security.authc.getCurrentUser()).pipe(\n // Check if user is a cloud user.\n map((user) => user.elastic_cloud_user),\n+ map(() => true),\n // If user is not defined due to an unexpected error, then fail *open*.\n catchError(() => of(true)),\n filter((isElasticCloudUser) => isElasticCloudUser === true),\n```\n\n* You should now see the \"Appearance\" link in the user menu\n\n## Release Note\n\nAdded support for high-contrast mode through the \"Appearance modal\"\naccessible from the User Profile icon at the top of the screen.\n\n## Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n~~- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials~~\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n~~- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~\n~~- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.~~\n~~- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed~~\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [X] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Anton Dosov <anton.dosov@elastic.co>","sha":"f368fadd075788d34619f5daea3215034f7c0352"}}]}] BACKPORT--> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
Closes elastic#227309 ## Summary  This adds support for contrast mode alongside in the "Appearance Modal" alongside the existing color mode setting. * Added support for contrast mode in the `AppearanceModal` component, including a new `ContrastModeGroup` and updated logic to handle both color mode and contrast mode changes. * Resolved a TODO and updated the `useAppearance` hook to manage contrast mode alongside color mode ## How to test ### Cloud * Add the following to your `kibana.dev.yml` ```yml xpack.cloud.id: "ftr_fake_cloud_id:aGVsbG8uY29tOjQ0MyRFUzEyM2FiYyRrYm4xMjNhYmM=" ``` * Make the following change on L29 of the `maybe_add_cloud_links.ts` file ```diff --- a/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts +++ b/x-pack/plugins/cloud_integrations/cloud_links/public/maybe_add_cloud_links/maybe_add_cloud_links.ts @@ -26,6 +26,7 @@ export function maybeAddCloudLinks({ core, security, cloud }: MaybeAddCloudLinks const userObservable = defer(() => security.authc.getCurrentUser()).pipe( // Check if user is a cloud user. map((user) => user.elastic_cloud_user), + map(() => true), // If user is not defined due to an unexpected error, then fail *open*. catchError(() => of(true)), filter((isElasticCloudUser) => isElasticCloudUser === true), ``` * You should now see the "Appearance" link in the user menu ## Release Note Added support for high-contrast mode through the "Appearance modal" accessible from the User Profile icon at the top of the screen. ## Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) ~~- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ~~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ ~~- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ ~~- [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227309
Summary
This adds support for contrast mode alongside in the "Appearance Modal" alongside the existing color mode setting.
AppearanceModalcomponent, including a newContrastModeGroupand updated logic to handle both color mode and contrast mode changes.useAppearancehook to manage contrast mode alongside color modeHow to test
Cloud
kibana.dev.ymlmaybe_add_cloud_links.tsfileRelease Note
Added support for high-contrast mode through the "Appearance modal" accessible from the User Profile icon at the top of the screen.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
- [ ] Documentation was added for features that require explanation or tutorials- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.- [ ] Flaky Test Runner was used on any tests changedrelease_note:*label is applied per the guidelinesbackport:*labels.