[8.19] [Controls] Fix disabled range slider tooltip, clean up delete control button (#227295)#227315
Merged
kibanamachine merged 3 commits intoelastic:8.19from Jul 10, 2025
Merged
Conversation
… button (elastic#227295) ## Summary ### Fix tooltip for disabled range slider When selecting a non-numerical field, the range slider was disabled with this tooltip: <img width="400" alt="Screenshot 2025-07-09 at 11 04 46 AM" src="https://github.com/user-attachments/assets/45ac7d9a-9009-40ed-839d-e5f47a547f75" /> Looking at the error message code, this was not the intended behavior: ```ts /** This shouldn't ever happen - but, adding just in case as a fallback. */ return i18n.translate( 'controls.controlGroup.manageControl.dataSource.controlTypeErrorMessage.default', { defaultMessage: 'Select a compatible control type.', } ); ``` This PR fixes this logic so the correct message is displayed: <img width="320" alt="Screenshot 2025-07-09 at 11 04 14 AM" src="https://github.com/user-attachments/assets/ea37385c-fdab-48c9-8e52-538411895000" /> ### Move delete control button to flyout footer and add confirm dialog When editing a control, a Delete Control button would appear here in the flyout body, which is hard to spot if the screen height is small and the user has to scroll down: <img width="507" alt="Screenshot 2025-07-09 at 11 22 23 AM" src="https://github.com/user-attachments/assets/9f6cb214-41ca-4d6f-87cd-08240aaa73d3" /> Clicking this button would also just immediately delete the control, and failed to display this confirmation modal: <img width="587" alt="Screenshot 2025-07-09 at 11 21 36 AM" src="https://github.com/user-attachments/assets/60c73cd0-5336-483d-a655-b868fffde94e" /> This PR adds the confirmation modal when trying to delete a control from the edit flyout, and also moves the button to the flyout footer: <img width="543" alt="Screenshot 2025-07-09 at 11 21 22 AM" src="https://github.com/user-attachments/assets/5d3553c0-a42f-4cd1-ac4d-f2465e2a669a" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 092c22d)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
cc @Zacqary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation