Skip to content

Comments

Fix "How's the navigation working for you?" shown with each session#227199

Merged
Dosant merged 1 commit intoelastic:mainfrom
Dosant:d/2025-07-09-feedback-callout
Jul 10, 2025
Merged

Fix "How's the navigation working for you?" shown with each session#227199
Dosant merged 1 commit intoelastic:mainfrom
Dosant:d/2025-07-09-feedback-callout

Conversation

@Dosant
Copy link
Contributor

@Dosant Dosant commented Jul 9, 2025

Summary

fix #227157

@Dosant Dosant requested a review from a team as a code owner July 9, 2025 10:27
@Dosant Dosant changed the title fix feedback flag persistance Fix "How's the navigation working for you?" shown with each session Jul 9, 2025
@Dosant Dosant added release_note:fix Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:all-open Backport to all branches that could still receive a release labels Jul 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant enabled auto-merge (squash) July 9, 2025 10:29
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #74 / Journey[infra_hosts_view] "before all" hook for "Navigate to Hosts view and load 500 hosts"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
navigation 22.8KB 22.8KB +31.0B
serverless 23.6KB 23.6KB +32.0B
total +63.0B

Copy link
Contributor

@paulinashakirova paulinashakirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@Dosant Dosant merged commit adaac2e into elastic:main Jul 10, 2025
20 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16190029918

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 10, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.18
8.19
9.0
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 10, 2025
…ssion (#227199) (#227374)

# Backport

This will backport the following commits from `main` to `8.19`:
- [Fix "How's the navigation working for you?" shown with each session
(#227199)](#227199)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-10T08:26:01Z","message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.2.0"],"title":"Fix
\"How's the navigation working for you?\" shown with each
session","number":227199,"url":"https://github.com/elastic/kibana/pull/227199","mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227199","number":227199,"mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 10, 2025
…sion (#227199) (#227375)

# Backport

This will backport the following commits from `main` to `9.0`:
- [Fix "How's the navigation working for you?" shown with each session
(#227199)](#227199)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-10T08:26:01Z","message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.2.0"],"title":"Fix
\"How's the navigation working for you?\" shown with each
session","number":227199,"url":"https://github.com/elastic/kibana/pull/227199","mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227199","number":227199,"mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 10, 2025
…sion (#227199) (#227376)

# Backport

This will backport the following commits from `main` to `9.1`:
- [Fix "How's the navigation working for you?" shown with each session
(#227199)](#227199)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-10T08:26:01Z","message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.2.0"],"title":"Fix
\"How's the navigation working for you?\" shown with each
session","number":227199,"url":"https://github.com/elastic/kibana/pull/227199","mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227199","number":227199,"mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 10, 2025
…ssion (#227199) (#227373)

# Backport

This will backport the following commits from `main` to `8.18`:
- [Fix "How's the navigation working for you?" shown with each session
(#227199)](#227199)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-10T08:26:01Z","message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.2.0"],"title":"Fix
\"How's the navigation working for you?\" shown with each
session","number":227199,"url":"https://github.com/elastic/kibana/pull/227199","mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227199","number":227199,"mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
@kibanamachine kibanamachine added v8.18.4 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 10, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @Dosant

kibanamachine added a commit that referenced this pull request Jul 11, 2025
…ssion (#227199) (#227372)

# Backport

This will backport the following commits from `main` to `8.17`:
- [Fix "How's the navigation working for you?" shown with each session
(#227199)](#227199)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-10T08:26:01Z","message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v9.2.0"],"title":"Fix
\"How's the navigation working for you?\" shown with each
session","number":227199,"url":"https://github.com/elastic/kibana/pull/227199","mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227199","number":227199,"mergeCommit":{"message":"Fix
\"How's the navigation working for you?\" shown with each session
(#227199)\n\n## Summary\n\nfix
https://github.com/elastic/kibana/issues/227157","sha":"adaac2e07392a88f74f79239ae44aa79149308fc"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
@kibanamachine kibanamachine added v8.17.9 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 11, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release release_note:fix Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.17.9 v8.18.4 v8.19.0 v9.0.4 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"How's the navigation working for you?" popup is session local and annoying

4 participants