Merged
Conversation
timroes
added
bug
markov00
approved these changes
Sep 5, 2018
Contributor
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Code LGTM. Tested on iframe and no z-index fighting was there.
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this - flaky reporting test |
Contributor
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Sep 5, 2018
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Sep 5, 2018
timroes
added a commit
that referenced
this pull request
Sep 5, 2018
timroes
added a commit
that referenced
this pull request
Sep 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke in #20295 when removing Angular from visualize, two places were leftover to use
visualizestill in CSS. That actually reintroduced #16457 again on 6.4+.This PR now renames the last instances. Reviewers and QA, please validate, that the above issue is vanished again with that fix.
cc @cchaos