[9.1] [SecuritySolution] [Bug] Fix Manage data sources page index import (#226099)#226921
Merged
machadoum merged 1 commit intoelastic:9.1from Jul 8, 2025
Merged
Conversation
…lastic#226099) Fix the Manage Data Sources page index import by implementing the creation, updating, deletion, and retrieval of entity source configurations. It includes updates to the TypeScript definitions, API schema, and client-side API methods to support these operations. After this change, the user will be able to create only one data source using the UI. ### API and types changes * Added new types (`CreateMonitoringEntitySource`, `UpdatedMonitoringEntitySource`, `MonitoringEntitySource`) with expanded fields for entity source configurations, such as `indexPattern`, `enabled`, `error`, and `matchers`. [[1]](diffhunk://#diff-b8c44f34825a1f7fa2c3f70fdda00f38b07e19ef8600e1a2e937660346d95c72R18-R21) [[2]](diffhunk://#diff-b8c44f34825a1f7fa2c3f70fdda00f38b07e19ef8600e1a2e937660346d95c72L39-R64) [[3]](diffhunk://#diff-b8c44f34825a1f7fa2c3f70fdda00f38b07e19ef8600e1a2e937660346d95c72R76-R122) * Updated the API schema (`monitoring_entity_source.schema.yaml`) to reflect new entity source operations, including `CreateEntitySource`, `UpdateEntitySource`, `DeleteEntitySource`, `GetEntitySource`, and `ListEntitySources`. Added support for query parameters and refined response schema definitions. [[1]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1L10-R30) [[2]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1L42-R48) [[3]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1L58-R72) [[4]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1L78-R102) [[5]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1L88-R114) [[6]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1L128-R189) [[7]](diffhunk://#diff-e7f2de573ae15c6a3c3781b2a97b9875299c0674f81dd673d2bf9b3a6cf397f1R219-R220) * Add a uniqueness assertion for the data source name. * Create the data source 'PUT' API that allows updates * Force the `managed` to be consistently defined by default * Update list data sources API to support filter params ### UI changes * Extract `IndexImportManageDataSource` component to its file. * Stop calling the `init` API on updates * Implement the edit mode instead of creating a new data source on every save * Load the already added indices when editing * Fix the displayed added indices message to show the right value ### Video https://github.com/user-attachments/assets/9d1c1ad1-09b9-49f0-8cea-1b640a26e954 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 8453edc)
4 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
cc @machadoum |
abhishekbhatia1710
approved these changes
Jul 8, 2025
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation