Add instructions for running reporting functional tests to x-pack README#22683
Merged
nreese merged 5 commits intoelastic:masterfrom Sep 5, 2018
Merged
Conversation
3f8ff7c to
be645bc
Compare
chrisdavies
approved these changes
Sep 5, 2018
Contributor
chrisdavies
left a comment
There was a problem hiding this comment.
LGTM w/ possible tweak.
| ```sh | ||
| //OSX | ||
| brew install imagemagick ghostscript poppler | ||
| ``` |
Contributor
There was a problem hiding this comment.
Might want to add the Linux (Ubutnu) commands too:
sudo apt-get install imagemagick ghostscript poppler-utils
I don't see any instructions for Windows, so don't even know if x-pack tests will run there.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 5, 2018
…DME (elastic#22683) * add instructions * rest of instructions * pdf-image requirements * typo * add Ubutnu commands
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 5, 2018
…DME (elastic#22683) * add instructions * rest of instructions * pdf-image requirements * typo * add Ubutnu commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip ci]