Skip to content

Add instructions for running reporting functional tests to x-pack README#22683

Merged
nreese merged 5 commits intoelastic:masterfrom
nreese:reporting_functional_test_instructions
Sep 5, 2018
Merged

Add instructions for running reporting functional tests to x-pack README#22683
nreese merged 5 commits intoelastic:masterfrom
nreese:reporting_functional_test_instructions

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Sep 4, 2018

[skip ci]

@nreese nreese added :Sharing v7.0.0 v6.5.0 release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Sep 4, 2018
@nreese nreese requested a review from tsullivan September 4, 2018 19:27
@nreese nreese force-pushed the reporting_functional_test_instructions branch from 3f8ff7c to be645bc Compare September 4, 2018 19:34
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese requested a review from chrisdavies September 5, 2018 18:49
Copy link
Copy Markdown
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ possible tweak.

```sh
//OSX
brew install imagemagick ghostscript poppler
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add the Linux (Ubutnu) commands too:

sudo apt-get install imagemagick ghostscript poppler-utils

I don't see any instructions for Windows, so don't even know if x-pack tests will run there.

@nreese nreese merged commit 865a51d into elastic:master Sep 5, 2018
nreese added a commit to nreese/kibana that referenced this pull request Sep 5, 2018
…DME (elastic#22683)

* add instructions

* rest of instructions

* pdf-image requirements

* typo

* add Ubutnu commands
nreese added a commit to nreese/kibana that referenced this pull request Sep 5, 2018
…DME (elastic#22683)

* add instructions

* rest of instructions

* pdf-image requirements

* typo

* add Ubutnu commands
nreese added a commit that referenced this pull request Sep 5, 2018
…DME (#22683) (#22734)

* add instructions

* rest of instructions

* pdf-image requirements

* typo

* add Ubutnu commands
nreese added a commit that referenced this pull request Sep 5, 2018
…DME (#22683) (#22733)

* add instructions

* rest of instructions

* pdf-image requirements

* typo

* add Ubutnu commands
@timroes timroes added Team:Docs and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants