Skip to content

Capture browser logs on test failure #22670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stacey-gammon merged 5 commits into from
Sep 13, 2018
Merged

Capture browser logs on test failure #22670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
404708f
Capture browser logs
Sep 4, 2018
71b8677
spit out in logs, simulate failure to test
Sep 7, 2018
84f7f7f
remove leftover code
Sep 7, 2018
eaf7a11
simulate failure
Sep 7, 2018
518e294
Remove forced failure
Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/functional/apps/dashboard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default function ({ getService, loadTestFile, getPageObjects }) {
loadTestFile(require.resolve('./_dashboard_filter_bar'));

// TODO: unskip when https://github.com/elastic/kibana/issues/20442 is fixed
//loadTestFile(require.resolve('./_dashboard_filtering'));
// loadTestFile(require.resolve('./_dashboard_filtering'));

loadTestFile(require.resolve('./_panel_expand_toggle'));
loadTestFile(require.resolve('./_dashboard_grid'));
Expand Down
13 changes: 12 additions & 1 deletion test/functional/services/failure_debugging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,29 @@ export async function FailureDebuggingProvider({ getService }) {
await writeFileAsync(htmlOutputFileName, pageSource);
}

async function logBrowserConsole() {
const browserLogs = await remote.getLogsFor('browser');
const browserOutput = browserLogs.reduce((acc, log) => acc += `${log.message.replace(/\\n/g, '\n')}\n`, '');
log.info(`Browser output is: ${browserOutput}`);
}

async function onFailure(error, test) {
// Replace characters in test names which can't be used in filenames, like *
const name = test.fullTitle().replace(/([^ a-zA-Z0-9-]+)/g, '_');

await Promise.all([
screenshots.takeForFailure(name),
logCurrentUrl(),
savePageHtml(name)
savePageHtml(name),
logBrowserConsole(),
]);
}

lifecycle
.on('testFailure', onFailure)
.on('testHookFailure', onFailure);

return {
logBrowserConsole
};
}