Skip to content

[ML] Adds milliseconds to watch start and end times#22659

Merged
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:adding-millisecs-and-timezone-to-watch-start-and-end-times
Sep 4, 2018
Merged

[ML] Adds milliseconds to watch start and end times#22659
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:adding-millisecs-and-timezone-to-watch-start-and-end-times

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Sep 4, 2018

Timezone is needed for the ISO dates used in the ML watch.
Change based on comment in original PR.
#21998 (comment)

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.5.0 v6.4.1 labels Sep 4, 2018
@jgowdyelastic jgowdyelastic self-assigned this Sep 4, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 4, 2018

Pinging @elastic/ml-ui

walterra
walterra approved these changes Sep 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Sep 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 4, 2018

💔 Build Failed

@jgowdyelastic
Copy link
Copy Markdown
Member Author

jgowdyelastic commented Sep 4, 2018

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 4, 2018

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 85bee36 into elastic:master Sep 4, 2018
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 4, 2018
@jgowdyelastic
[ML] Adding milliseconds to watch start and end times (elastic#22659)
c986fa1
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 4, 2018
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Sep 4, 2018
@jgowdyelastic
[ML] Adding milliseconds to watch start and end times (elastic#22659)
3cd4704
@jgowdyelastic jgowdyelastic mentioned this pull request Sep 4, 2018
Merged
jgowdyelastic added a commit that referenced this pull request Sep 4, 2018
@jgowdyelastic
[ML] Adding milliseconds to watch start and end times (#22659) (#22673)
ffd7095
jgowdyelastic added a commit that referenced this pull request Sep 4, 2018
@jgowdyelastic
[ML] Adding milliseconds to watch start and end times (#22659) (#22674)
6034e5e
@peteharverson peteharverson changed the title [ML] Adding milliseconds to watch start and end times [ML] Adds milliseconds to watch start and end times Sep 13, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 13, 2018

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels

bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v6.4.1 v6.5.0 v7.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgowdyelastic @elasticmachine @walterra @peteharverson