Skip to content

Conversation

@jughosta
Copy link
Contributor

@jughosta jughosta commented Jul 4, 2025

Summary

Before:
Screenshot 2025-07-04 at 12 29 12

After:
Screenshot 2025-07-04 at 12 16 31

Testing

https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example

Other field types:
mapping.txt.zip

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@jughosta jughosta self-assigned this Jul 4, 2025
@jughosta jughosta added release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:all-open Backport to all branches that could still receive a release Feature:UnifiedDataTable labels Jul 4, 2025
@jughosta jughosta added backport:version Backport to applied version labels v9.2.0 v9.1.0 and removed backport:all-open Backport to all branches that could still receive a release labels Jul 4, 2025
@jughosta jughosta marked this pull request as ready for review July 4, 2025 13:53
@jughosta jughosta requested a review from a team as a code owner July 4, 2025 13:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 556.6KB 556.7KB +74.0B
discover 1.1MB 1.1MB +74.0B
esqlDataGrid 157.2KB 157.2KB +74.0B
securitySolution 9.8MB 9.8MB +74.0B
slo 988.6KB 988.7KB +74.0B
total +370.0B

History

cc @jughosta

Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM, thx!

@jughosta jughosta merged commit 06391b0 into elastic:main Jul 8, 2025
10 checks passed
@jughosta jughosta deleted the 210234-fix-json-in-number-column branch July 8, 2025 12:22
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16143087397

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2025
…ell value (elastic#226562)

- Closes elastic#210234

## Summary

Before:
<img width="414" alt="Screenshot 2025-07-04 at 12 29 12"
src="https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af"
/>

After:
<img width="424" alt="Screenshot 2025-07-04 at 12 16 31"
src="https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a"
/>

### Testing

https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example

Other field types:

[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

(cherry picked from commit 06391b0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 8, 2025
…ered cell value (#226562) (#227010)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Discover][UnifiedDataTable] Left align content inside the rendered
cell value (#226562)](#226562)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T12:22:21Z","message":"[Discover][UnifiedDataTable]
Left align content inside the rendered cell value (#226562)\n\n- Closes
https://github.com/elastic/kibana/issues/210234\n\n##
Summary\n\nBefore:\n<img width=\"414\" alt=\"Screenshot 2025-07-04 at 12
29
12\"\nsrc=\"https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af\"\n/>\n\nAfter:\n<img
width=\"424\" alt=\"Screenshot 2025-07-04 at 12 16
31\"\nsrc=\"https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a\"\n/>\n\n###
Testing\n\n\nhttps://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example\n\nOther
field types:
\n\n[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)\n\n###
Checklist\n\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*`
labels.","sha":"06391b033e05eccd78e94b3b4d3e72dfce3d5705","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","Feature:UnifiedDataTable","backport:version","v9.1.0","v9.2.0"],"title":"[Discover][UnifiedDataTable]
Left align content inside the rendered cell
value","number":226562,"url":"https://github.com/elastic/kibana/pull/226562","mergeCommit":{"message":"[Discover][UnifiedDataTable]
Left align content inside the rendered cell value (#226562)\n\n- Closes
https://github.com/elastic/kibana/issues/210234\n\n##
Summary\n\nBefore:\n<img width=\"414\" alt=\"Screenshot 2025-07-04 at 12
29
12\"\nsrc=\"https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af\"\n/>\n\nAfter:\n<img
width=\"424\" alt=\"Screenshot 2025-07-04 at 12 16
31\"\nsrc=\"https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a\"\n/>\n\n###
Testing\n\n\nhttps://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example\n\nOther
field types:
\n\n[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)\n\n###
Checklist\n\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*`
labels.","sha":"06391b033e05eccd78e94b3b4d3e72dfce3d5705"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226562","number":226562,"mergeCommit":{"message":"[Discover][UnifiedDataTable]
Left align content inside the rendered cell value (#226562)\n\n- Closes
https://github.com/elastic/kibana/issues/210234\n\n##
Summary\n\nBefore:\n<img width=\"414\" alt=\"Screenshot 2025-07-04 at 12
29
12\"\nsrc=\"https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af\"\n/>\n\nAfter:\n<img
width=\"424\" alt=\"Screenshot 2025-07-04 at 12 16
31\"\nsrc=\"https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a\"\n/>\n\n###
Testing\n\n\nhttps://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example\n\nOther
field types:
\n\n[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)\n\n###
Checklist\n\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*`
labels.","sha":"06391b033e05eccd78e94b3b4d3e72dfce3d5705"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…ell value (elastic#226562)

- Closes elastic#210234

## Summary

Before:
<img width="414" alt="Screenshot 2025-07-04 at 12 29 12"
src="https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af"
/>

After:
<img width="424" alt="Screenshot 2025-07-04 at 12 16 31"
src="https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a"
/>

### Testing


https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example

Other field types: 

[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)

### Checklist


- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
jughosta added a commit that referenced this pull request Jul 31, 2025
…ndered cell value" (#230095)

Reverts #226562 due to issues with
#229178 (comment)

Closes #229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 31, 2025
…ndered cell value" (elastic#230095)

Reverts elastic#226562 due to issues with
elastic#229178 (comment)

Closes elastic#229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>

(cherry picked from commit 217ea79)
kibanamachine added a commit that referenced this pull request Jul 31, 2025
…the rendered cell value" (#230095) (#230112)

# Backport

This will backport the following commits from `main` to `9.1`:
- [Revert "[Discover][UnifiedDataTable] Left align content inside the
rendered cell value"
(#230095)](#230095)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-31T17:27:40Z","message":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell value\" (#230095)\n\nReverts #226562 due to issues
with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses
https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img
width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49
27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img
width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49
56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.1.1"],"title":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell
value\"","number":230095,"url":"https://github.com/elastic/kibana/pull/230095","mergeCommit":{"message":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell value\" (#230095)\n\nReverts #226562 due to issues
with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses
https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img
width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49
27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img
width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49
56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230095","number":230095,"mergeCommit":{"message":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell value\" (#230095)\n\nReverts #226562 due to issues
with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses
https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img
width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49
27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img
width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49
56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
…ndered cell value" (elastic#230095)

Reverts elastic#226562 due to issues with
elastic#229178 (comment)

Closes elastic#229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
…ndered cell value" (elastic#230095)

Reverts elastic#226562 due to issues with
elastic#229178 (comment)

Closes elastic#229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:UnifiedDataTable release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discover] Aggregate metric field columns display oddly in Discover

5 participants