-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover][UnifiedDataTable] Left align content inside the rendered cell value #226562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][UnifiedDataTable] Left align content inside the rendered cell value #226562
Conversation
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @jughosta |
andreadelrio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
akowalska622
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise LGTM, thx!
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16143087397 |
…ell value (elastic#226562) - Closes elastic#210234 ## Summary Before: <img width="414" alt="Screenshot 2025-07-04 at 12 29 12" src="https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af" /> After: <img width="424" alt="Screenshot 2025-07-04 at 12 16 31" src="https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a" /> ### Testing https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example Other field types: [mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip) ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 06391b0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ered cell value (#226562) (#227010) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover][UnifiedDataTable] Left align content inside the rendered cell value (#226562)](#226562) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T12:22:21Z","message":"[Discover][UnifiedDataTable] Left align content inside the rendered cell value (#226562)\n\n- Closes https://github.com/elastic/kibana/issues/210234\n\n## Summary\n\nBefore:\n<img width=\"414\" alt=\"Screenshot 2025-07-04 at 12 29 12\"\nsrc=\"https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af\"\n/>\n\nAfter:\n<img width=\"424\" alt=\"Screenshot 2025-07-04 at 12 16 31\"\nsrc=\"https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a\"\n/>\n\n### Testing\n\n\nhttps://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example\n\nOther field types: \n\n[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"06391b033e05eccd78e94b3b4d3e72dfce3d5705","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","Feature:UnifiedDataTable","backport:version","v9.1.0","v9.2.0"],"title":"[Discover][UnifiedDataTable] Left align content inside the rendered cell value","number":226562,"url":"https://github.com/elastic/kibana/pull/226562","mergeCommit":{"message":"[Discover][UnifiedDataTable] Left align content inside the rendered cell value (#226562)\n\n- Closes https://github.com/elastic/kibana/issues/210234\n\n## Summary\n\nBefore:\n<img width=\"414\" alt=\"Screenshot 2025-07-04 at 12 29 12\"\nsrc=\"https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af\"\n/>\n\nAfter:\n<img width=\"424\" alt=\"Screenshot 2025-07-04 at 12 16 31\"\nsrc=\"https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a\"\n/>\n\n### Testing\n\n\nhttps://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example\n\nOther field types: \n\n[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"06391b033e05eccd78e94b3b4d3e72dfce3d5705"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226562","number":226562,"mergeCommit":{"message":"[Discover][UnifiedDataTable] Left align content inside the rendered cell value (#226562)\n\n- Closes https://github.com/elastic/kibana/issues/210234\n\n## Summary\n\nBefore:\n<img width=\"414\" alt=\"Screenshot 2025-07-04 at 12 29 12\"\nsrc=\"https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af\"\n/>\n\nAfter:\n<img width=\"424\" alt=\"Screenshot 2025-07-04 at 12 16 31\"\nsrc=\"https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a\"\n/>\n\n### Testing\n\n\nhttps://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example\n\nOther field types: \n\n[mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip)\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"06391b033e05eccd78e94b3b4d3e72dfce3d5705"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
…ell value (elastic#226562) - Closes elastic#210234 ## Summary Before: <img width="414" alt="Screenshot 2025-07-04 at 12 29 12" src="https://github.com/user-attachments/assets/6823582a-ae3d-4fdf-94f8-0cc4fb4128af" /> After: <img width="424" alt="Screenshot 2025-07-04 at 12 16 31" src="https://github.com/user-attachments/assets/29ff1995-b487-46fb-8145-5cd294246b0a" /> ### Testing https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example Other field types: [mapping.txt.zip](https://github.com/user-attachments/files/21059311/mapping.txt.zip) ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
…ndered cell value" (#230095) Reverts #226562 due to issues with #229178 (comment) Closes #229178 Before: <img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27" src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b" /> After: <img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56" src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1" />
…ndered cell value" (elastic#230095) Reverts elastic#226562 due to issues with elastic#229178 (comment) Closes elastic#229178 Before: <img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27" src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b" /> After: <img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56" src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1" /> (cherry picked from commit 217ea79)
…the rendered cell value" (#230095) (#230112) # Backport This will backport the following commits from `main` to `9.1`: - [Revert "[Discover][UnifiedDataTable] Left align content inside the rendered cell value" (#230095)](#230095) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-31T17:27:40Z","message":"Revert \"[Discover][UnifiedDataTable] Left align content inside the rendered cell value\" (#230095)\n\nReverts #226562 due to issues with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49 27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49 56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.1.1"],"title":"Revert \"[Discover][UnifiedDataTable] Left align content inside the rendered cell value\"","number":230095,"url":"https://github.com/elastic/kibana/pull/230095","mergeCommit":{"message":"Revert \"[Discover][UnifiedDataTable] Left align content inside the rendered cell value\" (#230095)\n\nReverts #226562 due to issues with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49 27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49 56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230095","number":230095,"mergeCommit":{"message":"Revert \"[Discover][UnifiedDataTable] Left align content inside the rendered cell value\" (#230095)\n\nReverts #226562 due to issues with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49 27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49 56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
…ndered cell value" (elastic#230095) Reverts elastic#226562 due to issues with elastic#229178 (comment) Closes elastic#229178 Before: <img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27" src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b" /> After: <img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56" src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1" />
…ndered cell value" (elastic#230095) Reverts elastic#226562 due to issues with elastic#229178 (comment) Closes elastic#229178 Before: <img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27" src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b" /> After: <img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56" src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1" />
Summary
Before:

After:

Testing
https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/aggregate-metric-double#aggregate-metric-double-example
Other field types:
mapping.txt.zip
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.