Skip to content

[SecuritySolution][Endpoint][ResponseActions] Internal route prefix#226494

Merged
tomsonpl merged 3 commits intoelastic:mainfrom
ashokaditya:task/edr-fix-internal-route-prefix-for-custom-scripts
Jul 11, 2025
Merged

[SecuritySolution][Endpoint][ResponseActions] Internal route prefix#226494
tomsonpl merged 3 commits intoelastic:mainfrom
ashokaditya:task/edr-fix-internal-route-prefix-for-custom-scripts

Conversation

@ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Jul 3, 2025

Summary

Follow up of #204965. Looks like the route was not prefixed as internal even though it's registered as internal. This PR fixes that.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@ashokaditya ashokaditya requested a review from a team as a code owner July 3, 2025 20:04
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v9.1.0 v8.19.0 labels Jul 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@ashokaditya ashokaditya added the backport:version Backport to applied version labels label Jul 3, 2025
@ashokaditya ashokaditya self-assigned this Jul 4, 2025
@tomsonpl tomsonpl enabled auto-merge (squash) July 11, 2025 08:22
@tomsonpl tomsonpl merged commit 5549d70 into elastic:main Jul 11, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16217730969

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / console app console autocomplete feature index fields autocomplete fields autocomplete only shows fields of the index

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +18.0B

History

cc @ashokaditya

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 11, 2025
…efix (#226494) (#227603)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[SecuritySolution][Endpoint][ResponseActions] Internal route prefix
(#226494)](#226494)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-11T10:21:57Z","message":"[SecuritySolution][Endpoint][ResponseActions]
Internal route prefix
(#226494)","sha":"5549d70cc9105824f86b323f222f8e52bb8b08e7","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","OLM
Sprint","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[SecuritySolution][Endpoint][ResponseActions]
Internal route
prefix","number":226494,"url":"https://github.com/elastic/kibana/pull/226494","mergeCommit":{"message":"[SecuritySolution][Endpoint][ResponseActions]
Internal route prefix
(#226494)","sha":"5549d70cc9105824f86b323f222f8e52bb8b08e7"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226494","number":226494,"mergeCommit":{"message":"[SecuritySolution][Endpoint][ResponseActions]
Internal route prefix
(#226494)","sha":"5549d70cc9105824f86b323f222f8e52bb8b08e7"}}]}]
BACKPORT-->

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 14, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @ashokaditya

kibanamachine added a commit that referenced this pull request Jul 14, 2025
…refix (#226494) (#227602)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[SecuritySolution][Endpoint][ResponseActions] Internal route prefix
(#226494)](#226494)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-11T10:21:57Z","message":"[SecuritySolution][Endpoint][ResponseActions]
Internal route prefix
(#226494)","sha":"5549d70cc9105824f86b323f222f8e52bb8b08e7","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","OLM
Sprint","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[SecuritySolution][Endpoint][ResponseActions]
Internal route
prefix","number":226494,"url":"https://github.com/elastic/kibana/pull/226494","mergeCommit":{"message":"[SecuritySolution][Endpoint][ResponseActions]
Internal route prefix
(#226494)","sha":"5549d70cc9105824f86b323f222f8e52bb8b08e7"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226494","number":226494,"mergeCommit":{"message":"[SecuritySolution][Endpoint][ResponseActions]
Internal route prefix
(#226494)","sha":"5549d70cc9105824f86b323f222f8e52bb8b08e7"}}]}]
BACKPORT-->

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 14, 2025
@ashokaditya ashokaditya deleted the task/edr-fix-internal-route-prefix-for-custom-scripts branch July 25, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants