Skip to content

Comments

[8.19] [SecuritySolution][Endpoint][ResponseActions] Response actions telemetry tests for third party agents (#225916)#226455

Merged
ashokaditya merged 3 commits intoelastic:8.19from
ashokaditya:backport/8.19/pr-225916
Jul 5, 2025
Merged

[8.19] [SecuritySolution][Endpoint][ResponseActions] Response actions telemetry tests for third party agents (#225916)#226455
ashokaditya merged 3 commits intoelastic:8.19from
ashokaditya:backport/8.19/pr-225916

Conversation

@ashokaditya
Copy link
Member

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…try tests for third party agents (elastic#225916)

This is a follow up of elastic#221518.

- [x] Adds missing tests for action creation and action response events
for third party agents.
- [x] Adds telemetry events for completed action responses for
crowdstrike agents.

**Note:** The action creation tests in each agent type is redundant as
the action creation telemetry event is sent from a method in the base
action client class, but tests are added here just to ensure that
telemetry events are not broken by any changes in the future for third
party agents.

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 11bb923)
@ashokaditya ashokaditya added the backport This PR is a backport of another PR label Jul 3, 2025
@ashokaditya ashokaditya enabled auto-merge (squash) July 3, 2025 15:41
@ashokaditya ashokaditya self-assigned this Jul 3, 2025
@ashokaditya ashokaditya disabled auto-merge July 3, 2025 19:56
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 3, 2025

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @ashokaditya

@ashokaditya ashokaditya enabled auto-merge (squash) July 4, 2025 08:44
@ashokaditya ashokaditya disabled auto-merge July 4, 2025 09:12
@ashokaditya ashokaditya merged commit 2ea78c7 into elastic:8.19 Jul 5, 2025
8 checks passed
@ashokaditya ashokaditya deleted the backport/8.19/pr-225916 branch July 5, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants