Skip to content

Comments

[APM] Fix span flyout in operation page#226423

Merged
kpatticha merged 7 commits intoelastic:mainfrom
kpatticha:152-span-badge-operation
Jul 9, 2025
Merged

[APM] Fix span flyout in operation page#226423
kpatticha merged 7 commits intoelastic:mainfrom
kpatticha:152-span-badge-operation

Conversation

@kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jul 3, 2025

Summary

closes https://github.com/elastic/observability-error-backlog/issues/152

  • Extend e2e test to ensure the Span link flyout opens and displays the correct span details.

Before

Screen.Recording.2025-07-03.at.4.33.50.PM.mov

After

Screen.Recording.2025-07-03.at.4.36.39.PM.mov

@kpatticha kpatticha requested a review from a team July 3, 2025 13:37
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jul 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🚀 Thanks for fixing that and adding a test!

@kpatticha kpatticha enabled auto-merge (squash) July 4, 2025 09:01
@kpatticha kpatticha merged commit c6ea08e into elastic:main Jul 9, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16176153746

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.5MB 2.6MB +52.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2025
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17
8.18
8.19
9.0
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 9, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[APM] Fix span flyout in operation page
(#226423)](#226423)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T17:30:28Z","message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix span flyout in operation
page","number":226423,"url":"https://github.com/elastic/kibana/pull/226423","mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226423","number":226423,"mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 9, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[APM] Fix span flyout in operation page
(#226423)](#226423)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T17:30:28Z","message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix span flyout in operation
page","number":226423,"url":"https://github.com/elastic/kibana/pull/226423","mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226423","number":226423,"mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 9, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [[APM] Fix span flyout in operation page
(#226423)](#226423)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T17:30:28Z","message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix span flyout in operation
page","number":226423,"url":"https://github.com/elastic/kibana/pull/226423","mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226423","number":226423,"mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 9, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [[APM] Fix span flyout in operation page
(#226423)](#226423)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T17:30:28Z","message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix span flyout in operation
page","number":226423,"url":"https://github.com/elastic/kibana/pull/226423","mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226423","number":226423,"mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 10, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @kpatticha

kibanamachine added a commit that referenced this pull request Jul 11, 2025
# Backport

This will backport the following commits from `main` to `8.17`:
- [[APM] Fix span flyout in operation page
(#226423)](#226423)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-09T17:30:28Z","message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix span flyout in operation
page","number":226423,"url":"https://github.com/elastic/kibana/pull/226423","mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226423","number":226423,"mergeCommit":{"message":"[APM]
Fix span flyout in operation page (#226423)\n\n## Summary\n\ncloses
https://github.com/elastic/observability-error-backlog/issues/152\n\n-
Extend e2e test to ensure the Span link flyout opens and displays
the\ncorrect span details.\n\n\n\n###
Before\n\n\n\nhttps://github.com/user-attachments/assets/5978453d-9c18-4c67-84e8-c6974c340051\n\n###
After\n\n\nhttps://github.com/user-attachments/assets/fdd18789-e068-43d8-8c81-8405b7722a3c","sha":"c6ea08eee502c894a0eb93bcbf27943c919a9bd4"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
@kibanamachine kibanamachine added v8.17.9 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants