[Security Solution][Entity Analytics][PrivMon] Handle null/undefined values gracefully for tiles on Privmon dashboard#226387
Merged
abhishekbhatia1710 merged 8 commits intoelastic:mainfrom Jul 11, 2025
Conversation
abhishekbhatia1710
added
release_note:skip
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
Closed
7 tasks
|
|
||
| const LENS_VISUALIZATION_HEIGHT = 126; | ||
| const LENS_VISUALIZATION_MIN_WIDTH = 160; | ||
| const LENS_VISUALIZATION_HEIGHT = 150; |
Contributor
There was a problem hiding this comment.
Can you describe what the effect of this change to the height/weight is?
Contributor
Author
There was a problem hiding this comment.
Yes, with the EUIGroup and EuiPanel coming into play, the space of EuiFlex became more and the tiles occupied 4 columns and 2 rows in the (usual monitor size window) instead of 2 columns and 2 rows as below :
So the height and width brings the tile in 2x3 frame (for usual monitor size window)
jaredburgettelastic
approved these changes
Jul 9, 2025
Contributor
jaredburgettelastic
left a comment
jaredburgettelastic
left a comment
There was a problem hiding this comment.
Have not desk tested, but code looks straightforward and good to me!
hop-dev
requested changes
Jul 9, 2025
| ) { | ||
| return ( | ||
| <EuiFlexItem grow={false} style={{ minWidth: LENS_VISUALIZATION_MIN_WIDTH }}> | ||
| <EuiPanel |
Contributor
There was a problem hiding this comment.
I am not a fan of the grey panel, I think this would look better white like the other tiles, and maybe with slighly larger text, maybe color="warning" and a warning icon? Could you have another go at the styling and see what you can come up with? 🙂
Contributor
There was a problem hiding this comment.
Maybe not colored text I think that will look weird ignore that, but icon could be nice 😎
Contributor
Author
There was a problem hiding this comment.
We can discuss if this looks better :
Contributor
There was a problem hiding this comment.
Yeah or maybe big central icon with text below, one for
hop-dev
approved these changes
Jul 9, 2025
1. minWidht and minHeight remains 2. Subdued tile is removed 3. Title and "Data not available" similar to other tiles 4. Warning icon currently near "Data not available"
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16214876053 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
abhishekbhatia1710
added a commit
to abhishekbhatia1710/kibana
that referenced
this pull request
Jul 11, 2025
…values gracefully for tiles on Privmon dashboard (elastic#226387) ## Summary What changed: Added error handling for PrivMon dashboard tiles when ES queries fail (like missing ML indices) Instead of showing broken visualizations, tiles now display a clean "Data not available" message The error tiles maintain consistent styling and layout with working tiles Added state tracking to detect when visualization loading completes - Check for missing [tables] property in visualization response to identify errors - Render a styled error state using EUI components that matches the design of working tiles - Made error message i18n compliant for proper localization Screenshot Ref :  With data :  Testing Steps : 1. Checkout this PR 2. Start the privmon engine : `POST kbn:/api/entity_analytics/monitoring/engine/init` 3. Add some privileged users either using a CSV file or from dev console. 4. Add relevant data for different indexes using the security-documents-generator. 6. Enable the risk score and Asset criticality. 7. Change filters for timerange or any KQL query to get the desired results. 8. The tile visualisations on the privmon dashboard should not display any errors. It should either display the Count or `Data not available`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit df7732a) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/privileged_user_monitoring/components/key_insights_panel/index.tsx
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
abhishekbhatia1710
added a commit
that referenced
this pull request
Jul 14, 2025
…fined values gracefully for tiles on Privmon dashboard (#226387) (#227577) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution][Entity Analytics][PrivMon] Handle null/undefined values gracefully for tiles on Privmon dashboard (#226387)](#226387) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Abhishek Bhatia","email":"117628830+abhishekbhatia1710@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-11T07:55:23Z","message":"[Security Solution][Entity Analytics][PrivMon] Handle null/undefined values gracefully for tiles on Privmon dashboard (#226387)\n\n## Summary\n\nWhat changed:\n\nAdded error handling for PrivMon dashboard tiles when ES queries fail\n(like missing ML indices)\nInstead of showing broken visualizations, tiles now display a clean\n\"Data not available\" message\nThe error tiles maintain consistent styling and layout with working\ntiles\n\nAdded state tracking to detect when visualization loading completes\n- Check for missing [tables] property in visualization response to\nidentify errors\n- Render a styled error state using EUI components that matches the\ndesign of working tiles\n- Made error message i18n compliant for proper localization\n\nScreenshot Ref : \n\n\n\n\nWith data : \n\n\n\n\n\nTesting Steps : \n1. Checkout this PR\n2. Start the privmon engine : `POST\nkbn:/api/entity_analytics/monitoring/engine/init`\n3. Add some privileged users either using a CSV file or from dev\nconsole.\n4. Add relevant data for different indexes using the\nsecurity-documents-generator.\n6. Enable the risk score and Asset criticality.\n7. Change filters for timerange or any KQL query to get the desired\nresults.\n8. The tile visualisations on the privmon dashboard should not display\nany errors. It should either display the Count or `Data not available`.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"df7732aab8d3cb1ba494f9fea0445b2cb8d108bc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Entity Analytics","backport:version","v9.1.0","v9.2.0"],"title":"[Security Solution][Entity Analytics][PrivMon] Handle null/undefined values gracefully for tiles on Privmon dashboard","number":226387,"url":"https://github.com/elastic/kibana/pull/226387","mergeCommit":{"message":"[Security Solution][Entity Analytics][PrivMon] Handle null/undefined values gracefully for tiles on Privmon dashboard (#226387)\n\n## Summary\n\nWhat changed:\n\nAdded error handling for PrivMon dashboard tiles when ES queries fail\n(like missing ML indices)\nInstead of showing broken visualizations, tiles now display a clean\n\"Data not available\" message\nThe error tiles maintain consistent styling and layout with working\ntiles\n\nAdded state tracking to detect when visualization loading completes\n- Check for missing [tables] property in visualization response to\nidentify errors\n- Render a styled error state using EUI components that matches the\ndesign of working tiles\n- Made error message i18n compliant for proper localization\n\nScreenshot Ref : \n\n\n\n\nWith data : \n\n\n\n\n\nTesting Steps : \n1. Checkout this PR\n2. Start the privmon engine : `POST\nkbn:/api/entity_analytics/monitoring/engine/init`\n3. Add some privileged users either using a CSV file or from dev\nconsole.\n4. Add relevant data for different indexes using the\nsecurity-documents-generator.\n6. Enable the risk score and Asset criticality.\n7. Change filters for timerange or any KQL query to get the desired\nresults.\n8. The tile visualisations on the privmon dashboard should not display\nany errors. It should either display the Count or `Data not available`.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"df7732aab8d3cb1ba494f9fea0445b2cb8d108bc"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226387","number":226387,"mergeCommit":{"message":"[Security Solution][Entity Analytics][PrivMon] Handle null/undefined values gracefully for tiles on Privmon dashboard (#226387)\n\n## Summary\n\nWhat changed:\n\nAdded error handling for PrivMon dashboard tiles when ES queries fail\n(like missing ML indices)\nInstead of showing broken visualizations, tiles now display a clean\n\"Data not available\" message\nThe error tiles maintain consistent styling and layout with working\ntiles\n\nAdded state tracking to detect when visualization loading completes\n- Check for missing [tables] property in visualization response to\nidentify errors\n- Render a styled error state using EUI components that matches the\ndesign of working tiles\n- Made error message i18n compliant for proper localization\n\nScreenshot Ref : \n\n\n\n\nWith data : \n\n\n\n\n\nTesting Steps : \n1. Checkout this PR\n2. Start the privmon engine : `POST\nkbn:/api/entity_analytics/monitoring/engine/init`\n3. Add some privileged users either using a CSV file or from dev\nconsole.\n4. Add relevant data for different indexes using the\nsecurity-documents-generator.\n6. Enable the risk score and Asset criticality.\n7. Change filters for timerange or any KQL query to get the desired\nresults.\n8. The tile visualisations on the privmon dashboard should not display\nany errors. It should either display the Count or `Data not available`.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"df7732aab8d3cb1ba494f9fea0445b2cb8d108bc"}}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…values gracefully for tiles on Privmon dashboard (elastic#226387) ## Summary What changed: Added error handling for PrivMon dashboard tiles when ES queries fail (like missing ML indices) Instead of showing broken visualizations, tiles now display a clean "Data not available" message The error tiles maintain consistent styling and layout with working tiles Added state tracking to detect when visualization loading completes - Check for missing [tables] property in visualization response to identify errors - Render a styled error state using EUI components that matches the design of working tiles - Made error message i18n compliant for proper localization Screenshot Ref :  With data :  Testing Steps : 1. Checkout this PR 2. Start the privmon engine : `POST kbn:/api/entity_analytics/monitoring/engine/init` 3. Add some privileged users either using a CSV file or from dev console. 4. Add relevant data for different indexes using the security-documents-generator. 6. Enable the risk score and Asset criticality. 7. Change filters for timerange or any KQL query to get the desired results. 8. The tile visualisations on the privmon dashboard should not display any errors. It should either display the Count or `Data not available`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed:
Added error handling for PrivMon dashboard tiles when ES queries fail (like missing ML indices)
Instead of showing broken visualizations, tiles now display a clean "Data not available" message
The error tiles maintain consistent styling and layout with working tiles
Added state tracking to detect when visualization loading completes
Screenshot Ref :
With data :
Testing Steps :
POST kbn:/api/entity_analytics/monitoring/engine/initData not available.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.