-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Security Solution][THI] Create hook to fetch security default patterns and replace useTimelineFilters usage #226314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
christineweng
merged 3 commits into
elastic:main
from
christineweng:dp-fix-investigate-in-timeline
Jul 9, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
...ns/security_solution/public/data_view_manager/hooks/use_security_default_patterns.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import { renderHook } from '@testing-library/react'; | ||
| import { useSelector } from 'react-redux'; | ||
| import { DEFAULT_SECURITY_SOLUTION_DATA_VIEW_ID } from '../constants'; | ||
| import { useSecurityDefaultPatterns } from './use_security_default_patterns'; | ||
|
|
||
| jest.mock('react-redux', () => ({ | ||
| useSelector: jest.fn(), | ||
| })); | ||
|
|
||
| describe('useSecurityDefaultPatterns', () => { | ||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('should return the default data view', () => { | ||
| const mockDataViews = [ | ||
| { | ||
| id: DEFAULT_SECURITY_SOLUTION_DATA_VIEW_ID, | ||
| title: 'logs-*,metrics-*', | ||
| name: 'default_view', | ||
| }, | ||
| { | ||
| id: 'custom-view-1', | ||
| title: 'Custom View 1', | ||
| name: 'custom_view_1', | ||
| }, | ||
| ]; | ||
|
|
||
| (useSelector as jest.Mock).mockReturnValue({ | ||
| dataViews: mockDataViews, | ||
| defaultDataViewId: DEFAULT_SECURITY_SOLUTION_DATA_VIEW_ID, | ||
| }); | ||
|
|
||
| const { result } = renderHook(() => useSecurityDefaultPatterns()); | ||
| expect(result.current).toEqual({ | ||
| id: DEFAULT_SECURITY_SOLUTION_DATA_VIEW_ID, | ||
| indexPatterns: ['logs-*', 'metrics-*'], | ||
| }); | ||
| }); | ||
|
|
||
| it('should return empty id and index patterns if no default data view is found', () => { | ||
| (useSelector as jest.Mock).mockReturnValue({ | ||
| dataViews: [], | ||
| defaultDataViewId: null, | ||
| }); | ||
| const { result } = renderHook(() => useSecurityDefaultPatterns()); | ||
| expect(result.current).toEqual({ id: '', indexPatterns: [] }); | ||
| }); | ||
| }); |
41 changes: 41 additions & 0 deletions
41
...plugins/security_solution/public/data_view_manager/hooks/use_security_default_patterns.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { useMemo } from 'react'; | ||
| import { useSelector } from 'react-redux'; | ||
| import { sharedStateSelector } from '../redux/selectors'; | ||
|
|
||
| interface UseSecurityDefaultPatternsResult { | ||
| /** | ||
| * The default data view id. | ||
| */ | ||
| id: string; | ||
| /** | ||
| * The index patterns of the default data view. | ||
| */ | ||
| indexPatterns: string[]; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the default data view id and index patterns. | ||
| */ | ||
| export const useSecurityDefaultPatterns = (): UseSecurityDefaultPatternsResult => { | ||
| const { dataViews: dataViewSpecs, defaultDataViewId } = useSelector(sharedStateSelector); | ||
|
|
||
| const defaultDataViewSpec = useMemo( | ||
| () => dataViewSpecs.find((dv) => dv.id === defaultDataViewId), | ||
| [dataViewSpecs, defaultDataViewId] | ||
| ); | ||
|
|
||
| return useMemo( | ||
| () => ({ | ||
|
PhilippeOberti marked this conversation as resolved.
|
||
| id: defaultDataViewSpec?.id ?? '', | ||
| indexPatterns: defaultDataViewSpec?.title?.split(',') ?? [], | ||
| }), | ||
| [defaultDataViewSpec] | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this kind of a duplicate of this other hook?