Skip to content

[Fleet] Remove accordion expansion button when theres no content on integration sync #226282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Supplementing merged 5 commits into from
Jul 2, 2025
Merged

[Fleet] Remove accordion expansion button when theres no content on integration sync #226282

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f81e96e
added check for rendering expansion arrow only when theres additional…
Supplementing Jul 2, 2025
fa4074f
Merge branch 'main' into fix-empty-accordion
elasticmachine Jul 2, 2025
078c782
made some adjustments, updated prop on collapsible panel
Supplementing Jul 2, 2025
1ac6fb7
Merge branch 'fix-empty-accordion' of https://github.com/Supplementin…
Supplementing Jul 2, 2025
2b2e17c
added isDisabled prop to nested accordion;
Supplementing Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...blic/applications/fleet/sections/settings/components/outputs_table/integration_status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ const CollapsiblePanel: React.FC<{
children: React.ReactNode;
id: string;
title: React.ReactNode;
isDisabled?: boolean;
'data-test-subj'?: string;
}> = ({ id, title, children, 'data-test-subj': dataTestSubj }) => {
}> = ({ id, title, children, isDisabled, 'data-test-subj': dataTestSubj }) => {
const arrowProps = useMemo<EuiAccordionProps['arrowProps']>(() => {
if (dataTestSubj) {
return {
Expand All @@ -57,6 +58,7 @@ const CollapsiblePanel: React.FC<{
}
return undefined;
}, [dataTestSubj]);

const { euiTheme } = useEuiTheme();
return (
<EuiPanel
Expand Down Expand Up @@ -99,11 +101,12 @@ const CollapsiblePanel: React.FC<{
}
`}
id={id}
arrowDisplay="left"
arrowDisplay={isDisabled ? 'none' : 'left'}
buttonClassName="ingest-integration-title-button"
buttonContent={title}
arrowProps={arrowProps}
data-test-subj={dataTestSubj}
isDisabled={isDisabled}
>
{children}
</EuiAccordion>
Expand Down Expand Up @@ -142,6 +145,7 @@ export const IntegrationStatus: React.FunctionComponent<{
<CollapsiblePanel
id={integration.package_name}
data-test-subj={dataTestSubj}
isDisabled={!integration.error && !integration?.warning && !customAssets.length}
title={
<EuiTitle size="xs">
<h3>
Expand Down Expand Up @@ -252,6 +256,8 @@ export const IntegrationStatus: React.FunctionComponent<{
<EuiAccordion
id={`${customAsset.type}:${customAsset.name}`}
key={`${customAsset.type}:${customAsset.name}`}
arrowDisplay={customAsset.error ? 'left' : 'none'}
isDisabled={!customAsset.error}
buttonContent={
<EuiFlexGroup alignItems="baseline" gutterSize="xs">
<EuiFlexItem grow={false}>
Expand Down
Loading