Skip to content

[8.19] [Alerting / Linked Dashboards] tweak linked dashboard success toast wording (#226079) #226256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Jul 2, 2025
Merged

[8.19] [Alerting / Linked Dashboards] tweak linked dashboard success toast wording (#226079) #226256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lugins/observability/public/pages/alert_details/hooks/use_add_suggested_dashboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ describe('useAddSuggestedDashboards', () => {
// Check that notifications.toasts.addSuccess was called
expect(mockUseKibanaReturnValue.services.notifications.toasts.addSuccess).toHaveBeenCalledWith({
title: 'Added to linked dashboard',
text: `From now on this dashboard will be linked to all alerts related to ${TEST_RULE_NAME}`,
text: `From now on, this dashboard will be linked to all alerts triggered by this rule`,
});
});

Expand Down
39 changes: 15 additions & 24 deletions ...ity/plugins/observability/public/pages/alert_details/hooks/use_add_suggested_dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,30 +39,21 @@ export const useAddSuggestedDashboards = ({
[notifications.toasts]
);

const onSuccess = useCallback(
async (data: Rule) => {
if (!addingDashboardId)
throw new Error('Adding dashboard id not defined, this should never occur');
await onSuccessAddSuggestedDashboard();
setAddingDashboardId(undefined);
notifications.toasts.addSuccess({
title: i18n.translate(
'xpack.observability.alertDetails.addSuggestedDashboardSuccess.title',
{
defaultMessage: 'Added to linked dashboard',
}
),
text: i18n.translate('xpack.observability.alertDetails.addSuggestedDashboardSuccess.text', {
defaultMessage:
'From now on this dashboard will be linked to all alerts related to {ruleName}',
values: {
ruleName: data.name,
},
}),
});
},
[addingDashboardId, notifications.toasts, onSuccessAddSuggestedDashboard]
);
const onSuccess = useCallback(async () => {
if (!addingDashboardId)
throw new Error('Adding dashboard id not defined, this should never occur');
await onSuccessAddSuggestedDashboard();
setAddingDashboardId(undefined);
notifications.toasts.addSuccess({
title: i18n.translate('xpack.observability.alertDetails.addSuggestedDashboardSuccess.title', {
defaultMessage: 'Added to linked dashboard',
}),
text: i18n.translate('xpack.observability.alertDetails.addSuggestedDashboardSuccess.text', {
defaultMessage:
'From now on, this dashboard will be linked to all alerts triggered by this rule',
}),
});
}, [addingDashboardId, notifications.toasts, onSuccessAddSuggestedDashboard]);

const { mutateAsync: updateRule } = useUpdateRule({ http, onError, onSuccess });

Expand Down