Skip to content

Comments

[8.19] [Security Solution] Fix initial data view flash (#225675)#226230

Merged
lgestc merged 2 commits intoelastic:8.19from
lgestc:backport/8.19/pr-225675
Jul 2, 2025
Merged

[8.19] [Security Solution] Fix initial data view flash (#225675)#226230
lgestc merged 2 commits intoelastic:8.19from
lgestc:backport/8.19/pr-225675

Conversation

@lgestc
Copy link
Contributor

@lgestc lgestc commented Jul 2, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Solves the initial UI "flash" when new data view picker is enabled and
the application is starting.

Compared to previous approach, we are not doing default data view
provider and just check the loading state before telling the user no
indices are matched.

## Testing
Head to timelines page or explore pages... should not see the data flash
with this feature flag on.
Brief blank page could occur, as the proper loading screens would be
required.

```
xpack.securitySolution.enableExperimental: ['newDataViewPickerEnabled']
```

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 209c298)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/entity_analytics/pages/entity_analytics_dashboard.tsx
#	x-pack/solutions/security/plugins/security_solution/public/entity_analytics/pages/entity_analytics_privileged_user_monitoring_page.tsx
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/pages/network.tsx
@lgestc lgestc requested a review from kibanamachine as a code owner July 2, 2025 14:21
@lgestc lgestc added the backport This PR is a backport of another PR label Jul 2, 2025
@lgestc lgestc enabled auto-merge (squash) July 2, 2025 14:21
@lgestc lgestc disabled auto-merge July 2, 2025 14:21
@lgestc lgestc enabled auto-merge (squash) July 2, 2025 14:22
@lgestc lgestc merged commit 7711570 into elastic:8.19 Jul 2, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7527 7528 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.4MB 9.4MB +880.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants