[8.19] [Security Solution][Sourcerer] Replace unnecessary useDataViewSpec calls (#224831)#226186
Merged
lgestc merged 1 commit intoelastic:8.19from Jul 2, 2025
Merged
Conversation
…lls (elastic#224831) ## Summary As useDataViewSpec uses are expensive (due to toSpec method in the data view implementation), this PR adds in an optional switch to the hook and actually replaces it where we only need the data view id and not the full spec. ### Testing Set the FF, ``` xpack.securitySolution.enableExperimental: ['newDataViewPickerEnabled'] ``` verify that the app still works correctly (timelines) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 711ab70) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/data_view_manager/hooks/use_data_view_spec.ts
1 task
PhilippeOberti
approved these changes
Jul 2, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation