[ES|QL] fix: don't let clear ESQL control type#226122
Merged
sddonne merged 1 commit intoelastic:mainfrom Jul 2, 2025
Merged
Conversation
sddonne
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Jul 2, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16026569366 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
## Summary
When attempting to clear the control type an uncaught error occurs.
```
shared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')
at shared_form_components.tsx:56:1
```
As the type is mandatory, make the select un-clearable.
<img width="581" alt="image"
src="https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294"
/>
(cherry picked from commit 1b17e02)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
## Summary
When attempting to clear the control type an uncaught error occurs.
```
shared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')
at shared_form_components.tsx:56:1
```
As the type is mandatory, make the select un-clearable.
<img width="581" alt="image"
src="https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294"
/>
(cherry picked from commit 1b17e02)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
) # Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] fix: don't let clear ESQL control type (#226122)](#226122) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sebastian Delle Donne","email":"sebastian.delledonne@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T13:32:03Z","message":"[ES|QL] fix: don't let clear ESQL control type (#226122)\n\n## Summary\nWhen attempting to clear the control type an uncaught error occurs.\n```\nshared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')\n at shared_form_components.tsx:56:1\n```\n\nAs the type is mandatory, make the select un-clearable.\n\n<img width=\"581\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294\"\n/>","sha":"1b17e02ccbcaf04b4c16a2a75ba377441f50d2bc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL] fix: don't let clear ESQL control type","number":226122,"url":"https://github.com/elastic/kibana/pull/226122","mergeCommit":{"message":"[ES|QL] fix: don't let clear ESQL control type (#226122)\n\n## Summary\nWhen attempting to clear the control type an uncaught error occurs.\n```\nshared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')\n at shared_form_components.tsx:56:1\n```\n\nAs the type is mandatory, make the select un-clearable.\n\n<img width=\"581\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294\"\n/>","sha":"1b17e02ccbcaf04b4c16a2a75ba377441f50d2bc"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226122","number":226122,"mergeCommit":{"message":"[ES|QL] fix: don't let clear ESQL control type (#226122)\n\n## Summary\nWhen attempting to clear the control type an uncaught error occurs.\n```\nshared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')\n at shared_form_components.tsx:56:1\n```\n\nAs the type is mandatory, make the select un-clearable.\n\n<img width=\"581\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294\"\n/>","sha":"1b17e02ccbcaf04b4c16a2a75ba377441f50d2bc"}}]}] BACKPORT--> Co-authored-by: Sebastian Delle Donne <sebastian.delledonne@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[ES|QL] fix: don't let clear ESQL control type (#226122)](#226122) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sebastian Delle Donne","email":"sebastian.delledonne@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T13:32:03Z","message":"[ES|QL] fix: don't let clear ESQL control type (#226122)\n\n## Summary\nWhen attempting to clear the control type an uncaught error occurs.\n```\nshared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')\n at shared_form_components.tsx:56:1\n```\n\nAs the type is mandatory, make the select un-clearable.\n\n<img width=\"581\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294\"\n/>","sha":"1b17e02ccbcaf04b4c16a2a75ba377441f50d2bc","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL] fix: don't let clear ESQL control type","number":226122,"url":"https://github.com/elastic/kibana/pull/226122","mergeCommit":{"message":"[ES|QL] fix: don't let clear ESQL control type (#226122)\n\n## Summary\nWhen attempting to clear the control type an uncaught error occurs.\n```\nshared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')\n at shared_form_components.tsx:56:1\n```\n\nAs the type is mandatory, make the select un-clearable.\n\n<img width=\"581\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294\"\n/>","sha":"1b17e02ccbcaf04b4c16a2a75ba377441f50d2bc"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226122","number":226122,"mergeCommit":{"message":"[ES|QL] fix: don't let clear ESQL control type (#226122)\n\n## Summary\nWhen attempting to clear the control type an uncaught error occurs.\n```\nshared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')\n at shared_form_components.tsx:56:1\n```\n\nAs the type is mandatory, make the select un-clearable.\n\n<img width=\"581\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294\"\n/>","sha":"1b17e02ccbcaf04b4c16a2a75ba377441f50d2bc"}}]}] BACKPORT--> Co-authored-by: Sebastian Delle Donne <sebastian.delledonne@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary
When attempting to clear the control type an uncaught error occurs.
```
shared_form_components.tsx:56 Uncaught TypeError: Cannot read properties of undefined (reading 'key')
at shared_form_components.tsx:56:1
```
As the type is mandatory, make the select un-clearable.
<img width="581" alt="image"
src="https://github.com/user-attachments/assets/e7b10080-0886-4a03-b8eb-4b8cca597294"
/>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When attempting to clear the control type an uncaught error occurs.
As the type is mandatory, make the select un-clearable.