Skip to content

Comments

Test fix: Close popover before clicking on the tab#226116

Merged
jennypavlova merged 3 commits intoelastic:mainfrom
jennypavlova:225181-try-to-fix
Jul 3, 2025
Merged

Test fix: Close popover before clicking on the tab#226116
jennypavlova merged 3 commits intoelastic:mainfrom
jennypavlova:225181-try-to-fix

Conversation

@jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Jul 2, 2025

Closes #225181

Summary

This PR tries to fix a failing test by closing all popovers that cover the tab button using the escape key.

@jennypavlova jennypavlova self-assigned this Jul 2, 2025
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8509

[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed.

see run history

@jennypavlova jennypavlova marked this pull request as ready for review July 2, 2025 12:00
@jennypavlova jennypavlova requested a review from a team July 2, 2025 12:00
@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Jul 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8510

[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed.

see run history

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @jennypavlova

@jennypavlova jennypavlova enabled auto-merge (squash) July 2, 2025 14:44
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennypavlova jennypavlova merged commit d5f6e40 into elastic:main Jul 3, 2025
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16045215203

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 3, 2025
Closes elastic#225181

## Summary

This PR tries to fix a failing test by closing all popovers that cover
the tab button using the escape key.

(cherry picked from commit d5f6e40)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 3, 2025
Closes elastic#225181

## Summary

This PR tries to fix a failing test by closing all popovers that cover
the tab button using the escape key.

(cherry picked from commit d5f6e40)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18 Backport failed because of merge conflicts
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 226116

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 3, 2025
…226347)

# Backport

This will backport the following commits from `main` to `9.1`:
- [Test fix: Close popover before clicking on the tab
(#226116)](#226116)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-03T08:16:20Z","message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"Test
fix: Close popover before clicking on the
tab","number":226116,"url":"https://github.com/elastic/kibana/pull/226116","mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226116","number":226116,"mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}}]}] BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 3, 2025
…226346)

# Backport

This will backport the following commits from `main` to `8.19`:
- [Test fix: Close popover before clicking on the tab
(#226116)](#226116)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-03T08:16:20Z","message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"Test
fix: Close popover before clicking on the
tab","number":226116,"url":"https://github.com/elastic/kibana/pull/226116","mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226116","number":226116,"mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}}]}] BACKPORT-->

Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
jennypavlova added a commit to jennypavlova/kibana that referenced this pull request Jul 3, 2025
Closes elastic#225181

## Summary

This PR tries to fix a failing test by closing all popovers that cover
the tab button using the escape key.

(cherry picked from commit d5f6e40)

# Conflicts:
#	x-pack/test/functional/apps/infra/node_details.ts
jennypavlova added a commit to jennypavlova/kibana that referenced this pull request Jul 3, 2025
Closes elastic#225181

## Summary

This PR tries to fix a failing test by closing all popovers that cover
the tab button using the escape key.

(cherry picked from commit d5f6e40)

# Conflicts:
#	x-pack/test/functional/apps/infra/node_details.ts
@jennypavlova
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.18
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jennypavlova added a commit that referenced this pull request Jul 3, 2025
…226403)

# Backport

This will backport the following commits from `main` to `8.18`:
- [Test fix: Close popover before clicking on the tab
(#226116)](#226116)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-03T08:16:20Z","message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.1.0","v8.19.0","v9.2.0"],"title":"Test
fix: Close popover before clicking on the
tab","number":226116,"url":"https://github.com/elastic/kibana/pull/226116","mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226347","number":226347,"state":"MERGED","mergeCommit":{"sha":"eea43c24d9c9d6fbc22cc57b4b1f2f79df152711","message":"[9.1]
Test fix: Close popover before clicking on the tab (#226116)
(#226347)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.1`:\n- [Test fix: Close popover before clicking on the
tab\n(#226116)](https://github.com/elastic/kibana/pull/226116)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
jennypavlova
<dzheni.pavlova@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226346","number":226346,"state":"MERGED","mergeCommit":{"sha":"4ffa18c085a42439614dc367b8210cd1f8f78db8","message":"[8.19]
Test fix: Close popover before clicking on the tab (#226116)
(#226346)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.19`:\n- [Test fix: Close popover before clicking on the
tab\n(#226116)](https://github.com/elastic/kibana/pull/226116)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
jennypavlova
<dzheni.pavlova@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226116","number":226116,"mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}}]}] BACKPORT-->
jennypavlova added a commit that referenced this pull request Jul 3, 2025
…226404)

# Backport

This will backport the following commits from `main` to `8.17`:
- [Test fix: Close popover before clicking on the tab
(#226116)](#226116)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-03T08:16:20Z","message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.1.0","v8.19.0","v9.2.0"],"title":"Test
fix: Close popover before clicking on the
tab","number":226116,"url":"https://github.com/elastic/kibana/pull/226116","mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226347","number":226347,"state":"MERGED","mergeCommit":{"sha":"eea43c24d9c9d6fbc22cc57b4b1f2f79df152711","message":"[9.1]
Test fix: Close popover before clicking on the tab (#226116)
(#226347)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.1`:\n- [Test fix: Close popover before clicking on the
tab\n(#226116)](https://github.com/elastic/kibana/pull/226116)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
jennypavlova
<dzheni.pavlova@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226346","number":226346,"state":"MERGED","mergeCommit":{"sha":"4ffa18c085a42439614dc367b8210cd1f8f78db8","message":"[8.19]
Test fix: Close popover before clicking on the tab (#226116)
(#226346)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.19`:\n- [Test fix: Close popover before clicking on the
tab\n(#226116)](https://github.com/elastic/kibana/pull/226116)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
jennypavlova
<dzheni.pavlova@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226116","number":226116,"mergeCommit":{"message":"Test
fix: Close popover before clicking on the tab (#226116)\n\nCloses
#225181\n\n## Summary\n\nThis PR tries to fix a failing test by closing
all popovers that cover\nthe tab button using the escape
key.","sha":"d5f6e40ef663b7a3bab5858b4b5eaa4506c5f691"}}]}] BACKPORT-->
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
Closes elastic#225181

## Summary

This PR tries to fix a failing test by closing all popovers that cover
the tab button using the escape key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.17.9 v8.18.4 v8.19.0 v9.1.0 v9.2.0

Projects

None yet

4 participants