Extract index pattern validation rules into ui/public by cjcenizal · Pull Request #22606 · elastic/kibana

cjcenizal · 2018-08-31T20:58:51Z

This will allow us to more easily re-use these rules in rollups.

…urn a value which accurately reflects the name.

…index_patterns.

jen-huang

Small nitpick, otherwise code LGTM!

jen-huang · 2018-08-31T21:59:14Z

...ins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js

 * under the License.
 */

+export { INDEX_PATTERN_ILLEGAL_CHARACTERS } from 'ui/index_patterns';


it's nice to import everything the wizard needs from its own constants file, but I don't love having the same object exported from 2 different places. using

import { INDEX_PATTERN_ILLEGAL_CHARACTERS as ILLEGAL_CHARACTERS } from 'ui/index_patterns';

in step_index_pattern.js instead is not much additional overhead imo

elasticmachine · 2018-08-31T22:31:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-31T23:49:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-09-01T00:12:12Z

These tests have failed on Jenkins but I can only get a couple of them to fail locally:

21:16:54 Summary of all failing tests
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_time_field/__tests__/step_time_field.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_matched_indices.js:8:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/index.js:34:28)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_time_field/step_time_field.js:16:12)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_time_field/__tests__/step_time_field.test.js:35:24)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/__tests__/step_index_pattern.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.js:16:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/__tests__/step_index_pattern.test.js:46:27)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/create_index_pattern_wizard.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_matched_indices.js:8:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/index.js:34:28)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/create_index_pattern_wizard.js:16:12)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/create_index_pattern_wizard.test.js:39:36)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/__tests__/indices_list.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/indices_list.js:16:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/components/step_index_pattern/components/indices_list/__tests__/indices_list.test.js:7:21)
21:16:54 
21:16:54  FAIL  src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/render.test.js
21:16:54   ● Test suite failed to run
21:16:54 
21:16:54     TypeError: Cannot redefine property: prototype
21:16:54         at Function.defineProperties (<anonymous>)
21:16:54 
21:16:54       43 | 
21:16:54       44 |     return this;
21:16:54     > 45 |   })
21:16:54       46 | };
21:16:54       47 | 
21:16:54       48 | /**
21:16:54       
21:16:54       at Function.<anonymous> (src/ui/public/utils/legacy_class.js:45:12)
21:16:54       at Object.<anonymous> (src/ui/public/errors.js:65:48)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index_patterns.js:8:15)
21:16:54       at Object.<anonymous> (src/ui/public/index_patterns/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js:7:23)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/get_matched_indices.js:8:18)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/index.js:34:28)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/create_index_pattern_wizard.js:16:12)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/render.js:15:36)
21:16:54       at Object.<anonymous> (src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/__tests__/render.test.js:31:146)
21:16:54 
21:16:54 
21:16:54 Test Suites: 5 failed, 1 skipped, 465 passed, 470 of 471 total

elasticmachine · 2018-09-02T03:36:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-09-04T18:23:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Rename containsInvalidCharacters to containsIllegalCharacters and return a value which accurately reflects the name. * Move illegal index pattern characters from Management into ui/public/index_patterns.

cjcenizal added 2 commits August 31, 2018 13:43

Rename containsInvalidCharacters to containsIllegalCharacters and ret…

ed7ea12

…urn a value which accurately reflects the name.

Move illegal index pattern characters from Management into ui/public/…

daa88c8

…index_patterns.

cjcenizal added chore :Management v7.0.0 v6.5.0 labels Aug 31, 2018

cjcenizal requested a review from jen-huang August 31, 2018 20:58

jen-huang approved these changes Aug 31, 2018

View reviewed changes

Address nit.

79452c6

Fix broken Jest tests.

ba4adea

Add comments.

0177d55

cjcenizal merged commit bcb7938 into elastic:master Sep 4, 2018

cjcenizal deleted the chore/extract-index-pattern-rules branch September 4, 2018 18:27

cjcenizal mentioned this pull request Sep 4, 2018

[6.x] Extract index pattern validation rules into ui/public (#22606) #22680

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract index pattern validation rules into ui/public#22606

Extract index pattern validation rules into ui/public#22606
cjcenizal merged 5 commits intoelastic:masterfrom
cjcenizal:chore/extract-index-pattern-rules

cjcenizal commented Aug 31, 2018

Uh oh!

jen-huang left a comment

Uh oh!

jen-huang Aug 31, 2018

Uh oh!

elasticmachine commented Aug 31, 2018

Uh oh!

elasticmachine commented Aug 31, 2018

Uh oh!

cjcenizal commented Sep 1, 2018

Uh oh!

elasticmachine commented Sep 2, 2018

Uh oh!

elasticmachine commented Sep 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cjcenizal commented Aug 31, 2018

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

jen-huang Aug 31, 2018

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 31, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Aug 31, 2018

💔 Build Failed

Uh oh!

cjcenizal commented Sep 1, 2018

Uh oh!

elasticmachine commented Sep 2, 2018

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 4, 2018

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants