[dashboard] move library functional test to unit test#226058
Merged
nreese merged 1 commit intoelastic:mainfrom Jul 2, 2025
Merged
[dashboard] move library functional test to unit test#226058nreese merged 1 commit intoelastic:mainfrom
nreese merged 1 commit intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
nreese
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jul 2, 2025
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Great to see more functional tests removed! Changes LGTM and everything is well covered.
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16033491270 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
Functional tests have several disadvantages * They are slow to run * They are expensive to run * They are difficult to unsure consistently (not flaky) This PR re-writes `embeddable_library` functional tests as unit test to reduce our functional test tech debt. (cherry picked from commit 101ca6e)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
Functional tests have several disadvantages * They are slow to run * They are expensive to run * They are difficult to unsure consistently (not flaky) This PR re-writes `embeddable_library` functional tests as unit test to reduce our functional test tech debt. (cherry picked from commit 101ca6e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…#226289) # Backport This will backport the following commits from `main` to `9.1`: - [[dashboard] move library functional test to unit test (#226058)](#226058) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T18:59:10Z","message":"[dashboard] move library functional test to unit test (#226058)\n\nFunctional tests have several disadvantages\n* They are slow to run\n* They are expensive to run\n* They are difficult to unsure consistently (not flaky)\n\nThis PR re-writes `embeddable_library` functional tests as unit test to\nreduce our functional test tech debt.","sha":"101ca6ec36c57d909abc7492d8fa908f5fe35f78","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[dashboard] move library functional test to unit test","number":226058,"url":"https://github.com/elastic/kibana/pull/226058","mergeCommit":{"message":"[dashboard] move library functional test to unit test (#226058)\n\nFunctional tests have several disadvantages\n* They are slow to run\n* They are expensive to run\n* They are difficult to unsure consistently (not flaky)\n\nThis PR re-writes `embeddable_library` functional tests as unit test to\nreduce our functional test tech debt.","sha":"101ca6ec36c57d909abc7492d8fa908f5fe35f78"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226058","number":226058,"mergeCommit":{"message":"[dashboard] move library functional test to unit test (#226058)\n\nFunctional tests have several disadvantages\n* They are slow to run\n* They are expensive to run\n* They are difficult to unsure consistently (not flaky)\n\nThis PR re-writes `embeddable_library` functional tests as unit test to\nreduce our functional test tech debt.","sha":"101ca6ec36c57d909abc7492d8fa908f5fe35f78"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
1 task
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jul 7, 2025
#226288) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] move library functional test to unit test (#226058)](#226058) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T18:59:10Z","message":"[dashboard] move library functional test to unit test (#226058)\n\nFunctional tests have several disadvantages\n* They are slow to run\n* They are expensive to run\n* They are difficult to unsure consistently (not flaky)\n\nThis PR re-writes `embeddable_library` functional tests as unit test to\nreduce our functional test tech debt.","sha":"101ca6ec36c57d909abc7492d8fa908f5fe35f78","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[dashboard] move library functional test to unit test","number":226058,"url":"https://github.com/elastic/kibana/pull/226058","mergeCommit":{"message":"[dashboard] move library functional test to unit test (#226058)\n\nFunctional tests have several disadvantages\n* They are slow to run\n* They are expensive to run\n* They are difficult to unsure consistently (not flaky)\n\nThis PR re-writes `embeddable_library` functional tests as unit test to\nreduce our functional test tech debt.","sha":"101ca6ec36c57d909abc7492d8fa908f5fe35f78"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226058","number":226058,"mergeCommit":{"message":"[dashboard] move library functional test to unit test (#226058)\n\nFunctional tests have several disadvantages\n* They are slow to run\n* They are expensive to run\n* They are difficult to unsure consistently (not flaky)\n\nThis PR re-writes `embeddable_library` functional tests as unit test to\nreduce our functional test tech debt.","sha":"101ca6ec36c57d909abc7492d8fa908f5fe35f78"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
Functional tests have several disadvantages * They are slow to run * They are expensive to run * They are difficult to unsure consistently (not flaky) This PR re-writes `embeddable_library` functional tests as unit test to reduce our functional test tech debt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional tests have several disadvantages
This PR re-writes
embeddable_libraryfunctional tests as unit test to reduce our functional test tech debt.