Skip to content

[APM] Fix broken operation page#226036

Merged
kpatticha merged 5 commits intoelastic:mainfrom
kpatticha:152-fix-broken-operation-page
Jul 2, 2025
Merged

[APM] Fix broken operation page#226036
kpatticha merged 5 commits intoelastic:mainfrom
kpatticha:152-fix-broken-operation-page

Conversation

@kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jul 1, 2025

Summary

close https://github.com/elastic/observability-error-backlog/issues/152

The issue seems to appear only when the waterfall has an error.

Before

Screen.Recording.2025-07-01.at.4.49.10.PM.mov

TODO

  • add test

@kpatticha kpatticha requested a review from a team July 1, 2025 15:14
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jul 1, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! ❤️ Would be good to add more tests to cover those cases (could be a follow-up PR)

Edit I just saw that the tests are mentioned in the description, sorry for the spam

@kpatticha kpatticha enabled auto-merge (squash) July 2, 2025 12:22
@kpatticha kpatticha merged commit 74bdc5b into elastic:main Jul 2, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16027669569

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #60 / Journey[infra_hosts_view] Navigate to Hosts view and load 500 hosts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +26.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 2, 2025
## Summary

close elastic/observability-error-backlog#152

The issue seems to appear only when the waterfall has an error.

## Before

https://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172

TODO

- [ ] add test

(cherry picked from commit 74bdc5b)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 2, 2025
## Summary

close elastic/observability-error-backlog#152

The issue seems to appear only when the waterfall has an error.

## Before

https://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172

TODO

- [ ] add test

(cherry picked from commit 74bdc5b)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 2, 2025
## Summary

close elastic/observability-error-backlog#152

The issue seems to appear only when the waterfall has an error.

## Before

https://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172

TODO

- [ ] add test

(cherry picked from commit 74bdc5b)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 226036

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 2, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [[APM] Fix broken operation page
(#226036)](#226036)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T14:18:01Z","message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add
test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix broken operation
page","number":226036,"url":"https://github.com/elastic/kibana/pull/226036","mergeCommit":{"message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add
test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226036","number":226036,"mergeCommit":{"message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 2, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [[APM] Fix broken operation page
(#226036)](#226036)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T14:18:01Z","message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add
test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix broken operation
page","number":226036,"url":"https://github.com/elastic/kibana/pull/226036","mergeCommit":{"message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add
test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226036","number":226036,"mergeCommit":{"message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 2, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[APM] Fix broken operation page
(#226036)](#226036)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T14:18:01Z","message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add
test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM]
Fix broken operation
page","number":226036,"url":"https://github.com/elastic/kibana/pull/226036","mergeCommit":{"message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add
test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226036","number":226036,"mergeCommit":{"message":"[APM]
Fix broken operation page (#226036)\n\n## Summary\n\nclose
https://github.com/elastic/observability-error-backlog/issues/152\n\nThe
issue seems to appear only when the waterfall has an error. \n\n##
Before
\n\n\n\nhttps://github.com/user-attachments/assets/7ef12356-cad3-4560-a057-6a4b3b161172\n\nTODO\n\n-
[ ] add test","sha":"74bdc5bbae9e0c84dc0866fb446b56fc0cfda622"}}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants