[8.19] [ES|QL] Stop ANTLR token monkey-patching in parser (#225629)#226010
Merged
kibanamachine merged 1 commit intoelastic:8.19from Jul 1, 2025
Merged
[8.19] [ES|QL] Stop ANTLR token monkey-patching in parser (#225629)#226010kibanamachine merged 1 commit intoelastic:8.19from
kibanamachine merged 1 commit intoelastic:8.19from
Conversation
## Summary A small cleanup in parser code in the ES|QL AST package. We want to show users readable syntax error token names like `[` and `(` (instead of `LP`), however, we should not monkey-patch ANTLR generated files to achieve this. Instead, this PR moves the message improvement code to the validation & autocomplete package, where the messages are actually used. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 750cc7c)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
cc @vadimkibana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation