Skip to content

Fix #22581 by introducing an artificial delay #22601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisdavies merged 5 commits into from
Sep 5, 2018
Merged

Fix #22581 by introducing an artificial delay #22601

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5645aa1
Attempt to fix #22581 by introducing a delay to the
chrisdavies Aug 31, 2018
aa4b607
Move the setTimeout to the end of waitForRenderComplete
chrisdavies Aug 31, 2018
b1eee96
Merge branch 'master' of github.com:elastic/kibana into reporting/225…
chrisdavies Sep 4, 2018
5dce966
Merge branch 'master' of github.com:elastic/kibana into reporting/225…
chrisdavies Sep 4, 2018
989957f
Introduce a delay before capturing visualizations in reporting
chrisdavies Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion x-pack/plugins/reporting/export_types/printable_pdf/server/lib/screenshots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,13 @@ export function screenshotsObservableFactory(server) {
}
}

return Promise.all(renderedTasks);
// The renderComplete fires before the visualizations are in the DOM, so
// we wait for the event loop to flush before telling reporting to continue. This
// seems to correct a timing issue that was causing reporting to occasionally
// capture the first visualization before it was actually in the DOM.
const hackyWaitForVisualizations = () => new Promise(r => setTimeout(r, 100));

return Promise.all(renderedTasks).then(hackyWaitForVisualizations);
},
args: [layout.selectors.renderComplete, captureConfig.loadDelay],
awaitPromise: true,
Expand Down