[APM][ML] Limit environment name length when creating ML job#225973
Merged
miloszmarcinkowski merged 5 commits intoelastic:mainfrom Jul 2, 2025
Conversation
botelastic
bot
added
the
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
…vironments-with-long-names
jennypavlova
approved these changes
Jul 1, 2025
Member
jennypavlova
left a comment
jennypavlova
left a comment
There was a problem hiding this comment.
Code LGTM 🚀
Just a side note: It would be nice to "tell" the user about this limitation - adding to the text or an i icon next to the environment with a popup would be nice:
Or at least mention that the name will be "trimmed" 🤔 I am not sure if it will be useful, wdyt?
| const anomalyDetectionJob = mlClient.modules.setup({ | ||
| moduleId: ML_MODULE_ID_APM_TRANSACTION, | ||
| prefix: `${APM_ML_JOB_GROUP}-${snakeCase(environment)}-${randomToken}-`, | ||
| prefix: `${APM_ML_JOB_GROUP}-${sanitizedEnv}-${randomToken}-`, |
Member
There was a problem hiding this comment.
NIT: You can spell out environment here and in the constants, I see that in the other places in the file is spelled out (for consistency, not a blocker)
Contributor
Author
There was a problem hiding this comment.
Agree, updated!
Contributor
Author
Thanks for review! I wouldn't bother users about the limitation since it doesn't really affect them. They can still see a full environment name in either APM Settings or ML panel. 
|
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16022868291 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
…#225973) Closes elastic#225627 Limit environment name when creating ML job due to 64 characters constraint. Otherwise, ML job fails when creating from APM settings. (cherry picked from commit b289a29)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
…#225973) Closes elastic#225627 Limit environment name when creating ML job due to 64 characters constraint. Otherwise, ML job fails when creating from APM settings. (cherry picked from commit b289a29)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
…#225973) Closes elastic#225627 Limit environment name when creating ML job due to 64 characters constraint. Otherwise, ML job fails when creating from APM settings. (cherry picked from commit b289a29)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
…#225973) Closes elastic#225627 Limit environment name when creating ML job due to 64 characters constraint. Otherwise, ML job fails when creating from APM settings. (cherry picked from commit b289a29)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…225973) (#226150) # Backport This will backport the following commits from `main` to `8.18`: - [[APM][ML] Limit environment name length when creating ML job (#225973)](#225973) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T10:38:04Z","message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM][ML] Limit environment name length when creating ML job","number":225973,"url":"https://github.com/elastic/kibana/pull/225973","mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225973","number":225973,"mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…225973) (#226148) # Backport This will backport the following commits from `main` to `8.17`: - [[APM][ML] Limit environment name length when creating ML job (#225973)](#225973) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T10:38:04Z","message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM][ML] Limit environment name length when creating ML job","number":225973,"url":"https://github.com/elastic/kibana/pull/225973","mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225973","number":225973,"mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…225973) (#226153) # Backport This will backport the following commits from `main` to `9.1`: - [[APM][ML] Limit environment name length when creating ML job (#225973)](#225973) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T10:38:04Z","message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM][ML] Limit environment name length when creating ML job","number":225973,"url":"https://github.com/elastic/kibana/pull/225973","mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225973","number":225973,"mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…225973) (#226151) # Backport This will backport the following commits from `main` to `8.19`: - [[APM][ML] Limit environment name length when creating ML job (#225973)](#225973) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T10:38:04Z","message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","backport:prev-major","Team:obs-ux-infra_services","v9.2.0"],"title":"[APM][ML] Limit environment name length when creating ML job","number":225973,"url":"https://github.com/elastic/kibana/pull/225973","mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225973","number":225973,"mergeCommit":{"message":"[APM][ML] Limit environment name length when creating ML job (#225973)\n\nCloses #225627\n\nLimit environment name when creating ML job due to 64 characters\nconstraint. Otherwise, ML job fails when creating from APM settings.","sha":"b289a29ea0e46b8ecc45e9d05e2e65d3e4725c03"}}]}] BACKPORT--> Co-authored-by: Milosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…#225973) Closes elastic#225627 Limit environment name when creating ML job due to 64 characters constraint. Otherwise, ML job fails when creating from APM settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225627
Limit environment name when creating ML job due to 64 characters constraint. Otherwise, ML job fails when creating from APM settings.