[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail#225940
Merged
andrew-goldstein merged 4 commits intoelastic:mainfrom Jul 2, 2025
Conversation
andrew-goldstein
added
release_note:skip
andrew-goldstein
added
Team:Security Generative AI
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
approved these changes
Jul 1, 2025
Contributor
e40pud
left a comment
e40pud
left a comment
There was a problem hiding this comment.
Thank you for the fix! Tested locally - everything works. LGTM
andrew-goldstein
force-pushed
the
attack_discovery_get_error_toasts
branch
from
c759390 to
c0a31e3
Compare
…s` and `useGetAttackDiscoveryGenerations` fail This PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results. The error toasts are illustrated by the screenshots below:  _Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_  _Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_ ### Feature flags The following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters: ```yaml feature_flags.overrides: securitySolution.attackDiscoveryAlertsEnabled: true ```
andrew-goldstein
force-pushed
the
attack_discovery_get_error_toasts
branch
from
7b8dfcc to
14ed128
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16034534122 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
…d useGetAttackDiscoveryGenerations fail (elastic#225940) ## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail This PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results. The error toasts are illustrated by the screenshots below:  _Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_  _Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_ ### Feature flags The following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters: ```yaml feature_flags.overrides: securitySolution.attackDiscoveryAlertsEnabled: true ``` (cherry picked from commit db33a3f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
…d useGetAttackDiscoveryGenerations fail (elastic#225940) ## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail This PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results. The error toasts are illustrated by the screenshots below:  _Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_  _Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_ ### Feature flags The following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters: ```yaml feature_flags.overrides: securitySolution.attackDiscoveryAlertsEnabled: true ``` (cherry picked from commit db33a3f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…ies and useGetAttackDiscoveryGenerations fail (#225940) (#226302) # Backport This will backport the following commits from `main` to `9.1`: - [[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)](#225940) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T19:57:02Z","message":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)\n\n## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail\n\nThis PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results.\n\nThe error toasts are illustrated by the screenshots below:\n\n\n\n_Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_\n\n\n\n_Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_\n\n### Feature flags\n\nThe following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters:\n\n```yaml\nfeature_flags.overrides:\n securitySolution.attackDiscoveryAlertsEnabled: true\n```","sha":"db33a3faadb6cd2e08e7faf05581d7e69542996e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail","number":225940,"url":"https://github.com/elastic/kibana/pull/225940","mergeCommit":{"message":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)\n\n## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail\n\nThis PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results.\n\nThe error toasts are illustrated by the screenshots below:\n\n\n\n_Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_\n\n\n\n_Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_\n\n### Feature flags\n\nThe following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters:\n\n```yaml\nfeature_flags.overrides:\n securitySolution.attackDiscoveryAlertsEnabled: true\n```","sha":"db33a3faadb6cd2e08e7faf05581d7e69542996e"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225940","number":225940,"mergeCommit":{"message":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)\n\n## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail\n\nThis PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results.\n\nThe error toasts are illustrated by the screenshots below:\n\n\n\n_Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_\n\n\n\n_Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_\n\n### Feature flags\n\nThe following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters:\n\n```yaml\nfeature_flags.overrides:\n securitySolution.attackDiscoveryAlertsEnabled: true\n```","sha":"db33a3faadb6cd2e08e7faf05581d7e69542996e"}}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
…ries and useGetAttackDiscoveryGenerations fail (#225940) (#226301) # Backport This will backport the following commits from `main` to `8.19`: - [[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)](#225940) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"andrew.macri@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T19:57:02Z","message":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)\n\n## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail\n\nThis PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results.\n\nThe error toasts are illustrated by the screenshots below:\n\n\n\n_Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_\n\n\n\n_Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_\n\n### Feature flags\n\nThe following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters:\n\n```yaml\nfeature_flags.overrides:\n securitySolution.attackDiscoveryAlertsEnabled: true\n```","sha":"db33a3faadb6cd2e08e7faf05581d7e69542996e","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail","number":225940,"url":"https://github.com/elastic/kibana/pull/225940","mergeCommit":{"message":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)\n\n## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail\n\nThis PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results.\n\nThe error toasts are illustrated by the screenshots below:\n\n\n\n_Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_\n\n\n\n_Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_\n\n### Feature flags\n\nThe following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters:\n\n```yaml\nfeature_flags.overrides:\n securitySolution.attackDiscoveryAlertsEnabled: true\n```","sha":"db33a3faadb6cd2e08e7faf05581d7e69542996e"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225940","number":225940,"mergeCommit":{"message":"[Attack discovery] Show error toasts when useFindAttackDiscoveries and useGetAttackDiscoveryGenerations fail (#225940)\n\n## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail\n\nThis PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results.\n\nThe error toasts are illustrated by the screenshots below:\n\n\n\n_Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_\n\n\n\n_Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_\n\n### Feature flags\n\nThe following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters:\n\n```yaml\nfeature_flags.overrides:\n securitySolution.attackDiscoveryAlertsEnabled: true\n```","sha":"db33a3faadb6cd2e08e7faf05581d7e69542996e"}}]}] BACKPORT--> Co-authored-by: Andrew Macri <andrew.macri@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…d useGetAttackDiscoveryGenerations fail (elastic#225940) ## [Attack discovery] Show error toasts when `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` fail This PR fixes an issue where the Attack discovery page should display error toasts when the `useFindAttackDiscoveries` and `useGetAttackDiscoveryGenerations` hooks fail to retrieve results. The error toasts are illustrated by the screenshots below:  _Above: An error toaster is displayed when `useFindAttackDiscoveries` fails_  _Above: An error toaster is displayed when `useGetAttackDiscoveryGenerations` fails_ ### Feature flags The following `securitySolution.attackDiscoveryAlertsEnabled` feature flag in `config/kibana.dev.yml` is required to view the error toasters: ```yaml feature_flags.overrides: securitySolution.attackDiscoveryAlertsEnabled: true ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Attack discovery] Show error toasts when
useFindAttackDiscoveriesanduseGetAttackDiscoveryGenerationsfailThis PR fixes an issue where the Attack discovery page should display error toasts when the
useFindAttackDiscoveriesanduseGetAttackDiscoveryGenerationshooks fail to retrieve results.The error toasts are illustrated by the screenshots below:
Above: An error toaster is displayed when
useFindAttackDiscoveriesfailsAbove: An error toaster is displayed when
useGetAttackDiscoveryGenerationsfailsFeature flags
The following
securitySolution.attackDiscoveryAlertsEnabledfeature flag inconfig/kibana.dev.ymlis required to view the error toasters: