[Detection Engine][Telemetry] Update test#225937
Merged
yctercero merged 2 commits intoelastic:mainfrom Jul 2, 2025
Merged
Conversation
…s dont clean up the same as in other envs
yctercero
added
release_note:skip
Contributor
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Contributor
💚 Build Succeeded
Metrics [docs]
cc @yctercero |
dhurley14
approved these changes
Jul 2, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1 https://github.com/elastic/kibana/actions/runs/16027465873 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
## Summary Updated a test to check that the value of `has_exceptions` is greater than 0 instead of checking for `1` specifically. Found that in MKI alone, the prebuilt rules utilities don't seem to clean up. Prebuilt rule installation gets called 8 times in these tests, each time installing one rule with exceptions. Then in my test I add an exception to one of the prebuilt rules without exceptions so it shows a total of `has_exceptions: 9`. (cherry picked from commit e974006)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
## Summary Updated a test to check that the value of `has_exceptions` is greater than 0 instead of checking for `1` specifically. Found that in MKI alone, the prebuilt rules utilities don't seem to clean up. Prebuilt rule installation gets called 8 times in these tests, each time installing one rule with exceptions. Then in my test I add an exception to one of the prebuilt rules without exceptions so it shows a total of `has_exceptions: 9`. (cherry picked from commit e974006)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[Detection Engine][Telemetry] Update test (#225937)](#225937) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T14:09:37Z","message":"[Detection Engine][Telemetry] Update test (#225937)\n\n## Summary\n\nUpdated a test to check that the value of `has_exceptions` is greater\nthan 0 instead of checking for `1` specifically. Found that in MKI\nalone, the prebuilt rules utilities don't seem to clean up. Prebuilt\nrule installation gets called 8 times in these tests, each time\ninstalling one rule with exceptions. Then in my test I add an exception\nto one of the prebuilt rules without exceptions so it shows a total of\n`has_exceptions: 9`.","sha":"e974006285c9bd43c20d55007631eb662398a120","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detection Engine","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Detection Engine][Telemetry] Update test","number":225937,"url":"https://github.com/elastic/kibana/pull/225937","mergeCommit":{"message":"[Detection Engine][Telemetry] Update test (#225937)\n\n## Summary\n\nUpdated a test to check that the value of `has_exceptions` is greater\nthan 0 instead of checking for `1` specifically. Found that in MKI\nalone, the prebuilt rules utilities don't seem to clean up. Prebuilt\nrule installation gets called 8 times in these tests, each time\ninstalling one rule with exceptions. Then in my test I add an exception\nto one of the prebuilt rules without exceptions so it shows a total of\n`has_exceptions: 9`.","sha":"e974006285c9bd43c20d55007631eb662398a120"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225937","number":225937,"mergeCommit":{"message":"[Detection Engine][Telemetry] Update test (#225937)\n\n## Summary\n\nUpdated a test to check that the value of `has_exceptions` is greater\nthan 0 instead of checking for `1` specifically. Found that in MKI\nalone, the prebuilt rules utilities don't seem to clean up. Prebuilt\nrule installation gets called 8 times in these tests, each time\ninstalling one rule with exceptions. Then in my test I add an exception\nto one of the prebuilt rules without exceptions so it shows a total of\n`has_exceptions: 9`.","sha":"e974006285c9bd43c20d55007631eb662398a120"}}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Detection Engine][Telemetry] Update test (#225937)](#225937) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T14:09:37Z","message":"[Detection Engine][Telemetry] Update test (#225937)\n\n## Summary\n\nUpdated a test to check that the value of `has_exceptions` is greater\nthan 0 instead of checking for `1` specifically. Found that in MKI\nalone, the prebuilt rules utilities don't seem to clean up. Prebuilt\nrule installation gets called 8 times in these tests, each time\ninstalling one rule with exceptions. Then in my test I add an exception\nto one of the prebuilt rules without exceptions so it shows a total of\n`has_exceptions: 9`.","sha":"e974006285c9bd43c20d55007631eb662398a120","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detection Engine","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Detection Engine][Telemetry] Update test","number":225937,"url":"https://github.com/elastic/kibana/pull/225937","mergeCommit":{"message":"[Detection Engine][Telemetry] Update test (#225937)\n\n## Summary\n\nUpdated a test to check that the value of `has_exceptions` is greater\nthan 0 instead of checking for `1` specifically. Found that in MKI\nalone, the prebuilt rules utilities don't seem to clean up. Prebuilt\nrule installation gets called 8 times in these tests, each time\ninstalling one rule with exceptions. Then in my test I add an exception\nto one of the prebuilt rules without exceptions so it shows a total of\n`has_exceptions: 9`.","sha":"e974006285c9bd43c20d55007631eb662398a120"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225937","number":225937,"mergeCommit":{"message":"[Detection Engine][Telemetry] Update test (#225937)\n\n## Summary\n\nUpdated a test to check that the value of `has_exceptions` is greater\nthan 0 instead of checking for `1` specifically. Found that in MKI\nalone, the prebuilt rules utilities don't seem to clean up. Prebuilt\nrule installation gets called 8 times in these tests, each time\ninstalling one rule with exceptions. Then in my test I add an exception\nto one of the prebuilt rules without exceptions so it shows a total of\n`has_exceptions: 9`.","sha":"e974006285c9bd43c20d55007631eb662398a120"}}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Updated a test to check that the value of `has_exceptions` is greater than 0 instead of checking for `1` specifically. Found that in MKI alone, the prebuilt rules utilities don't seem to clean up. Prebuilt rule installation gets called 8 times in these tests, each time installing one rule with exceptions. Then in my test I add an exception to one of the prebuilt rules without exceptions so it shows a total of `has_exceptions: 9`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated a test to check that the value of
has_exceptionsis greater than 0 instead of checking for1specifically. Found that in MKI alone, the prebuilt rules utilities don't seem to clean up. Prebuilt rule installation gets called 8 times in these tests, each time installing one rule with exceptions. Then in my test I add an exception to one of the prebuilt rules without exceptions so it shows a total ofhas_exceptions: 9.