Skip to content

[Cloud Security] fix misconfiguration and vulnerability flyout UI issues#225862

Merged
alexreal1314 merged 2 commits intomainfrom
225839-expandable-flyout-header-text-size
Jul 1, 2025
Merged

[Cloud Security] fix misconfiguration and vulnerability flyout UI issues#225862
alexreal1314 merged 2 commits intomainfrom
225839-expandable-flyout-header-text-size

Conversation

@alexreal1314
Copy link
Contributor

@alexreal1314 alexreal1314 commented Jun 30, 2025

Summary

This PR fixes the following issues:

  1. misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the design.
  2. fix 'About' section in misconfiguration tab - fix sub titles sizes and spacing, remove link icon from 'show rule details' text.
  3. fix Resource table rendering to handle properly package fields with array of single item - copy icon should be rendered in this case.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the design.

Screenshot

title and sub title fix
image

image

image

image

**vulnerability flyout - overview tab resource section fix **
image

misconfiguration flyout - about section spacing and font size issues fix
image

@alexreal1314 alexreal1314 requested review from a team as code owners June 30, 2025 15:12
@alexreal1314 alexreal1314 linked an issue Jun 30, 2025 that may be closed by this pull request
3 tasks
@alexreal1314 alexreal1314 changed the title [Cloud Security]fix expandable flyout title and sub title size [Cloud Security] fix expandable flyout title and sub title size Jun 30, 2025
@alexreal1314 alexreal1314 added backport:current-major release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related and removed backport:current-major labels Jun 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@alexreal1314 alexreal1314 self-assigned this Jun 30, 2025
@alexreal1314 alexreal1314 added backport:version Backport to applied version labels 9.1 candidate v9.1.0 and removed 9.1 candidate labels Jun 30, 2025
@alexreal1314 alexreal1314 requested a review from Copilot June 30, 2025 19:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aligns the font sizes of the expandable flyout’s vulnerability title and CVE subtitle with the Figma design.

  • Main flyout title size bumped from small to medium.
  • Vulnerability ID header size changed from medium to small and styling updated to use theme values.
  • Link styling refactored to a flex container using css and theme-based dimensions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
x-pack/solutions/security/plugins/security_solution/public/flyout/shared/components/flyout_title.tsx Updated <EuiTitle> size from "s" to "m" for the main flyout title
x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx Changed <EuiTitle> size to "s", swapped hardcoded CSS for theme values, and refactored link/container styling
Comments suppressed due to low confidence (1)

x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx:106

  • There's a mismatched JSX tag here: a closing without a corresponding opening in this branch. Ensure the vulnerability ID remains wrapped correctly and that all JSX tags are properly paired.
          </EuiLink>

@alexreal1314 alexreal1314 force-pushed the 225839-expandable-flyout-header-text-size branch from 581a8e2 to 23293d5 Compare July 1, 2025 09:26
const titleComponent = useMemo(() => {
return (
<EuiTitle size="s" data-test-subj={`${dataTestSubj}Text`}>
<EuiTitle size="m" data-test-subj={`${dataTestSubj}Text`}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to make this change like so. The FlyoutTitle component is indeed shared between all the flyout (AI4DSOC, event and alert, host, user, network...) and we haven't received a request to make this title bigger.

2 options:

  • could we go back to UIUX and make sure that they really want a bigger text? I'm asking because for very long texts, the header now takes even more vertical space...
  • if the cloud security team wants this, I'd suggest making the title size a optional property, that we'd default to s to not change the behavior on any other flyout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhilippeOberti Hi, yes I know it is used by different flyouts, the design does look like it supposed to be medium size but I removed this for now, once we are done with the QA cycle i'll recheck it again as its not that critical.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks! I dismissed my Request changes review to unblock the PR :)

…yout

fix resource section UI in the vulnerability expandable flyout
@alexreal1314 alexreal1314 force-pushed the 225839-expandable-flyout-header-text-size branch from 23293d5 to 634d169 Compare July 1, 2025 10:26
@PhilippeOberti PhilippeOberti dismissed their stale review July 1, 2025 10:29

The changes to the file owned by the Threat Hunting Investigations team were reverted.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 556.3KB 557.0KB +680.0B

History

cc @alexreal1314

@alexreal1314 alexreal1314 merged commit 790848d into main Jul 1, 2025
10 checks passed
@alexreal1314 alexreal1314 deleted the 225839-expandable-flyout-header-text-size branch July 1, 2025 13:52
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16001311086

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16001317358

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 1, 2025
…tic#225862)

## Summary
This PR fixes the following issues:

1. misconfiguration and vulnerability expandable flyout title and sub
title font size should be as specified in the
[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).
2. fix 'About' section in misconfiguration tab - fix sub titles sizes
and spacing, remove link icon from 'show rule details' text.
3. fix Resource table rendering to handle properly package fields with
array of single item - copy icon should be rendered in this case.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] misconfiguration and vulnerability expandable flyout title and sub
title font size should be as specified in the
[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).

### Screenshot

**title and sub title fix**

![image](https://github.com/user-attachments/assets/ccb9e56a-2720-42e6-9903-f043fd8ba701)

![image](https://github.com/user-attachments/assets/adf09a47-2392-44e1-a15b-becce2b3a83e)

![image](https://github.com/user-attachments/assets/b28108e9-e624-47da-b1c2-e3322b8c97f1)

![image](https://github.com/user-attachments/assets/b8ddea87-7e3d-4127-b59f-a845f3528c9c)

**vulnerability flyout - overview tab resource section fix **

![image](https://github.com/user-attachments/assets/15a1a63b-f358-460d-99cc-7519f7d512f4)

**misconfiguration flyout - about section spacing and font size issues
fix**

![image](https://github.com/user-attachments/assets/fa91badf-4ba4-43c1-82cb-15177cf5fe34)

(cherry picked from commit 790848d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 1, 2025
…tic#225862)

## Summary
This PR fixes the following issues:

1. misconfiguration and vulnerability expandable flyout title and sub
title font size should be as specified in the
[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).
2. fix 'About' section in misconfiguration tab - fix sub titles sizes
and spacing, remove link icon from 'show rule details' text.
3. fix Resource table rendering to handle properly package fields with
array of single item - copy icon should be rendered in this case.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] misconfiguration and vulnerability expandable flyout title and sub
title font size should be as specified in the
[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).

### Screenshot

**title and sub title fix**

![image](https://github.com/user-attachments/assets/ccb9e56a-2720-42e6-9903-f043fd8ba701)

![image](https://github.com/user-attachments/assets/adf09a47-2392-44e1-a15b-becce2b3a83e)

![image](https://github.com/user-attachments/assets/b28108e9-e624-47da-b1c2-e3322b8c97f1)

![image](https://github.com/user-attachments/assets/b8ddea87-7e3d-4127-b59f-a845f3528c9c)

**vulnerability flyout - overview tab resource section fix **

![image](https://github.com/user-attachments/assets/15a1a63b-f358-460d-99cc-7519f7d512f4)

**misconfiguration flyout - about section spacing and font size issues
fix**

![image](https://github.com/user-attachments/assets/fa91badf-4ba4-43c1-82cb-15177cf5fe34)

(cherry picked from commit 790848d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@alexreal1314 alexreal1314 changed the title [Cloud Security] fix expandable flyout title and sub title size [Cloud Security] fix expandable flyout UI issues Jul 1, 2025
@alexreal1314 alexreal1314 changed the title [Cloud Security] fix expandable flyout UI issues [Cloud Security] fix misconfiguration and vulnerability flyout UI issues Jul 1, 2025
kibanamachine added a commit that referenced this pull request Jul 1, 2025
…#225862) (#226012)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Cloud Security] fix expandable flyout title and sub title size
(#225862)](#225862)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alex
Prozorov","email":"alex.prozorov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-01T13:52:03Z","message":"[Cloud
Security] fix expandable flyout title and sub title size (#225862)\n\n##
Summary\nThis PR fixes the following issues:\n\n1. misconfiguration and
vulnerability expandable flyout title and sub\ntitle font size should be
as specified in
the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n2.
fix 'About' section in misconfiguration tab - fix sub titles sizes\nand
spacing, remove link icon from 'show rule details' text.\n3. fix
Resource table rendering to handle properly package fields with\narray
of single item - copy icon should be rendered in this case.\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ]
misconfiguration and vulnerability expandable flyout title and
sub\ntitle font size should be as specified in
the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n\n###
Screenshot\n\n**title and sub title
fix**\n\n![image](https://github.com/user-attachments/assets/ccb9e56a-2720-42e6-9903-f043fd8ba701)\n\n\n![image](https://github.com/user-attachments/assets/adf09a47-2392-44e1-a15b-becce2b3a83e)\n\n\n![image](https://github.com/user-attachments/assets/b28108e9-e624-47da-b1c2-e3322b8c97f1)\n\n\n![image](https://github.com/user-attachments/assets/b8ddea87-7e3d-4127-b59f-a845f3528c9c)\n\n**vulnerability
flyout - overview tab resource section fix
**\n\n![image](https://github.com/user-attachments/assets/15a1a63b-f358-460d-99cc-7519f7d512f4)\n\n**misconfiguration
flyout - about section spacing and font size
issues\nfix**\n\n![image](https://github.com/user-attachments/assets/fa91badf-4ba4-43c1-82cb-15177cf5fe34)","sha":"790848dac3e807da1c8a7199e4e9301837f8e4c9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:version","v9.1.0","v9.2.0"],"title":"[Cloud
Security] fix expandable flyout title and sub title
size","number":225862,"url":"https://github.com/elastic/kibana/pull/225862","mergeCommit":{"message":"[Cloud
Security] fix expandable flyout title and sub title size (#225862)\n\n##
Summary\nThis PR fixes the following issues:\n\n1. misconfiguration and
vulnerability expandable flyout title and sub\ntitle font size should be
as specified in
the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n2.
fix 'About' section in misconfiguration tab - fix sub titles sizes\nand
spacing, remove link icon from 'show rule details' text.\n3. fix
Resource table rendering to handle properly package fields with\narray
of single item - copy icon should be rendered in this case.\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ]
misconfiguration and vulnerability expandable flyout title and
sub\ntitle font size should be as specified in
the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n\n###
Screenshot\n\n**title and sub title
fix**\n\n![image](https://github.com/user-attachments/assets/ccb9e56a-2720-42e6-9903-f043fd8ba701)\n\n\n![image](https://github.com/user-attachments/assets/adf09a47-2392-44e1-a15b-becce2b3a83e)\n\n\n![image](https://github.com/user-attachments/assets/b28108e9-e624-47da-b1c2-e3322b8c97f1)\n\n\n![image](https://github.com/user-attachments/assets/b8ddea87-7e3d-4127-b59f-a845f3528c9c)\n\n**vulnerability
flyout - overview tab resource section fix
**\n\n![image](https://github.com/user-attachments/assets/15a1a63b-f358-460d-99cc-7519f7d512f4)\n\n**misconfiguration
flyout - about section spacing and font size
issues\nfix**\n\n![image](https://github.com/user-attachments/assets/fa91badf-4ba4-43c1-82cb-15177cf5fe34)","sha":"790848dac3e807da1c8a7199e4e9301837f8e4c9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225862","number":225862,"mergeCommit":{"message":"[Cloud
Security] fix expandable flyout title and sub title size (#225862)\n\n##
Summary\nThis PR fixes the following issues:\n\n1. misconfiguration and
vulnerability expandable flyout title and sub\ntitle font size should be
as specified in
the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n2.
fix 'About' section in misconfiguration tab - fix sub titles sizes\nand
spacing, remove link icon from 'show rule details' text.\n3. fix
Resource table rendering to handle properly package fields with\narray
of single item - copy icon should be rendered in this case.\n\n\n\n\n###
Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers
should verify this PR satisfies this list as well.\n\n- [ ]
misconfiguration and vulnerability expandable flyout title and
sub\ntitle font size should be as specified in
the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n\n###
Screenshot\n\n**title and sub title
fix**\n\n![image](https://github.com/user-attachments/assets/ccb9e56a-2720-42e6-9903-f043fd8ba701)\n\n\n![image](https://github.com/user-attachments/assets/adf09a47-2392-44e1-a15b-becce2b3a83e)\n\n\n![image](https://github.com/user-attachments/assets/b28108e9-e624-47da-b1c2-e3322b8c97f1)\n\n\n![image](https://github.com/user-attachments/assets/b8ddea87-7e3d-4127-b59f-a845f3528c9c)\n\n**vulnerability
flyout - overview tab resource section fix
**\n\n![image](https://github.com/user-attachments/assets/15a1a63b-f358-460d-99cc-7519f7d512f4)\n\n**misconfiguration
flyout - about section spacing and font size
issues\nfix**\n\n![image](https://github.com/user-attachments/assets/fa91badf-4ba4-43c1-82cb-15177cf5fe34)","sha":"790848dac3e807da1c8a7199e4e9301837f8e4c9"}}]}]
BACKPORT-->

Co-authored-by: Alex Prozorov <alex.prozorov@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…tic#225862)

## Summary
This PR fixes the following issues:

1. misconfiguration and vulnerability expandable flyout title and sub
title font size should be as specified in the
[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).
2. fix 'About' section in misconfiguration tab - fix sub titles sizes
and spacing, remove link icon from 'show rule details' text.
3. fix Resource table rendering to handle properly package fields with
array of single item - copy icon should be rendered in this case.




### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] misconfiguration and vulnerability expandable flyout title and sub
title font size should be as specified in the
[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).

### Screenshot

**title and sub title fix**

![image](https://github.com/user-attachments/assets/ccb9e56a-2720-42e6-9903-f043fd8ba701)


![image](https://github.com/user-attachments/assets/adf09a47-2392-44e1-a15b-becce2b3a83e)


![image](https://github.com/user-attachments/assets/b28108e9-e624-47da-b1c2-e3322b8c97f1)


![image](https://github.com/user-attachments/assets/b8ddea87-7e3d-4127-b59f-a845f3528c9c)

**vulnerability flyout - overview tab resource section fix **

![image](https://github.com/user-attachments/assets/15a1a63b-f358-460d-99cc-7519f7d512f4)

**misconfiguration flyout - about section spacing and font size issues
fix**

![image](https://github.com/user-attachments/assets/fa91badf-4ba4-43c1-82cb-15177cf5fe34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cloud Security] misconfiguration and vulnerability flyout UI issues

6 participants