[Cloud Security] fix misconfiguration and vulnerability flyout UI issues#225862
[Cloud Security] fix misconfiguration and vulnerability flyout UI issues#225862alexreal1314 merged 2 commits intomainfrom
Conversation
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the font sizes of the expandable flyout’s vulnerability title and CVE subtitle with the Figma design.
- Main flyout title size bumped from small to medium.
- Vulnerability ID header size changed from medium to small and styling updated to use theme values.
- Link styling refactored to a flex container using
cssand theme-based dimensions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x-pack/solutions/security/plugins/security_solution/public/flyout/shared/components/flyout_title.tsx | Updated <EuiTitle> size from "s" to "m" for the main flyout title |
| x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx | Changed <EuiTitle> size to "s", swapped hardcoded CSS for theme values, and refactored link/container styling |
Comments suppressed due to low confidence (1)
x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx:106
- There's a mismatched JSX tag here: a closing without a corresponding opening in this branch. Ensure the vulnerability ID remains wrapped correctly and that all JSX tags are properly paired.
</EuiLink>
581a8e2 to
23293d5
Compare
| const titleComponent = useMemo(() => { | ||
| return ( | ||
| <EuiTitle size="s" data-test-subj={`${dataTestSubj}Text`}> | ||
| <EuiTitle size="m" data-test-subj={`${dataTestSubj}Text`}> |
There was a problem hiding this comment.
I don't think we want to make this change like so. The FlyoutTitle component is indeed shared between all the flyout (AI4DSOC, event and alert, host, user, network...) and we haven't received a request to make this title bigger.
2 options:
- could we go back to UIUX and make sure that they really want a bigger text? I'm asking because for very long texts, the header now takes even more vertical space...
- if the cloud security team wants this, I'd suggest making the title size a optional property, that we'd default to
sto not change the behavior on any other flyout
There was a problem hiding this comment.
@PhilippeOberti Hi, yes I know it is used by different flyouts, the design does look like it supposed to be medium size but I removed this for now, once we are done with the QA cycle i'll recheck it again as its not that critical.
There was a problem hiding this comment.
Ok, thanks! I dismissed my Request changes review to unblock the PR :)
…yout fix resource section UI in the vulnerability expandable flyout
23293d5 to
634d169
Compare
The changes to the file owned by the Threat Hunting Investigations team were reverted.
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16001311086 |
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16001317358 |
…tic#225862) ## Summary This PR fixes the following issues: 1. misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the [design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev). 2. fix 'About' section in misconfiguration tab - fix sub titles sizes and spacing, remove link icon from 'show rule details' text. 3. fix Resource table rendering to handle properly package fields with array of single item - copy icon should be rendered in this case. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the [design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev). ### Screenshot **title and sub title fix**     **vulnerability flyout - overview tab resource section fix **  **misconfiguration flyout - about section spacing and font size issues fix**  (cherry picked from commit 790848d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…tic#225862) ## Summary This PR fixes the following issues: 1. misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the [design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev). 2. fix 'About' section in misconfiguration tab - fix sub titles sizes and spacing, remove link icon from 'show rule details' text. 3. fix Resource table rendering to handle properly package fields with array of single item - copy icon should be rendered in this case. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the [design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev). ### Screenshot **title and sub title fix**     **vulnerability flyout - overview tab resource section fix **  **misconfiguration flyout - about section spacing and font size issues fix**  (cherry picked from commit 790848d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#225862) (#226012) # Backport This will backport the following commits from `main` to `9.1`: - [[Cloud Security] fix expandable flyout title and sub title size (#225862)](#225862) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Prozorov","email":"alex.prozorov@elastic.co"},"sourceCommit":{"committedDate":"2025-07-01T13:52:03Z","message":"[Cloud Security] fix expandable flyout title and sub title size (#225862)\n\n## Summary\nThis PR fixes the following issues:\n\n1. misconfiguration and vulnerability expandable flyout title and sub\ntitle font size should be as specified in the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n2. fix 'About' section in misconfiguration tab - fix sub titles sizes\nand spacing, remove link icon from 'show rule details' text.\n3. fix Resource table rendering to handle properly package fields with\narray of single item - copy icon should be rendered in this case.\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] misconfiguration and vulnerability expandable flyout title and sub\ntitle font size should be as specified in the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n\n### Screenshot\n\n**title and sub title fix**\n\n\n\n\n\n\n\n\n\n\n\n\n**vulnerability flyout - overview tab resource section fix **\n\n\n\n**misconfiguration flyout - about section spacing and font size issues\nfix**\n\n","sha":"790848dac3e807da1c8a7199e4e9301837f8e4c9","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:version","v9.1.0","v9.2.0"],"title":"[Cloud Security] fix expandable flyout title and sub title size","number":225862,"url":"https://github.com/elastic/kibana/pull/225862","mergeCommit":{"message":"[Cloud Security] fix expandable flyout title and sub title size (#225862)\n\n## Summary\nThis PR fixes the following issues:\n\n1. misconfiguration and vulnerability expandable flyout title and sub\ntitle font size should be as specified in the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n2. fix 'About' section in misconfiguration tab - fix sub titles sizes\nand spacing, remove link icon from 'show rule details' text.\n3. fix Resource table rendering to handle properly package fields with\narray of single item - copy icon should be rendered in this case.\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] misconfiguration and vulnerability expandable flyout title and sub\ntitle font size should be as specified in the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n\n### Screenshot\n\n**title and sub title fix**\n\n\n\n\n\n\n\n\n\n\n\n\n**vulnerability flyout - overview tab resource section fix **\n\n\n\n**misconfiguration flyout - about section spacing and font size issues\nfix**\n\n","sha":"790848dac3e807da1c8a7199e4e9301837f8e4c9"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225862","number":225862,"mergeCommit":{"message":"[Cloud Security] fix expandable flyout title and sub title size (#225862)\n\n## Summary\nThis PR fixes the following issues:\n\n1. misconfiguration and vulnerability expandable flyout title and sub\ntitle font size should be as specified in the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n2. fix 'About' section in misconfiguration tab - fix sub titles sizes\nand spacing, remove link icon from 'show rule details' text.\n3. fix Resource table rendering to handle properly package fields with\narray of single item - copy icon should be rendered in this case.\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] misconfiguration and vulnerability expandable flyout title and sub\ntitle font size should be as specified in the\n[design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev).\n\n### Screenshot\n\n**title and sub title fix**\n\n\n\n\n\n\n\n\n\n\n\n\n**vulnerability flyout - overview tab resource section fix **\n\n\n\n**misconfiguration flyout - about section spacing and font size issues\nfix**\n\n","sha":"790848dac3e807da1c8a7199e4e9301837f8e4c9"}}]}] BACKPORT--> Co-authored-by: Alex Prozorov <alex.prozorov@elastic.co>
…tic#225862) ## Summary This PR fixes the following issues: 1. misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the [design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev). 2. fix 'About' section in misconfiguration tab - fix sub titles sizes and spacing, remove link icon from 'show rule details' text. 3. fix Resource table rendering to handle properly package fields with array of single item - copy icon should be rendered in this case. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] misconfiguration and vulnerability expandable flyout title and sub title font size should be as specified in the [design](https://www.figma.com/design/MimidTyvcOa19Xq9IzrbaS/Expandable-Flyout---Findings?node-id=989-178616&m=dev). ### Screenshot **title and sub title fix**     **vulnerability flyout - overview tab resource section fix **  **misconfiguration flyout - about section spacing and font size issues fix** 
Summary
This PR fixes the following issues:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Screenshot
title and sub title fix

**vulnerability flyout - overview tab resource section fix **

misconfiguration flyout - about section spacing and font size issues fix
