Skip to content

Comments

[9.1] [Discover][Traces][Waterfall] Update isSpan logic to work properly with APM data (#225602)#225769

Merged
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-225602
Jun 30, 2025
Merged

[9.1] [Discover][Traces][Waterfall] Update isSpan logic to work properly with APM data (#225602)#225769
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-225602

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…th APM data (elastic#225602)

## Summary

Relates to elastic#214795

This simplifies the logic used to determine whether a document is a span
or a transaction in the waterfall view, aligning it with the [changes we
recently made in the profile enablement
logic](elastic@2e02c0c).

It also fixes an issue when checking for APM data: we were comparing an
array (returned by ES) with a string, which caused APM spans and
transactions to always be treated as transactions.

||Before|After|
|-|-|-|
|APM|❌![Screenshot 2025-06-27 at 11 03
28](https://github.com/user-attachments/assets/26c0bbd0-23ef-468c-b6b8-7dc5a3fdc574)|✅![Screenshot
2025-06-27 at 11 01
53](https://github.com/user-attachments/assets/0061bf7b-0670-473e-b758-b2dde1f83ade)|
|Processed OTel|✅![Screenshot 2025-06-27 at 11 13
40](https://github.com/user-attachments/assets/7c549089-7f5f-461f-8f16-ca7dbd2868f8)|✅![Screenshot
2025-06-27 at 11 15
38](https://github.com/user-attachments/assets/d84e8d7b-a1ef-45e5-9053-c6fb0430f6f0)|
|Non-processed OTel|✅![Screenshot 2025-06-27 at 11 47
13](https://github.com/user-attachments/assets/a8d60afa-0fcf-4964-bf02-392a08aa069b)|✅![Screenshot
2025-06-27 at 11 46
05](https://github.com/user-attachments/assets/82a0100c-2f1a-4ce4-90c6-5cb5cfc26bd1)|

(cherry picked from commit 7e58bfc)
@kibanamachine kibanamachine force-pushed the backport/9.1/pr-225602 branch from 66e480e to 96af74a Compare June 30, 2025 08:44
@kibanamachine kibanamachine merged commit eb3b7fc into elastic:9.1 Jun 30, 2025
10 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedDocViewer 222.8KB 222.8KB -13.0B

cc @iblancof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants