Skip to content

Fix react vis type documentation#22573

Merged
timroes merged 1 commit intoelastic:masterfrom
timroes:fix-react-vis-doc
Sep 5, 2018
Merged

Fix react vis type documentation#22573
timroes merged 1 commit intoelastic:masterfrom
timroes:fix-react-vis-doc

Conversation

@timroes
Copy link
Copy Markdown
Contributor

@timroes timroes commented Aug 31, 2018

Fix the React vis type documentation. The component key was wrongly named template in the documentation.

@timroes timroes added Team:Docs Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 v6.4.0 v6.5.0 labels Aug 31, 2018
@timroes timroes requested review from markov00 and ppisljar August 31, 2018 07:04
Copy link
Copy Markdown
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes
Copy link
Copy Markdown
Contributor Author

timroes commented Sep 4, 2018

Jenkins, test this

@timroes timroes added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed v6.4.0 labels Sep 4, 2018
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@timroes
Copy link
Copy Markdown
Contributor Author

timroes commented Sep 4, 2018

Jenkins, test this - flaky reporting test I think

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@timroes
Copy link
Copy Markdown
Contributor Author

timroes commented Sep 4, 2018

Jenkins, test this - another flaky ES build

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@timroes timroes merged commit 9c01863 into elastic:master Sep 5, 2018
@timroes timroes added v6.4.0 and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Sep 5, 2018
@timroes timroes deleted the fix-react-vis-doc branch September 5, 2018 07:35
timroes added a commit to timroes/kibana that referenced this pull request Sep 5, 2018
timroes added a commit to timroes/kibana that referenced this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Docs v6.4.0 v6.5.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants