[Cloud Security] Refactor hard coded Findings filter fields in CSPM benchmark dashboard's#225692
Merged
seanrathier merged 3 commits intoelastic:mainfrom Jul 11, 2025
Merged
Conversation
seanrathier
added
Team:Cloud Security
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
seanrathier
added
ci:project-deploy-security
seanrathier
force-pushed
the
remove-namespace-const
branch
from
f85ff4f to
6b26b38
Compare
seanrathier
force-pushed
the
remove-namespace-const
branch
from
62bd121 to
6f06493
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @seanrathier |
Contributor
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16227971594 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2025
…enchmark dashboard's (elastic#225692) (cherry picked from commit e8d9e52)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 11, 2025
…CSPM benchmark dashboard's (#225692) (#227706) # Backport This will backport the following commits from `main` to `9.1`: - [[Cloud Security] Refactor hard coded Findings filter fields in CSPM benchmark dashboard's (#225692)](#225692) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"sean.rathier@gmail.com"},"sourceCommit":{"committedDate":"2025-07-11T19:17:23Z","message":"[Cloud Security] Refactor hard coded Findings filter fields in CSPM benchmark dashboard's (#225692)","sha":"e8d9e525dd4c8dea82c80b242dd075c02914a2fd","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","ci:project-deploy-security","backport:version","v9.1.0","v9.2.0"],"title":"[Cloud Security] Refactor hard coded Findings filter fields in CSPM benchmark dashboard's","number":225692,"url":"https://github.com/elastic/kibana/pull/225692","mergeCommit":{"message":"[Cloud Security] Refactor hard coded Findings filter fields in CSPM benchmark dashboard's (#225692)","sha":"e8d9e525dd4c8dea82c80b242dd075c02914a2fd"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225692","number":225692,"mergeCommit":{"message":"[Cloud Security] Refactor hard coded Findings filter fields in CSPM benchmark dashboard's (#225692)","sha":"e8d9e525dd4c8dea82c80b242dd075c02914a2fd"}}]}] BACKPORT--> Co-authored-by: seanrathier <sean.rathier@gmail.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…enchmark dashboard's (elastic#225692)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new constant,
FINDINGS_FILTER_OPTIONS, to centralize filter keys used throughout the Cloud Security Posture plugin. The changes replace hardcoded filter keys with references to this constant across multiple components and tests, improving maintainability and consistency.Introduction of
FINDINGS_FILTER_OPTIONS:FINDINGS_FILTER_OPTIONStoconstants.tsto centralize filter keys such asCLOUD_PROVIDER,NAMESPACE,RULE_BENCHMARK_ID, and others. This ensures a single source of truth for filter key definitions.Refactoring in components:
AccountsEvaluatedWidgetto replace hardcoded filter keys withFINDINGS_FILTER_OPTIONSBenchmarksSectionto useFINDINGS_FILTER_OPTIONSSummarySectionto use `FINDINGS_FILTER_OPTIONSChecklist
backport:*labels.