[APM] Update Node.js onboarding instructions#22562
Merged
watson merged 2 commits intoelastic:masterfrom Sep 5, 2018
watson:apm-node
Merged
[APM] Update Node.js onboarding instructions#22562watson merged 2 commits intoelastic:masterfrom watson:apm-node
watson merged 2 commits intoelastic:masterfrom
watson:apm-node
Conversation
sorenlouv
approved these changes
Aug 30, 2018
Contributor
💚 Build Succeeded |
Qard
approved these changes
Aug 31, 2018
Contributor
Author
|
Is it possible to get this into the next release? |
Contributor
💚 Build Succeeded |
Contributor
|
@watson Feature freeze was yesterday but I think the release was delayed (and this change is isolated from everything else). Will you backport to 6.x and 6.4 or should I? |
Contributor
Author
sorenlouv
pushed a commit
that referenced
this pull request
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upcoming version of the Node.js agent (v1.12.0) will have automatically pick the a serviceName from the local package.json file and have support for the Restify framework. It's going to be released now and will be compatible with all versions of the Elastic stack from v6.2 and onwards (not sure if this PR therefore should be backported as well?).
To avoid having to keep the list of frameworks in sync, I opted for not naming any. It also gets rid of that weird ending of the sentence with support "custom Node.js" which I never really liked. But feedback is appreciated on the copy. Please also verify that the line have not become too long now?