Skip to content

Comments

[OAS] Remove doc version#225487

Merged
jloleysens merged 2 commits intoelastic:mainfrom
jloleysens:oas/remove-doc-version
Jun 27, 2025
Merged

[OAS] Remove doc version#225487
jloleysens merged 2 commits intoelastic:mainfrom
jloleysens:oas/remove-doc-version

Conversation

@jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Jun 26, 2025 •
edited by kibanamachine
Loading

Summary

Per the title. This conforms with ES API docs as rendered on our docs sites: https://www.elastic.co/docs/api/doc/elasticsearch/

Screenshot 2025-06-26 at 17 14 51

@jloleysens jloleysens self-assigned this Jun 26, 2025
@jloleysens jloleysens added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS backport:version Backport to applied version labels v8.19.0 v9.2.0 and removed backport:skip This PR does not require backporting labels Jun 26, 2025
@jloleysens jloleysens marked this pull request as ready for review June 26, 2025 15:22
@jloleysens jloleysens requested review from a team as code owners June 26, 2025 15:22
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

cc @jloleysens

TinaHeiligers
TinaHeiligers approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens jloleysens merged commit e1cbc3c into elastic:main Jun 27, 2025
27 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15924310898

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 225487

Questions ?

Please refer to the Backport tool documentation

This was referenced Jun 27, 2025
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 1, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225487 locally
cc: @jloleysens

5 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225487 locally
cc: @jloleysens

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225487 locally
cc: @jloleysens

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225487 locally
cc: @jloleysens

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225487 locally
cc: @jloleysens

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 225487 locally
cc: @jloleysens

@jloleysens jloleysens deleted the oas/remove-doc-version branch July 8, 2025 12:13
@jloleysens jloleysens mentioned this pull request Jul 8, 2025
Merged
@jloleysens
Copy link
Contributor Author

jloleysens commented Jul 8, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2025
@jloleysens
[OAS] Remove doc version (elastic#225487)
a1f42d4 
## Summary

Per the title. This conforms with ES API docs as rendered on our docs
sites: https://www.elastic.co/docs/api/doc/elasticsearch/

<img width="327" alt="Screenshot 2025-06-26 at 17 14 51"
src="https://github.com/user-attachments/assets/82f2bda0-e846-4865-bf77-7ffad1f0090a"
/>

(cherry picked from commit e1cbc3c)

# Conflicts:
#	oas_docs/kibana.info.serverless.yaml
#	oas_docs/kibana.info.yaml
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 9, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jloleysens

2 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 10, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jloleysens

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 11, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @jloleysens

jloleysens added a commit that referenced this pull request Jul 11, 2025
@jloleysens @kibanamachine
[8.19] [OAS] Remove doc version (#225487) (#227001)
a52c358 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[OAS] Remove doc version
(#225487)](#225487)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2025-06-27T10:38:12Z","message":"[OAS]
Remove doc version (#225487)\n\n## Summary\n\nPer the title. This
conforms with ES API docs as rendered on our docs\nsites:
https://www.elastic.co/docs/api/doc/elasticsearch/\n\n\n<img
width=\"327\" alt=\"Screenshot 2025-06-26 at 17 14
51\"\nsrc=\"https://github.com/user-attachments/assets/82f2bda0-e846-4865-bf77-7ffad1f0090a\"\n/>","sha":"e1cbc3c9f6176d152098b5bd4b4e042d1e3af00a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport
missing","Feature:OAS","backport:version","v8.19.0","v9.2.0"],"title":"[OAS]
Remove doc
version","number":225487,"url":"https://github.com/elastic/kibana/pull/225487","mergeCommit":{"message":"[OAS]
Remove doc version (#225487)\n\n## Summary\n\nPer the title. This
conforms with ES API docs as rendered on our docs\nsites:
https://www.elastic.co/docs/api/doc/elasticsearch/\n\n\n<img
width=\"327\" alt=\"Screenshot 2025-06-26 at 17 14
51\"\nsrc=\"https://github.com/user-attachments/assets/82f2bda0-e846-4865-bf77-7ffad1f0090a\"\n/>","sha":"e1cbc3c9f6176d152098b5bd4b4e042d1e3af00a"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225487","number":225487,"mergeCommit":{"message":"[OAS]
Remove doc version (#225487)\n\n## Summary\n\nPer the title. This
conforms with ES API docs as rendered on our docs\nsites:
https://www.elastic.co/docs/api/doc/elasticsearch/\n\n\n<img
width=\"327\" alt=\"Screenshot 2025-06-26 at 17 14
51\"\nsrc=\"https://github.com/user-attachments/assets/82f2bda0-e846-4865-bf77-7ffad1f0090a\"\n/>","sha":"e1cbc3c9f6176d152098b5bd4b4e042d1e3af00a"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

@jloleysens jloleysens

Labels

backport:version Backport to applied version labels Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.19.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jloleysens @elasticmachine @kibanamachine @bmorelli25 @TinaHeiligers