[ResponseOps][Reporting] Schedule reporting tables enhancements by js-jankisalvi · Pull Request #225449 · elastic/kibana

js-jankisalvi · 2025-06-26T13:03:13Z

Summary

This PR adds functional tests, more unit tests and addresses review comments from PR #224849

Fixes #225172 flaky test

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8485

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…s-enhancements

elasticmachine · 2025-06-26T13:03:19Z

Pinging @elastic/response-ops (Team:ResponseOps)

kibanamachine · 2025-06-26T13:54:43Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8463

[❌] x-pack/test/reporting_functional/reporting_and_security.config.ts: 7/25 tests passed.
[❌] x-pack/test/reporting_functional/reporting_without_security.config.ts: 18/25 tests passed.

see run history

…s-enhancements

kibanamachine · 2025-06-26T17:12:11Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8464

[❌] x-pack/test/reporting_functional/reporting_and_security.config.ts: 0/25 tests passed.
[❌] x-pack/test/reporting_functional/reporting_without_security.config.ts: 0/25 tests passed.

see run history

kibanamachine · 2025-06-27T09:58:02Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8477

[✅] x-pack/platform/test/reporting_functional/reporting_and_security.config.ts: 25/25 tests passed.
[✅] x-pack/platform/test/reporting_functional/reporting_without_security.config.ts: 25/25 tests passed.

see run history

kibanamachine · 2025-06-27T12:16:48Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8478

[❌] x-pack/platform/test/reporting_functional/reporting_and_security.config.ts: 69/100 tests passed.
[✅] x-pack/platform/test/reporting_functional/reporting_without_security.config.ts: 100/100 tests passed.

see run history

cnasikas

Code review only! LGTM!

cnasikas · 2025-06-27T14:37:29Z

...k/platform/plugins/private/reporting/public/management/components/report_schedules_table.tsx

+    setIsConfigFlyOutOpen(false);
+  }, [setSelectedReport, setIsConfigFlyOutOpen]);
+
+  const setReportAndOpenDisableFlyout = useCallback(


Suggested change

const setReportAndOpenDisableFlyout = useCallback(

const setReportAndOpenDisableModal = useCallback(

cnasikas · 2025-06-27T14:37:43Z

...k/platform/plugins/private/reporting/public/management/components/report_schedules_table.tsx

+    [setSelectedReport, setIsDisableModalConfirmationOpen]
+  );
+
+  const unSetReportAndCloseDisableFlyout = useCallback(() => {


Suggested change

const unSetReportAndCloseDisableFlyout = useCallback(() => {

const unSetReportAndCloseDisableModal = useCallback(() => {

cnasikas · 2025-06-27T14:41:52Z

src/platform/packages/private/kbn-reporting/public/index.ts

  share: SharePluginStart;
  actions: ActionsPublicPluginSetup;
  notifications: NotificationsStart;
+  license$: LicensingPluginStart['license$'];


For my education, what did this entry fix?

just moved from props to context

A nice. It makes sense. And because it is part of the requiredPlugins, it is getting passed in the context.

cnasikas · 2025-06-27T14:48:07Z

x-pack/platform/plugins/private/reporting/public/management/mount_management_section.tsx

-                            shareService={shareService}
-                            {...routerProps}
-                          />
+                          <ReportingTabs config={config} {...routerProps} />


Suggested change

<ReportingTabs config={config} {...routerProps} />

<ReportingTabs config={config} />

cnasikas · 2025-06-27T14:48:42Z

x-pack/platform/test/reporting_functional/reporting_and_security/management.ts

-    });
+      it('Allows user to view report details', async () => {
+        await retry.try(async () => {
+          //   await reportingFunctional.loginReportingUser();


A reminder to remove this.

kibanamachine · 2025-06-27T16:05:39Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8482

[❌] x-pack/platform/test/reporting_functional/reporting_and_security.config.ts: 68/100 tests passed.
[✅] x-pack/platform/test/reporting_functional/reporting_without_security.config.ts: 100/100 tests passed.

see run history

kibanamachine · 2025-06-27T18:32:05Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8485

[✅] x-pack/platform/test/reporting_functional/reporting_and_security.config.ts: 100/100 tests passed.
[✅] x-pack/platform/test/reporting_functional/reporting_without_security.config.ts: 100/100 tests passed.

see run history

kibanamachine · 2025-07-01T10:19:06Z

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/15996546748

elasticmachine · 2025-07-01T10:19:38Z

💚 Build Succeeded

Buildkite Build
Commit: 5389d38

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/reporting-public`	109	110	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`reporting`	158.8KB	159.2KB	+375.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/reporting-public`	116	117	+1

ESLint disabled line counts

id	before	after	diff
`reporting`	9	10	+1

Total ESLint disabled count

id	before	after	diff
`reporting`	10	11	+1

History

💛 Build #313618 was flaky 3556352
💛 Build #313517 was flaky 5bd4cc1
💚 Build #313179 succeeded 7d9a9ec

cc @js-jankisalvi

…tic#225449) ## Summary This PR adds functional tests, more unit tests and addresses review comments from PR elastic#224849 Fixes elastic#225172 flaky test **Flaky test runner:** https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8485 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3d7bcb0)

kibanamachine · 2025-07-01T10:26:07Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
✅	9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 225449

Questions ?

Please refer to the Backport tool documentation

js-jankisalvi · 2025-07-01T12:19:08Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…#225449) (#225974) # Backport This will backport the following commits from `main` to `9.1`: - [[ResponseOps][Reporting] Schedule reporting tables enhancements (#225449)](#225449)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>

#225449) (#225997) # Backport This will backport the following commits from `main` to `8.19`: - [[ResponseOps][Reporting] Schedule reporting tables enhancements (#225449)](#225449)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

js-jankisalvi added 4 commits June 25, 2025 17:48

initial commit

59fe754

add functional tests

6334fed

Merge remote-tracking branch 'upstream' into schedule-reporting-table…

24ff12d

…s-enhancements

more functional tests

c6f83bc

js-jankisalvi self-assigned this Jun 26, 2025

js-jankisalvi requested a review from a team as a code owner June 26, 2025 13:03

unskip ftr test

b613b59

js-jankisalvi added 2 commits June 26, 2025 17:27

fix flakiness

861b29f

Merge remote-tracking branch 'upstream' into schedule-reporting-table…

7d9a9ec

…s-enhancements

fix flakiness

5bd4cc1

cnasikas approved these changes Jun 27, 2025

View reviewed changes

js-jankisalvi and others added 2 commits June 27, 2025 17:32

feedback addressed

59ba01f

Merge branch 'main' into schedule-reporting-tables-enhancements

3556352

Merge branch 'main' into schedule-reporting-tables-enhancements

5389d38

js-jankisalvi enabled auto-merge (squash) July 1, 2025 08:04

js-jankisalvi merged commit 3d7bcb0 into elastic:main Jul 1, 2025
10 checks passed

js-jankisalvi deleted the schedule-reporting-tables-enhancements branch July 1, 2025 10:18

kibanamachine mentioned this pull request Jul 1, 2025

[9.1] [ResponseOps][Reporting] Schedule reporting tables enhancements (#225449) #225974

Merged

js-jankisalvi mentioned this pull request Jul 1, 2025

[8.19] [ResponseOps][Reporting] Schedule reporting tables enhancements (#225449) #225997

Merged

	const setReportAndOpenDisableFlyout = useCallback(
	const setReportAndOpenDisableModal = useCallback(

	const unSetReportAndCloseDisableFlyout = useCallback(() => {
	const unSetReportAndCloseDisableModal = useCallback(() => {

	<ReportingTabs config={config} {...routerProps} />
	<ReportingTabs config={config} />

Conversation

js-jankisalvi commented Jun 26, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Jun 26, 2025

Uh oh!

kibanamachine commented Jun 26, 2025

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8463

Uh oh!

kibanamachine commented Jun 26, 2025

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8464

Uh oh!

kibanamachine commented Jun 27, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8477

Uh oh!

kibanamachine commented Jun 27, 2025

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8478

Uh oh!

cnasikas left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

js-jankisalvi Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

cnasikas Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 27, 2025

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8482

Uh oh!

kibanamachine commented Jun 27, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8485

Uh oh!

Uh oh!

kibanamachine commented Jul 1, 2025

Uh oh!

elasticmachine commented Jul 1, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

kibanamachine commented Jul 1, 2025

💔 Some backports could not be created

Manual backport

Questions ?

Uh oh!

js-jankisalvi commented Jul 1, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

js-jankisalvi commented Jun 26, 2025 •

edited by kibanamachine

Loading