Skip to content

[storybook] Add static path to @kbn/monaco web workers #225383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clintandrewhall merged 5 commits into from
Jul 1, 2025
Merged

[storybook] Add static path to @kbn/monaco web workers #225383

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35d0fce
[storybook] Add static path to @kbn/monaco web workers
clintandrewhall Jun 26, 2025
daa14c7
Tweak to make path consistent
clintandrewhall Jun 26, 2025
d6252f9
Merge branch 'main' into fix/175196
elasticmachine Jun 28, 2025
5328147
make __kbnPublicPath__ available on topmost frame
eokoneyo Jun 28, 2025
e6bfdee
Merge branch 'main' into fix/175196
elasticmachine Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/platform/packages/shared/kbn-storybook/src/lib/default_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ export const defaultConfig: StorybookConfig = {
<meta name="eui-global" />
<meta name="emotion" />
<script>
window.__kbnPublicPath__ = { 'kbn-ui-shared-deps-npm': '', 'kbn-ui-shared-deps-src': '' };
const publicPath = window.top.location.pathname.replace(/index\.html$/, '');
// set the kbn public path values, we create a pointer on the topmost window path since this assignment will happen within an iframe
window.top.__kbnPublicPath__ = window.__kbnPublicPath__ = { 'kbn-ui-shared-deps-npm': publicPath, 'kbn-ui-shared-deps-src': publicPath, 'kbn-monaco': publicPath };
window.__kbnHardenPrototypes__ = false;
</script>
<script src="kbn-ui-shared-deps-npm.dll.js"></script>
Expand All @@ -235,6 +237,7 @@ export const defaultConfig: StorybookConfig = {
staticDirs: [
UiSharedDepsNpm.distDir,
UiSharedDepsSrc.distDir,
`${REPO_ROOT}/bazel-bin/src/platform/packages/shared/kbn-monaco/target_workers`,
{
from: `${REPO_ROOT}/src/platform/plugins/shared/kibana_react/public/assets`,
to: 'plugins/kibanaReact/assets',
Expand Down