Skip to content

Comments

[Security Solution][Sourcerer] Fix data view flash#225366

Closed
lgestc wants to merge 19 commits intoelastic:mainfrom
lgestc:default_data_view_always_populated
Closed

[Security Solution][Sourcerer] Fix data view flash#225366
lgestc wants to merge 19 commits intoelastic:mainfrom
lgestc:default_data_view_always_populated

Conversation

@lgestc
Copy link
Contributor

@lgestc lgestc commented Jun 25, 2025

Summary

Another attempt at handling flashes and undefined data view.

This time we are doing a prefetch for the default dv in particular space and then set it as initial value for the useDataView hook.

Edit: this is the new thing #225675

@lgestc lgestc requested a review from michaelolo24 June 25, 2025 19:39
@lgestc lgestc force-pushed the default_data_view_always_populated branch from 1d65860 to 4b3a80f Compare June 26, 2025 12:25
@lgestc lgestc added backport:version Backport to applied version labels v9.1.0 v8.19.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team labels Jun 26, 2025
@elastic elastic deleted a comment from elasticmachine Jun 26, 2025
@lgestc lgestc marked this pull request as ready for review June 27, 2025 12:14
@lgestc lgestc requested review from a team as code owners June 27, 2025 12:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elastic elastic deleted a comment from elasticmachine Jun 27, 2025
@elastic elastic deleted a comment from elasticmachine Jun 27, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 27, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / DataProviders rendering it renders the data providers
  • [job] [logs] Jest Tests #10 / DataProviders rendering it renders the data providers
  • [job] [logs] Jest Tests #10 / DataProviders rendering it should render a placeholder when there are zero data providers
  • [job] [logs] Jest Tests #10 / DataProviders rendering it should render a placeholder when there are zero data providers
  • [job] [logs] Jest Tests #10 / DataProviders rendering renders correctly against snapshot
  • [job] [logs] Jest Tests #10 / DataProviders rendering renders correctly against snapshot
  • [job] [logs] Jest Tests #10 / DataProviders rendering resizable drop target it automatically displays scroll bars when the width or height of the data providers exceeds the drop target
  • [job] [logs] Jest Tests #10 / DataProviders rendering resizable drop target it automatically displays scroll bars when the width or height of the data providers exceeds the drop target
  • [job] [logs] Jest Tests #10 / DataProviders rendering resizable drop target it may be resized vertically via a resize handle
  • [job] [logs] Jest Tests #10 / DataProviders rendering resizable drop target it may be resized vertically via a resize handle
  • [job] [logs] Jest Tests #10 / DataProviders rendering resizable drop target it never grows taller than one third (33%) of the view height
  • [job] [logs] Jest Tests #10 / DataProviders rendering resizable drop target it never grows taller than one third (33%) of the view height
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent renders correctly
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent renders correctly
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent renders the chart panels
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent renders the chart panels
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent should pass building block filter to the alert Page Controls
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent should pass building block filter to the alert Page Controls
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent should pass threat Indicator filter to the alert Page Controls
  • [job] [logs] Jest Tests #16 / DetectionEnginePageComponent should pass threat Indicator filter to the alert Page Controls
  • [job] [logs] Jest Tests #10 / Eql Header full screen should render the exit full screen component
  • [job] [logs] Jest Tests #10 / Eql Header full screen should render the exit full screen component
  • [job] [logs] Jest Tests #10 / Eql Header rendering should render the date picker
  • [job] [logs] Jest Tests #10 / Eql Header rendering should render the date picker
  • [job] [logs] Jest Tests #10 / Eql Header rendering should render the eql query bar
  • [job] [logs] Jest Tests #10 / Eql Header rendering should render the eql query bar
  • [job] [logs] Jest Tests #10 / Eql Header rendering should render the sourcerer selector
  • [job] [logs] Jest Tests #10 / Eql Header rendering should render the sourcerer selector
  • [job] [logs] Jest Tests #10 / OpenTimelineModal it installs elastic prebuilt templates
  • [job] [logs] Jest Tests #10 / OpenTimelineModal it installs elastic prebuilt templates
  • [job] [logs] Jest Tests #10 / OpenTimelineModal it renders the expected modal
  • [job] [logs] Jest Tests #10 / OpenTimelineModal it renders the expected modal
  • [job] [logs] Jest Tests #10 / TimelineBottomBar should dispatch show action when clicking on the title
  • [job] [logs] Jest Tests #10 / TimelineBottomBar should dispatch show action when clicking on the title
  • [job] [logs] Jest Tests #10 / TimelineBottomBar should not render the event count badge if timeline is open
  • [job] [logs] Jest Tests #10 / TimelineBottomBar should not render the event count badge if timeline is open
  • [job] [logs] Jest Tests #10 / TimelineBottomBar should render all components for bottom bar
  • [job] [logs] Jest Tests #10 / TimelineBottomBar should render all components for bottom bar
  • [job] [logs] Jest Tests #10 / TimelinesPage should not show import button or modal if user does not have crud privileges but it should show the new timeline button
  • [job] [logs] Jest Tests #10 / TimelinesPage should not show import button or modal if user does not have crud privileges but it should show the new timeline button
  • [job] [logs] Jest Tests #10 / TimelinesPage should render landing page if no indicesExist
  • [job] [logs] Jest Tests #10 / TimelinesPage should render landing page if no indicesExist
  • [job] [logs] Jest Tests #10 / TimelinesPage should show the correct elements if user has crud
  • [job] [logs] Jest Tests #10 / TimelinesPage should show the correct elements if user has crud

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7779 7782 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +884.0B
Unknown metric groups

ESLint disabled in files

id before after diff
securitySolution 98 99 +1

Total ESLint disabled count

id before after diff
securitySolution 728 729 +1

History

@lgestc lgestc marked this pull request as draft June 27, 2025 15:56
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-renovate-helper for this PR!

@lgestc lgestc closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants