Using migrated roles on Fleet server side#225358
Closed
gergoabraham wants to merge 1 commit intoelastic:mainfrom
Closed
Using migrated roles on Fleet server side#225358gergoabraham wants to merge 1 commit intoelastic:mainfrom
gergoabraham wants to merge 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💔 Build Failed
Failed CI Steps |
Contributor
Author
|
closing in favor of #225678 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
So far this is only an acceptance test which should fail until the underlying issue is not fixed.
With the given scenario a suspected underlying bug can be brought forward:
endpointManagementSpaceAwarenessEnabledfeature flag is enabled: this requires users to haveglobal_artifact_management_allprivilege for modifying global artifactssiemorsiemV2featureThe role migration introduced in #219566 makes sure that these users have the new
global_artifact_management_allprivilege, and this works in most cases, but seemingly, on server side when validating an API call, it does not applied.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.