Skip to content

[8.19] unify csv icon across app in export menu (#224752)#225338

Merged
eokoneyo merged 1 commit intoelastic:8.19from
eokoneyo:backport/8.19/pr-224752
Jun 25, 2025
Merged

[8.19] unify csv icon across app in export menu (#224752)#225338
eokoneyo merged 1 commit intoelastic:8.19from
eokoneyo:backport/8.19/pr-224752

Conversation

@eokoneyo
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

This PR unifies the icon displayed for CSV exports across kibana

<img width="285" alt="Screenshot 2025-06-20 at 20 37 47"
src="https://github.com/user-attachments/assets/7510332b-d9d0-458e-a73d-950fc84fdb48"
/>

<!--

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

-->

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 2435f29)
@eokoneyo eokoneyo requested a review from kibanamachine as a code owner June 25, 2025 16:47
@eokoneyo eokoneyo added the backport This PR is a backport of another PR label Jun 25, 2025
@eokoneyo eokoneyo enabled auto-merge (squash) June 25, 2025 16:47
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / InfraOps App Metrics UI Metrics UI Anomaly Flyout anomalies table in flyout with anomalies present should take users to hosts list when 'Show affected Hosts' is clicked
  • [job] [logs] FTR Configs #37 / Rules Management - Rule Bulk Action API @ess @serverless @skipInServerless perform_bulk_action @skipInServerlessMKI fill gaps run action should trigger the backfilling of the gaps for the rules in the request

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 59.4KB 59.5KB +10.0B
reporting 53.5KB 53.5KB +9.0B
total +19.0B

@eokoneyo eokoneyo merged commit 0ac371d into elastic:8.19 Jun 25, 2025
11 checks passed
@eokoneyo eokoneyo deleted the backport/8.19/pr-224752 branch June 25, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants