[Query Rules] Query rules telemetry by efegurkan · Pull Request #225146 · elastic/kibana

efegurkan · 2025-06-24T18:51:49Z

Summary

Adds telemetry to query rules UIs

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

…idations

…emetry

…apping'

TattdCodeMonkey

Left some comments but overall LGTM.

TattdCodeMonkey · 2025-06-24T22:06:20Z

.../solutions/search/plugins/search_query_rules/public/components/empty_prompt/empty_prompt.tsx

                      defaultMessage: 'Create in Console',
                    })}
                    showIcon
+                    onClick={() => {


FYI: the TryInConsoleButton can also take a custom data-test-subj now that can be used for tracking click events.

TattdCodeMonkey · 2025-06-24T22:08:50Z

x-pack/solutions/search/plugins/search_query_rules/public/types.ts

 import { AppMountParameters, CoreStart } from '@kbn/core/public';
 import type { ConsolePluginStart } from '@kbn/console-plugin/public';
 import type { SharePluginStart } from '@kbn/share-plugin/public';
+import { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';


nitpick:

Suggested change

import { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';

import type { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';

TattdCodeMonkey · 2025-06-24T22:09:56Z

x-pack/solutions/search/plugins/search_query_rules/public/hooks/use_fetch_query_rules_sets.ts

      );
    },
    retry: false,
+    refetchInterval: 2000,


that's pretty aggressive refetch interval, is it arbitrary?

It was to refetch when something is added via devtools as a workaround. It is arbitrary I will just remove it, not worth it.

elasticmachine · 2025-06-24T22:39:52Z

💚 Build Succeeded

Buildkite Build
Commit: 864cf5e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`searchQueryRules`	146	148	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`searchQueryRules`	115.7KB	118.7KB	+3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`searchQueryRules`	5.7KB	5.7KB	+63.0B

Samiul-TheSoccerFan

nice work :clap

...earch/plugins/search_query_rules/public/components/query_rules_sets/delete_ruleset_modal.tsx

gsoldevila

Core changes LGTM: new 'search_query_rules' app registered on UI counters

kibanamachine · 2025-06-25T17:14:20Z

Starting backport for target branches: 8.19, 9.2

https://github.com/elastic/kibana/actions/runs/15882776824

kibanamachine · 2025-06-25T17:20:54Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
❌	9.2	The branch "9.2" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 225146

Questions ?

Please refer to the Backport tool documentation

efegurkan · 2025-06-26T11:01:08Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary Adds telemetry to query rules UIs ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit cae3861) # Conflicts: # x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_flyout/use_query_rule_flyout_state.ts

kibanamachine · 2025-06-27T17:49:05Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @efegurkan

# Backport This will backport the following commits from `main` to `8.19`: - [[Query Rules] Query rules telemetry (#225146)](#225146)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

efegurkan added 6 commits June 18, 2025 17:35

WIP

fd934a1

Merge branch 'main' of github.com:elastic/kibana into query-rules-val…

a93136a

…idations

Add validations and move the isDirty check to rhf

58c7be9

Review changes

859d5f0

Add telemetry data

57f3be2

Merge branch 'main' of github.com:elastic/kibana into query-rules-tel…

c2938bb

…emetry

efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:Search backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 labels Jun 24, 2025

efegurkan marked this pull request as ready for review June 24, 2025 20:53

efegurkan requested review from a team as code owners June 24, 2025 20:53

[CI] Auto-commit changed files from 'node scripts/styled_components_m…

864cf5e

…apping'

TattdCodeMonkey approved these changes Jun 24, 2025

View reviewed changes

Samiul-TheSoccerFan approved these changes Jun 25, 2025

View reviewed changes

...earch/plugins/search_query_rules/public/components/query_rules_sets/delete_ruleset_modal.tsx Outdated Show resolved Hide resolved

efegurkan added 2 commits June 25, 2025 14:29

Review changes

2105c19

Review changes

6dffe63

gsoldevila approved these changes Jun 25, 2025

View reviewed changes

efegurkan merged commit cae3861 into elastic:main Jun 25, 2025
11 checks passed

efegurkan mentioned this pull request Jun 26, 2025

[8.19] [Query Rules] Query rules telemetry (#225146) #225432

Merged

This was referenced Jun 26, 2025

[Security Solution] Adds ability to revert prebuilt rules to their base version #223301

Merged

[Oblt Onboarding] Add more errors logging for Auto Detect flow #222948

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 27, 2025

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 29, 2025

	import { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';
	import type { UsageCollectionStart } from '@kbn/usage-collection-plugin/public';

Comments

Conversation

efegurkan commented Jun 24, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

TattdCodeMonkey left a comment

Choose a reason for hiding this comment

Uh oh!

TattdCodeMonkey Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

TattdCodeMonkey Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

TattdCodeMonkey Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

efegurkan Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 24, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

Uh oh!

Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gsoldevila left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jun 25, 2025

Uh oh!

kibanamachine commented Jun 25, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

efegurkan commented Jun 26, 2025

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

efegurkan commented Jun 24, 2025 •

edited by kibanamachine

Loading