Skip to content

Comments

[One Discover][Security Solution] Replace the use of Ecsflat with fieldsMetadata#225105

Merged
logeekal merged 2 commits intoelastic:mainfrom
logeekal:fix/fields_metadata
Jun 25, 2025
Merged

[One Discover][Security Solution] Replace the use of Ecsflat with fieldsMetadata#225105
logeekal merged 2 commits intoelastic:mainfrom
logeekal:fix/fields_metadata

Conversation

@logeekal
Copy link
Contributor

@logeekal logeekal commented Jun 24, 2025

Summary

As per comments by @davismcphee , this PR removes the usage of EcsFlat and replaces it with fieldsMetadata.

@logeekal logeekal requested review from a team as code owners June 24, 2025 15:25
@logeekal logeekal added Team:Threat Hunting Security Solution Threat Hunting Team backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 24, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@logeekal logeekal added the release_note:skip Skip the PR/issue when compiling release notes label Jun 24, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #95 / Alerts and alerts index related logic - Basic License/Essentials Tier @ess @serverless @serverlessQA query_signals_route and find_alerts_route runtime fields "before each" hook for "should be able to filter using a runtime field defined in the request"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1331 1329 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/discover-utils 316 317 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.1MB 1.1MB -7.4KB
Unknown metric groups

API count

id before after diff
@kbn/discover-utils 366 367 +1

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and did some smoke test locally, everything looks good!

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM, thanks for addressing it so quickly!

@logeekal logeekal merged commit 2ed4e8a into elastic:main Jun 25, 2025
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15869029849

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 25, 2025
…ldsMetadata (elastic#225105)

## Summary

As per
[comments](elastic#204756 (comment))
by @davismcphee , this PR removes the usage of `EcsFlat` and replaces it
with `fieldsMetadata`.

(cherry picked from commit 2ed4e8a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 25, 2025
…ith fieldsMetadata (#225105) (#225205)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[One Discover][Security Solution] Replace the use of Ecsflat with
fieldsMetadata (#225105)](#225105)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2025-06-25T06:28:05Z","message":"[One
Discover][Security Solution] Replace the use of Ecsflat with
fieldsMetadata (#225105)\n\n## Summary\n\nAs
per\n[comments](https://github.com/elastic/kibana/pull/204756#discussion_r2162038673)\nby
@davismcphee , this PR removes the usage of `EcsFlat` and replaces
it\nwith
`fieldsMetadata`.","sha":"2ed4e8a3411dc7825eb8fd5d42f6418a3eed00c5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","backport:version","v9.1.0","v8.19.0"],"title":"[One
Discover][Security Solution] Replace the use of Ecsflat with
fieldsMetadata","number":225105,"url":"https://github.com/elastic/kibana/pull/225105","mergeCommit":{"message":"[One
Discover][Security Solution] Replace the use of Ecsflat with
fieldsMetadata (#225105)\n\n## Summary\n\nAs
per\n[comments](https://github.com/elastic/kibana/pull/204756#discussion_r2162038673)\nby
@davismcphee , this PR removes the usage of `EcsFlat` and replaces
it\nwith
`fieldsMetadata`.","sha":"2ed4e8a3411dc7825eb8fd5d42f6418a3eed00c5"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225105","number":225105,"mergeCommit":{"message":"[One
Discover][Security Solution] Replace the use of Ecsflat with
fieldsMetadata (#225105)\n\n## Summary\n\nAs
per\n[comments](https://github.com/elastic/kibana/pull/204756#discussion_r2162038673)\nby
@davismcphee , this PR removes the usage of `EcsFlat` and replaces
it\nwith
`fieldsMetadata`.","sha":"2ed4e8a3411dc7825eb8fd5d42f6418a3eed00c5"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
…ldsMetadata (elastic#225105)

## Summary

As per
[comments](elastic#204756 (comment))
by @davismcphee , this PR removes the usage of `EcsFlat` and replaces it
with `fieldsMetadata`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants