Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
| children, | ||
| ...props | ||
| }) => { | ||
| const newDataViewPickerEnabled = useIsExperimentalFeatureEnabled('newDataViewPickerEnabled'); |
There was a problem hiding this comment.
enable cell actions in flyouts
| const getFieldSpec = useGetFieldSpec(sourcererScope); | ||
| const oldGetFieldSpec = useGetFieldSpec(sourcererScope); | ||
|
|
||
| const getFieldSpec = useCallback( |
There was a problem hiding this comment.
enable cell actions in explore tables
| const indexFieldsSearch = useCallback( | ||
| (iNames: string[]) => { | ||
| const asyncSearch = async () => { | ||
| console.trace('useFetchIndex is deprecated, use useDataView instead: ', indexNames); |
There was a problem hiding this comment.
ignore, was using for debugging purposes
| fields: 'fields', | ||
| }, | ||
| }; | ||
| // return { |
There was a problem hiding this comment.
Ignore, need to investigate whats going on here
| searchable: false, | ||
| } | ||
| columns.map((column) => | ||
| newDataViewPickerEnabled |
There was a problem hiding this comment.
enable cell actions for alerts table
| if (newDataViewPickerEnabled) { | ||
| return; | ||
| } | ||
| if (selectedDataView == null || missingPatterns.length > 0) { |
There was a problem hiding this comment.
@lgestc need to investigate whether one of my changes introduced this, but since defaultDataView is never set in sourcerer...opening up a timeline causes this to run in an infinite loop. Still need to dig into what the code path for this is, but it most likely involves useCreateTimeline and/or useUpdateTimeline
| if (existingField && existingField.isMapped) { | ||
| // mapped field, remove runtimeField def | ||
| existingField.runtimeField = undefined; | ||
| this.fields.clearSpecCache(); |
There was a problem hiding this comment.
Built on top of this PR: #224767 to test performance
| expect(savedObjectsClient.find).toHaveBeenCalledTimes(2); | ||
| }); | ||
|
|
||
| test('caches fields toSpec calls', async () => { |
There was a problem hiding this comment.
Built on top of this PR: #224767 to test performance
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| import { fieldList, IIndexPatternFieldList } from './field_list'; |
There was a problem hiding this comment.
Built on top of this PR: #224767 to test performance
| */ | ||
| create(field: FieldSpec): DataViewField; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Built on top of this PR: #224767 to test performance
2 participants
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.