Skip to content

[8.19] [Logs] Replace log stream component (#219425)#224558

Merged
achyutjhunjhunwala merged 24 commits intoelastic:8.19from
achyutjhunjhunwala:backport/8.19/pr-219425
Jun 22, 2025
Merged

[8.19] [Logs] Replace log stream component (#219425)#224558
achyutjhunjhunwala merged 24 commits intoelastic:8.19from
achyutjhunjhunwala:backport/8.19/pr-219425

Conversation

@achyutjhunjhunwala
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

closes elastic/logs-dev#111
closes elastic#200668
closes elastic/opentelemetry-dev#792
closes elastic#89042
closes elastic#221746
closes elastic#91717
closes elastic#91717

The PR does the following

- Enhances the `enableDocumentViewer` API in the Embeddable to also hide
Quality issues and Stacktrace Columns for obs context when the expand
icon is also hidden
- Add a `Columns` Props the the embeddable so that a new profile is not
required to be created when custom columns are required
- Replaces Log Stream component in all remaining places

- [x] APM - Transactions Details Page

<img width="849" alt="image"
src="https://github.com/user-attachments/assets/74e0469b-eecb-461f-98f5-5f0e51f30a59"
/>

- [x] Logs tab in the hosts' view page

<img width="1546" alt="image"
src="https://github.com/user-attachments/assets/aae48330-42ca-4717-8cba-cc9974842045"
/>

- [x] Logs Tab in Host Detail view

<img width="2559" alt="image"
src="https://github.com/user-attachments/assets/c0184098-f4f7-437f-beb2-c0931ddd1a6a"
/>

- [x] Logs Tab in the Flyout from the main Hosts page

<img width="2547" alt="image"
src="https://github.com/user-attachments/assets/3578022c-1ac2-4ad2-9968-e472926544a3"
/>

- [x] Fleet Agent Logs

<img width="722" alt="image"
src="https://github.com/user-attachments/assets/78e66fa6-7872-482e-ba6d-80f10c5e3c4b"
/>

- [x] Logs Categories Page

<img width="1348" alt="image"
src="https://github.com/user-attachments/assets/395e531c-f31e-4316-9604-ee08263c0083"
/>

## What's Pending ?

Code for the old Log Stream Component will be cleaned up in the
following PR

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d9ebb93)

# Conflicts:
#	x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_details_page/components/agent_logs/agent_logs.test.tsx
#	x-pack/platform/plugins/shared/fleet/public/plugin.ts
#	x-pack/platform/plugins/shared/fleet/tsconfig.json
#	x-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/logs/logs.tsx
#	x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/tabs/logs/logs_link_to_stream.tsx
#	x-pack/solutions/observability/plugins/infra/public/plugin.ts
#	x-pack/solutions/observability/plugins/infra/tsconfig.json
@achyutjhunjhunwala achyutjhunjhunwala added the backport This PR is a backport of another PR label Jun 19, 2025
@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) June 19, 2025 12:10
@botelastic botelastic bot added Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Jun 19, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@achyutjhunjhunwala achyutjhunjhunwala merged commit faa6034 into elastic:8.19 Jun 22, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / Category can submit without setting a category

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1359 1360 +1
fleet 1192 1262 +70
infra 1715 1488 -227
total -156

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
logsShared 293 295 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +271.0B
discover 1.1MB 1.1MB +1.5KB
fleet 1.6MB 1.6MB -554.0B
infra 1.7MB 1.2MB -505.7KB
total -504.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 34.9KB 34.8KB -140.0B
discover 22.0KB 22.3KB +228.0B
fleet 155.1KB 155.0KB -157.0B
infra 56.2KB 47.9KB -8.3KB
logsShared 155.3KB 155.4KB +34.0B
total -8.3KB
Unknown metric groups

API count

id before after diff
logsShared 323 325 +2

async chunk count

id before after diff
fleet 9 10 +1
infra 37 34 -3
total -2

References to deprecated APIs

id before after diff
infra 2 1 -1

History

@achyutjhunjhunwala achyutjhunjhunwala deleted the backport/8.19/pr-219425 branch June 23, 2025 05:46
achyutjhunjhunwala added a commit that referenced this pull request Jul 9, 2025
… on 8.19 (#226272)

## Summary

As part of #224558, Log Stream was
removed from 8.19.
But it must stay in 8.19 behind the Kibana Advance Settings and only be
removed in 9.1 .

This PR brings back the page and its corresponding FTR tests

## With Kibana Advance Setting - On

<img width="2544" alt="image"
src="https://github.com/user-attachments/assets/d81d4407-9861-4d73-b899-267da51df71b"
/>

## With Kibana Advance Setting - Off

<img width="1145" alt="image"
src="https://github.com/user-attachments/assets/042aa0e9-9d6e-434c-ae91-c5e667800e3b"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants